build(deps): bump github.com/openshift-online/ocm-cli from 1.0.10 to 1.0.13#918
Conversation
dependabot
bot
added
area/dependency
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (3)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughUpdated dependency versions in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dependabot[bot] The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @dependabot[bot]. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@go.mod`:
- Line 35: The go.mod currently pins k8s.io/apimachinery at v0.34.3 while
k8s.io/api, k8s.io/cli-runtime, and k8s.io/client-go are at v0.30.3, causing
minor-version skew; update k8s.io/apimachinery to the same minor release as the
others (e.g., v0.30.3) so all four Kubernetes direct dependencies
(k8s.io/apimachinery, k8s.io/api, k8s.io/cli-runtime, k8s.io/client-go) are
aligned to the same minor version to avoid type incompatibilities, then run go
mod tidy and run tests/build to verify no import/type errors.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 378dc849-c54e-46ee-8393-44678f783055
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (1)
go.mod
| gopkg.in/AlecAivazis/survey.v1 v1.8.8 | ||
| k8s.io/api v0.30.3 | ||
| k8s.io/apimachinery v0.30.3 | ||
| k8s.io/apimachinery v0.34.3 |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== Direct k8s dependency versions from go.mod =="
rg -n '^\s*k8s\.io/(api|apimachinery|cli-runtime|client-go)\s+v' go.mod
echo
echo "== Repository imports of k8s.io modules (context) =="
rg -n --type go -C2 '"k8s\.io/(api|apimachinery|cli-runtime|client-go)(/|")'
echo
echo "== Note =="
echo "If mixed minors are not explicitly required, align these four direct modules to one minor (typically the same release train)."Repository: openshift/backplane-cli
Length of output: 14513
Align Kubernetes direct dependency minors to avoid version-skew incompatibilities.
k8s.io/apimachinery v0.34.3 (Line 35) is four minor versions ahead of its Kubernetes peers: k8s.io/api, k8s.io/cli-runtime, and k8s.io/client-go are all pinned to v0.30.3 (Lines 34, 36–37). The codebase actively imports types from all four modules across 30+ files—including metav1 and k8serrors from the newer apimachinery alongside core API types from the older release. This mismatch introduces risk of type incompatibilities at runtime.
Align these four direct modules to the same minor version (typically the same Kubernetes release train).
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@go.mod` at line 35, The go.mod currently pins k8s.io/apimachinery at v0.34.3
while k8s.io/api, k8s.io/cli-runtime, and k8s.io/client-go are at v0.30.3,
causing minor-version skew; update k8s.io/apimachinery to the same minor release
as the others (e.g., v0.30.3) so all four Kubernetes direct dependencies
(k8s.io/apimachinery, k8s.io/api, k8s.io/cli-runtime, k8s.io/client-go) are
aligned to the same minor version to avoid type incompatibilities, then run go
mod tidy and run tests/build to verify no import/type errors.
fb2b9ed to
16e2d61
Compare
|
@coderabbitai what coding guidelines are you using for this repo? |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain
🏁 Script executed: Length of output: 682 🛠 Debug Information Gathered
📋 Repository Linting (
|
| Setting | Value |
|---|---|
| Enabled linters | errcheck, gosec, govet, ineffassign, staticcheck, unused |
| Download mode | readonly |
| Exclusion presets | comments, common-false-positives, legacy, std-error-handling |
| Excluded paths | third_party$, builtin$, examples$ |
| Generated files | treated with lax exclusions |
🐰 CodeRabbit Review Configuration
Review profile: chill — focuses on meaningful issues, avoids nitpicks.
Global review instruction (applies to all files):
Focus on major issues impacting performance, readability, maintainability and security. Avoid nitpicks and avoid verbosity.
Path filters: vendor/** and **/vendor/** are excluded from review.
Active static analysis tools (all enabled, relevant ones for this Go repo):
golangci-lint(v2.11.4) — uses the repo's.golangci.ymlactionlint— checks GitHub Actions workflowsshellcheck— checks shell scriptsmarkdownlint— checks Markdown filesyamllint— checks YAML filesgitleaks+trufflehog— secret scanningcheckov+trivy— IaC security scanningosvScanner— dependency vulnerability scanninghadolint— Dockerfile linting
Other notable settings:
- Knowledge base opt-out:
true(no cross-PR learning persistence) - Web search: disabled
- Learnings scope:
local(repo-only) - No custom pre-merge checks configured
- No path-specific override instructions beyond the global one above
dependabot
bot
force-pushed
the
dependabot/go_modules/github.com/openshift-online/ocm-cli-1.0.13
branch
from
16e2d61 to
7157164
Compare
Bumps [github.com/openshift-online/ocm-cli](https://github.com/openshift-online/ocm-cli) from 1.0.10 to 1.0.13. - [Release notes](https://github.com/openshift-online/ocm-cli/releases) - [Changelog](https://github.com/openshift-online/ocm-cli/blob/main/CHANGES.md) - [Commits](openshift-online/ocm-cli@v1.0.10...v1.0.13) --- updated-dependencies: - dependency-name: github.com/openshift-online/ocm-cli dependency-version: 1.0.13 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
force-pushed
the
dependabot/go_modules/github.com/openshift-online/ocm-cli-1.0.13
branch
from
7157164 to
57d920c
Compare
|
@dependabot[bot]: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
1 participant
Bumps github.com/openshift-online/ocm-cli from 1.0.10 to 1.0.13.
Release notes
Sourced from github.com/openshift-online/ocm-cli's releases.
... (truncated)
Changelog
Sourced from github.com/openshift-online/ocm-cli's changelog.
... (truncated)
Commits
e621c19Merge pull request #1072 from miguelhbrito/release_1.0.138378277Release v1.0.13240cfdaMerge pull request #1066 from rcampos2029/OCM-2296799247a8[OCM-22967](https://redhat.atlassian.net/browse/OCM-22967) | chore: bump ocm-sdk-gofcdd49bMerge pull request #1062 from rcampos2029/OCM-2128924cb99c[OCM-21289](https://redhat.atlassian.net/browse/OCM-21289) | feat: display excluded namespace selectors in ingress describee8f8ba0[OCM-23143](https://redhat.atlassian.net/browse/OCM-23143) | fix: describe clusters with missing dns_domain records (#1060)ab08e47konflux: hermetic builds (#1061)5a969a5Red Hat Konflux update ocm-cli (#1059)724f243chore: bump pipeline refs (#1058)