Skip to content

Conversation

@bergmannf
Copy link
Contributor

The script should try to do all required steps and use sensible defaults.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 15, 2026
@openshift-ci openshift-ci bot requested review from eth1030 and xiaoyu74 January 15, 2026 13:53
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 15, 2026
@bergmannf bergmannf force-pushed the pko-migration-script branch 3 times, most recently from 31b70d3 to 9138028 Compare January 15, 2026 15:08
Copy link
Contributor

@joshbranham joshbranham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I obviously haven't run it and there are no tests, but am inferring that you have tested it ;)

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2026
@bergmannf bergmannf force-pushed the pko-migration-script branch from 9138028 to a882d4b Compare January 16, 2026 08:27
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2026
@bergmannf bergmannf changed the title [WIP] Add a script to migrate an operator from OLM to PKO. Add a script to migrate an operator from OLM to PKO. Jan 16, 2026
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 16, 2026
@bergmannf
Copy link
Contributor Author

Looks good to me, I obviously haven't run it and there are no tests, but am inferring that you have tested it ;)

I've added some tests to verify it does what it says it does at least - those can be run without actually converting an operator.

@joshbranham
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 16, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bergmannf, joshbranham

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [bergmannf,joshbranham]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit b7e444a into openshift:master Jan 16, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants