Skip to content

WIP: OCPBUGS-105168: Bump openshift/api which adds HAProxy version API - #1545

Open
jcmoraisjr wants to merge 1 commit into
openshift:release-4.22from
jcmoraisjr:OCPBUGS-105168-haproxy-version
Open

WIP: OCPBUGS-105168: Bump openshift/api which adds HAProxy version API#1545
jcmoraisjr wants to merge 1 commit into
openshift:release-4.22from
jcmoraisjr:OCPBUGS-105168-haproxy-version

Conversation

@jcmoraisjr

Copy link
Copy Markdown
Member

Update openshift/api version, which adds the HAProxy version API. This is an API only update, carried to the new OpenShift version, which deploys HAProxy as specified.

EP: openshift/enhancements#1965

Jira: https://redhat.atlassian.net/browse/OCPBUGS-105168

Update openshift/api version, which adds the HAProxy version API. This
is an API only update, carried to the new OpenShift version, which
deploys HAProxy as specified.

EP: openshift/enhancements#1965

Jira: https://redhat.atlassian.net/browse/OCPBUGS-105168
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 7, 2026
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Aug 7, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@jcmoraisjr: This pull request references Jira Issue OCPBUGS-105168, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-105261 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-105261 targets the "5.0.0" version, which is one of the valid target versions: 5.0.0
  • bug has dependents

Requesting review from QA contact:
/cc @melvinjoseph86

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Update openshift/api version, which adds the HAProxy version API. This is an API only update, carried to the new OpenShift version, which deploys HAProxy as specified.

EP: openshift/enhancements#1965

Jira: https://redhat.atlassian.net/browse/OCPBUGS-105168

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Aug 7, 2026
@openshift-ci
openshift-ci Bot requested a review from melvinjoseph86 August 7, 2026 21:08
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci
openshift-ci Bot requested review from frobware and rfredette August 7, 2026 21:08
@openshift-ci

openshift-ci Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign candita for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)
  • master

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 2a23e3e5-35d8-4cb6-b29c-d488fdb978fa

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

@jcmoraisjr: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci

openshift-ci Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

@jcmoraisjr: This PR was included in a payload test run from openshift/origin#31495
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-ci-5.0-upgrade-from-stable-4.22-e2e-aws-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c80a2da0-92a7-11f1-9749-1b41a869f83d-0

@openshift-ci

openshift-ci Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

@jcmoraisjr: This PR was included in a payload test run from openshift/origin#31495
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-ci-5.0-e2e-aws-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/03588550-92a8-11f1-8016-b7673b47292e-0

@openshift-ci

openshift-ci Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

@jcmoraisjr: This PR was included in a payload test run from openshift/origin#31495
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-ci-4.22-e2e-aws-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/204e9d20-92a8-11f1-96af-9e21d2a7ed7f-0

@melvinjoseph86

Copy link
Copy Markdown

Tested with clusterbot


➜  oc get clusterversion
NAME      VERSION                                                AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.22.0-0-2026-08-10-140800-test-ci-ln-npddg5b-latest   True        False         66m     Cluster version is 4.22.0-0-2026-08-10-140800-test-ci-ln-npddg5b-latest

➜  oc apply -f https://raw.githubusercontent.com/jcmoraisjr/openshift-cluster-ingress-operator/e636316b3912fda407614a225529e553f3e23666/manifests/00-custom-resource-definition.yaml
Warning: resource customresourcedefinitions/ingresscontrollers.operator.openshift.io is missing the kubectl.kubernetes.io/last-applied-configuration annotation which is required by oc apply. oc apply should only be used on resources created declaratively by either oc create --save-config or oc apply. The missing annotation will be patched automatically.
customresourcedefinition.apiextensions.k8s.io/ingresscontrollers.operator.openshift.io configured
➜  oc patch ingresscontroller/default -n openshift-ingress-operator \
    --type=merge -p '{"spec":{"haproxyVersion":"2.8"}}'
ingresscontroller.operator.openshift.io/default patched
➜  oc get ingresscontroller/default -n openshift-ingress-operator -o jsonpath='{.spec.haproxyVersion}'
2.8% 

➜  oc patch ingresscontroller/default -n openshift-ingress-operator   --type=merge -p '{"spec":{"haproxyVersion":"2.6"}}'
The IngressController "default" is invalid: 
* spec.haproxyVersion: Unsupported value: "2.6": supported values: "2.8"
* <nil>: Invalid value: null: some validation rules were not checked because the object was invalid; correct the existing errors to complete validation

➜  oc patch ingresscontroller/default -n openshift-ingress-operator   --type=merge -p '{"spec":{"haproxyVersion":"3.2"}}'
The IngressController "default" is invalid: 
* spec.haproxyVersion: Unsupported value: "3.2": supported values: "2.8"
* <nil>: Invalid value: null: some validation rules were not checked because the object was invalid; correct the existing errors to complete validation

/verified by @mjoseph

@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@melvinjoseph86: This PR has been marked as verified by @mjoseph.

Details

In response to this:

Tested with clusterbot


➜  oc get clusterversion
NAME      VERSION                                                AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.22.0-0-2026-08-10-140800-test-ci-ln-npddg5b-latest   True        False         66m     Cluster version is 4.22.0-0-2026-08-10-140800-test-ci-ln-npddg5b-latest

➜  oc apply -f https://raw.githubusercontent.com/jcmoraisjr/openshift-cluster-ingress-operator/e636316b3912fda407614a225529e553f3e23666/manifests/00-custom-resource-definition.yaml
Warning: resource customresourcedefinitions/ingresscontrollers.operator.openshift.io is missing the kubectl.kubernetes.io/last-applied-configuration annotation which is required by oc apply. oc apply should only be used on resources created declaratively by either oc create --save-config or oc apply. The missing annotation will be patched automatically.
customresourcedefinition.apiextensions.k8s.io/ingresscontrollers.operator.openshift.io configured
➜  oc patch ingresscontroller/default -n openshift-ingress-operator \
   --type=merge -p '{"spec":{"haproxyVersion":"2.8"}}'
ingresscontroller.operator.openshift.io/default patched
➜  oc get ingresscontroller/default -n openshift-ingress-operator -o jsonpath='{.spec.haproxyVersion}'
2.8% 

➜  oc patch ingresscontroller/default -n openshift-ingress-operator   --type=merge -p '{"spec":{"haproxyVersion":"2.6"}}'
The IngressController "default" is invalid: 
* spec.haproxyVersion: Unsupported value: "2.6": supported values: "2.8"
* <nil>: Invalid value: null: some validation rules were not checked because the object was invalid; correct the existing errors to complete validation

➜  oc patch ingresscontroller/default -n openshift-ingress-operator   --type=merge -p '{"spec":{"haproxyVersion":"3.2"}}'
The IngressController "default" is invalid: 
* spec.haproxyVersion: Unsupported value: "3.2": supported values: "2.8"
* <nil>: Invalid value: null: some validation rules were not checked because the object was invalid; correct the existing errors to complete validation

/verified by @mjoseph

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants