Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-34525: Add "check-api-lb" subcommand #1678

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

OCPBUGS-34525: Add "check-api-lb" subcommand #1678

wants to merge 1 commit into from

Conversation

vrutkovs
Copy link
Member

@vrutkovs vrutkovs commented May 14, 2024 •
edited
Loading

This command is used by bootstrap to verify that bootstrap instance is ready to be shutdown.

Similar to installer bash script, this checks that kubernetes endpoint has at least 2 entries and api/api-int endpoints can do get using installer kubeconfig.

Tested via test e2e 4.16,https://github.com/openshift/cluster-kube-apiserver-operator/pull/1678,https://github.com/openshift/installer/pull/8404 vsphere

Do we want to switch to endpointslices to get information about endpoint readiness?

@openshift-ci openshift-ci bot requested review from deads2k and soltysh May 14, 2024 11:37
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2024
@vrutkovs vrutkovs mentioned this pull request May 14, 2024
Open
@vrutkovs vrutkovs changed the title Add "check-api-lb" subcommand WIP Add "check-api-lb" subcommand May 14, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 14, 2024
@vrutkovs vrutkovs force-pushed the check-api-lb branch 9 times, most recently from 8576a70 to 4b4bb2e Compare May 20, 2024 12:56
@vrutkovs vrutkovs changed the title WIP Add "check-api-lb" subcommand Add "check-api-lb" subcommand May 20, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 20, 2024
rphillips
rphillips reviewed May 21, 2024
View reviewed changes
pkg/cmd/checkapilb/cmd.go Outdated

attempt := 0
return wait.PollImmediateUntil(time.Second, func() (done bool, err error) {
retryCtx, retryCancel := context.WithTimeout(context.Background(), time.Second)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A 1 second context timeout seems too short.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, I can make it 5 secs just to be safe

@patrickdillon
Copy link

patrickdillon commented May 21, 2024 •
edited
Loading

we need to check the ControlPlaneTopology in cluster infrastructure to distinguish single node installs, in which case we don't want to block waiting for 2 endpoints

@tkashem has a bash version in openshift/installer#8429

@patrickdillon patrickdillon mentioned this pull request May 21, 2024
Merged
@vrutkovs
Add "check-api-lb" subcommand
164c0b7 
This command is used by bootstrap to verify that bootstrap instance is ready to be shutdown
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 23, 2024 •
edited
Loading

@vrutkovs: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-operator-single-node 164c0b7 link false /test e2e-gcp-operator-single-node
ci/prow/e2e-metal-single-node-live-iso 164c0b7 link false /test e2e-metal-single-node-live-iso
ci/prow/e2e-aws-operator-disruptive-single-node 164c0b7 link false /test e2e-aws-operator-disruptive-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@vrutkovs vrutkovs changed the title Add "check-api-lb" subcommand OCPBUGS-34525: Add "check-api-lb" subcommand May 28, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels May 28, 2024
@openshift-ci-robot
Copy link

@vrutkovs: This pull request references Jira Issue OCPBUGS-34525, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.0) matches configured target version for branch (4.17.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @wangke19

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This command is used by bootstrap to verify that bootstrap instance is ready to be shutdown.

Similar to installer bash script, this checks that kubernetes endpoint has at least 2 entries and api/api-int endpoints can do get using installer kubeconfig.

Tested via test e2e 4.16,https://github.com/openshift/cluster-kube-apiserver-operator/pull/1678,https://github.com/openshift/installer/pull/8404 vsphere

Do we want to switch to endpointslices to get information about endpoint readiness?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from wangke19 May 28, 2024 07:40
@vrutkovs
Copy link
Member Author

we need to check the ControlPlaneTopology in cluster infrastructure to distinguish single node installs, in which case we don't want to block waiting for 2 endpoints

Done

@eggfoobar
Copy link

/test e2e-aws-ovn-single-node

@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 30, 2024
@openshift-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 29, 2024
@vrutkovs
Copy link
Member Author

vrutkovs commented Oct 7, 2024

/remove-lifecycle rotten

@openshift-ci openshift-ci bot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Oct 7, 2024
@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 5, 2025
@openshift-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rphillips rphillips rphillips left review comments

@deads2k deads2k Awaiting requested review from deads2k

@soltysh soltysh Awaiting requested review from soltysh

@wangke19 wangke19 Awaiting requested review from wangke19

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vrutkovs @patrickdillon @openshift-ci-robot @eggfoobar @openshift-bot @rphillips