-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CNTRLPLANE-79: Disable oauth admission plugins #1810
base: master
Are you sure you want to change the base?
Conversation
…gins When disabling admission plugins, they should be removed by the --enable-admission-plugins list, if they exist.
@liouk: This pull request references CNTRLPLANE-79 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: liouk The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/jira refresh |
@liouk: This pull request references CNTRLPLANE-79 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
3624731
to
c33f45b
Compare
c33f45b
to
d706513
Compare
@liouk: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
When auth type is not OAuth (i.e.
OIDC
orNone
), we must disable the plugins relevant for RoleBindingRestrictions, as this API relies on the User & Group APIs, which are part of the OAuth apiserver.This PR adds a config observer specific to these plugins, and a special config merge rule that ensures that any plugin configured in the
--disable-admission-plugins
API server argument, will be removed from the--enable-admission-plugins
one if it exists there.