Skip to content

[release-6.5]feat(must-gather): refactor impl to golang to remove oc dependency - #3419

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:release-6.5from
jcantrill:log9789
Aug 26, 2026
Merged

[release-6.5]feat(must-gather): refactor impl to golang to remove oc dependency#3419
openshift-merge-bot[bot] merged 1 commit into
openshift:release-6.5from
jcantrill:log9789

Conversation

@jcantrill

@jcantrill jcantrill commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

ref: LOG-9789

Description

This PR:

  1. Refactors the must-gather scripts to golang to remove oc dependency
  2. Attempts to preserve directory structure
  3. Remove "cluster-logging" which duplicates other artifacts
  4. Remove obsolete ELK artifacts
  5. Group pod logs to core/pods for consistency with oc adm inspect
  6. Remove openshift types not in use

Links

cc @vparfonov @Clee2691

@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: bfa28949-d9f6-4c53-a32d-36b181846491

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from Clee2691 and cahartma August 20, 2026 18:53
@openshift-ci openshift-ci Bot added the midstream/Dockerfile A Dockerfile.in sync is needed with midstream label Aug 20, 2026
@openshift-ci

openshift-ci Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 20, 2026
@jcantrill

Copy link
Copy Markdown
Contributor Author

/label verified

verified by pushing to a cluster and then running:
oc adm must-gather --image image-registry.openshift-image-registry.svc:5000/openshift/origin-cluster-logging-operator:log9789

@openshift-ci openshift-ci Bot added the verified Signifies that the PR passed pre-merge verification criteria label Aug 25, 2026
@vparfonov

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 25, 2026
@vparfonov

Copy link
Copy Markdown
Contributor

/retitle [release-6.5]feat(must-gather): refactor impl to golang to remove oc dependency

@openshift-ci openshift-ci Bot changed the title feat(must-gather): refactor impl to golang to remove oc dependency [release-6.5]feat(must-gather): refactor impl to golang to remove oc dependency Aug 25, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD 4e85dbb and 2 for PR HEAD 6be1148 in total

@openshift-ci

openshift-ci Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

@jcantrill: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit d353355 into openshift:release-6.5 Aug 26, 2026
8 checks passed
@jcantrill
jcantrill deleted the log9789 branch August 26, 2026 19:10
@jcantrill

Copy link
Copy Markdown
Contributor Author

/cherrypick release-6.2

@openshift-cherrypick-robot

Copy link
Copy Markdown

@jcantrill: #3419 failed to apply on top of branch "release-6.2":

Applying: feat(must-gather): refactor impl to golang to remove oc dependency
Using index info to reconstruct a base tree...
M	Dockerfile
M	Dockerfile.art
M	Makefile
Falling back to patching base and 3-way merge...
Auto-merging Dockerfile
CONFLICT (content): Merge conflict in Dockerfile
Auto-merging Dockerfile.art
CONFLICT (content): Merge conflict in Dockerfile.art
Auto-merging Makefile
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 feat(must-gather): refactor impl to golang to remove oc dependency

Details

In response to this:

/cherrypick release-6.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jcantrill

Copy link
Copy Markdown
Contributor Author

/cherrypick release-6.4

@openshift-cherrypick-robot

Copy link
Copy Markdown

@jcantrill: #3419 failed to apply on top of branch "release-6.4":

Applying: feat(must-gather): refactor impl to golang to remove oc dependency
Using index info to reconstruct a base tree...
M	Dockerfile
M	Dockerfile.art
M	Makefile
Falling back to patching base and 3-way merge...
Auto-merging Dockerfile
CONFLICT (content): Merge conflict in Dockerfile
Auto-merging Dockerfile.art
CONFLICT (content): Merge conflict in Dockerfile.art
Auto-merging Makefile
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 feat(must-gather): refactor impl to golang to remove oc dependency

Details

In response to this:

/cherrypick release-6.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. midstream/Dockerfile A Dockerfile.in sync is needed with midstream release/6.5 verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants