Skip to content

fix(test): --slow-spec-threshold has been deprecated, replace it with --poll-progress-after flag - #3436

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:masterfrom
vparfonov:ginko-dep-fix
Aug 27, 2026
Merged

fix(test): --slow-spec-threshold has been deprecated, replace it with --poll-progress-after flag#3436
openshift-merge-bot[bot] merged 1 commit into
openshift:masterfrom
vparfonov:ginko-dep-fix

Conversation

@vparfonov

@vparfonov vparfonov commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Description

--ginkgo.slow-spec-threshold is deprecated and will be removed in a future version of Ginkgo. This PR replace it with --poll-progress-after

/cc @Clee2691
/assign @jcantrill

Links

  • Depending on PR(s):
  • GitHub issue:
  • JIRA: NO-JIRA
  • Enhancement proposal:

Summary by CodeRabbit

  • Tests
    • Updated test progress reporting to display polling progress after 45 seconds.
    • Preserved existing test duration and configuration settings.

…poll-progress-after

Signed-off-by: Vitalii Parfonov <vparfono@redhat.com>
@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 84c25977-aa1a-4285-9eab-4e68fb201e19

📥 Commits

Reviewing files that changed from the base of the PR and between e64e932 and 30a0152.

📒 Files selected for processing (1)
  • Makefile

Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review.


📝 Walkthrough

Walkthrough

The Makefile updates the test-functional and test-helpers targets to use Ginkgo progress polling after 45 seconds instead of the slow-spec threshold.

Changes

Ginkgo test options

Layer / File(s) Summary
Update Ginkgo test targets
Makefile
The test-functional and test-helpers targets now use -ginkgo.poll-progress-after='45s'.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 30a01

This is a localized test-flag update in the Makefile; no actionable merge-blocking risk remains, so it is merge-ready after normal checks and review.

Suggested reviewers: jcantrill, xperimental

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the deprecated Ginkgo flag and the replacement flag. It accurately summarizes the main change.
Description check ✅ Passed The description explains the deprecation and replacement, includes the required Description and Links sections, and assigns a reviewer and approver. The unused link fields are optional.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from Clee2691 and alanconway August 27, 2026 12:19
@openshift-ci

openshift-ci Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

@vparfonov: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jcantrill

Copy link
Copy Markdown
Contributor

/approve
/lgtm
/label verified

@openshift-ci openshift-ci Bot added the verified Signifies that the PR passed pre-merge verification criteria label Aug 27, 2026
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 27, 2026
@openshift-ci

openshift-ci Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill, vparfonov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 27, 2026
@openshift-merge-bot
openshift-merge-bot Bot merged commit 4035d00 into openshift:master Aug 27, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release/6.7 verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants