Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-30950: Set mount propagation to HostToContainer for /var/lib/kubelet #2368

Merged
merged 1 commit into from
Jul 4, 2024
Merged

OCPBUGS-30950: Set mount propagation to HostToContainer for /var/lib/kubelet #2368

merged 1 commit into from
Jul 4, 2024

Conversation

arghosh93
Copy link
Contributor

This PR is to change mountPropagation for /var/lib/kubelet mount from None to HostToContainer. This is to allow clean unmount of CSI Volumes.

Jira: https://issues.redhat.com/browse/OCPBUGS-30950

@arghosh93
Set mount propagation to HostToContainer for /var/lib/kubelet
731aa4e 
This PR is to change mountPropagation for /var/lib/kubelet
mount from None to HostToContainer. This is to allow clean
unmount of CSI Volumes.

Jira: https://issues.redhat.com/browse/OCPBUGS-30950

Signed-off-by: Arnab Ghosh <[email protected]>
@openshift-ci openshift-ci bot requested review from abhat and jcaamano May 8, 2024 13:21
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 8, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 8, 2024

Hi @arghosh93. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@arghosh93 arghosh93 changed the title Set mount propagation to HostToContainer for /var/lib/kubelet OCPBUGS-30950: Set mount propagation to HostToContainer for /var/lib/kubelet May 8, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels May 8, 2024
@openshift-ci-robot
Copy link
Contributor

@arghosh93: This pull request references Jira Issue OCPBUGS-30950, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This PR is to change mountPropagation for /var/lib/kubelet mount from None to HostToContainer. This is to allow clean unmount of CSI Volumes.

Jira: https://issues.redhat.com/browse/OCPBUGS-30950

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kyrtapz
Copy link
Contributor

kyrtapz commented May 8, 2024

/label ok-to-test

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 8, 2024

@kyrtapz: The label(s) /label ok-to-test cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kyrtapz
Copy link
Contributor

kyrtapz commented May 8, 2024

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 8, 2024
@arghosh93
Copy link
Contributor Author

/retest-required

@arghosh93
Copy link
Contributor Author

/retest

@arghosh93
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@arghosh93: This pull request references Jira Issue OCPBUGS-30950, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.0) matches configured target version for branch (4.17.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@arghosh93
Copy link
Contributor Author

/retest

@martinkennelly
Copy link
Contributor

@arghosh93 is this ready to go? should we look for reviewers at the SDN team meeting?

@martinkennelly
Copy link
Contributor

/test e2e-vsphere-ovn-dualstack
Unrelated

@martinkennelly
Copy link
Contributor

/test e2e-vsphere-ovn-dualstack-primaryv6

@martinkennelly
Copy link
Contributor

/test e2e-vsphere-ovn

cluster init

@arghosh93
Copy link
Contributor Author

Yes @martinkennelly , its ready to be merged.
cc: @jcaamano

@martinkennelly
Copy link
Contributor

@arghosh93 add to our team agenda to hopefully get into Jaimes backlog. We may need someone else if his plate is full.

@arghosh93
Copy link
Contributor Author

/cherry-pick release-4.16

@openshift-cherrypick-robot
Copy link

@arghosh93: only openshift org members may request cherry picks. If you are already part of the org, make sure to change your membership to public. Otherwise you can still do the cherry-pick manually.

In response to this:

/cherry-pick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@martinkennelly
Copy link
Contributor

Decided at team meeting to wait until critical fixes only label requirement is removed.

@tssurya
Copy link
Contributor

tssurya commented Jun 26, 2024 •
edited
Loading

@martinkennelly / @arghosh93 : let's move ahead with this, ?
BTW no need to backport since our process normally is to not backport by default
cases are piling up on the bug, so maybe backport is needed,, dunno

@arghosh93
Copy link
Contributor Author

/test okd-scos-images

@martinkennelly
Copy link
Contributor

Jaime will review.

@jcaamano
Copy link
Contributor

jcaamano commented Jul 4, 2024

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 4, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arghosh93, jcaamano, martinkennelly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 4, 2024
@jcaamano
Copy link
Contributor

jcaamano commented Jul 4, 2024

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 4, 2024
@jcaamano
Copy link
Contributor

jcaamano commented Jul 4, 2024

/retest

@jcaamano
Copy link
Contributor

jcaamano commented Jul 4, 2024

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 4, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 4, 2024

@arghosh93: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6 731aa4e link false /test e2e-vsphere-ovn-dualstack-primaryv6
ci/prow/security 731aa4e link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit cef4af3 into openshift:master Jul 4, 2024
41 of 43 checks passed
@openshift-ci-robot
Copy link
Contributor

@arghosh93: Jira Issue OCPBUGS-30950: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-30950 has been moved to the MODIFIED state.

In response to this:

This PR is to change mountPropagation for /var/lib/kubelet mount from None to HostToContainer. This is to allow clean unmount of CSI Volumes.

Jira: https://issues.redhat.com/browse/OCPBUGS-30950

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot
Copy link

@arghosh93: new pull request created: #2430

In response to this:

/cherry-pick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 4, 2024
Merged
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-network-operator-container-v4.17.0-202407041843.p0.gcef4af3.assembly.stream.el9 for distgit cluster-network-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinkennelly martinkennelly martinkennelly approved these changes

@abhat abhat Awaiting requested review from abhat

@jcaamano jcaamano Awaiting requested review from jcaamano

Assignees

@jcaamano jcaamano

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@arghosh93 @openshift-ci-robot @kyrtapz @martinkennelly @openshift-cherrypick-robot @tssurya @jcaamano @openshift-bot