SDN-4832: Fixing ovn-k config parameters. Part 1

[npinaeva]

Trying to do little steps to make sure I don't break something.
We already have 2 config files for ovnkube-node: script-lib and config. script-lib is hashed in the ds and will cause a rollout on any pararmeter change, while config doesn't have the same effect. So the idea for the first step is to continue using this approach: put params that should not cause a restart to the config, and that should to the script-lib. But do that in a similar manner for ovnkube-node and control-plane. Also try to use every ENV variable either in config or in script-lib, but in not both.
FUPs:

• enable-multi-networkpolicy is only used by the node now, figure out is we want to restart controlplane too
• OVN_GATEWAY_MODE will cause node rollout, but not control-plane, double-check if that is correct
• we still need to figure out our strategy for passing params to the control-plane and node separately

[openshift-ci-robot]

@npinaeva: This pull request references SDN-4832 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

Trying to do little steps to make sure I don't break something.
We already have 2 config files for ovnkube-node: script-lib and config. script-lib is hashed in the ds and will cause a rollout on any pararmeter change, while config doesn't have the same effect. So the idea for the first step is to continue using this approach: put params that should not cause a restart to the config, and that should to the script-lib. But do that in a similar manner for ovnkube-node and control-plane. Also try to use every ENV variable either in config or in script-lib, but in not both.
FUPs:

• enable-multi-networkpolicy is only used by the node now, figure out is we want to restart controlplane too
• OVN_GATEWAY_MODE will cause node rollout, but not control-plane, double-check if that is correct
• we still need to figure out our strategy for passing params to the control-plane and node separately

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: npinaeva
Once this PR has been reviewed and has the lgtm label, please assign jcaamano for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-merge-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

@npinaeva: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-hypershift-conformance	2564b17	link	true	/test e2e-aws-ovn-hypershift-conformance
ci/prow/e2e-vsphere-ovn-dualstack	2564b17	link	false	/test e2e-vsphere-ovn-dualstack
ci/prow/4.16-upgrade-from-stable-4.15-e2e-gcp-ovn-upgrade	2564b17	link	false	/test 4.16-upgrade-from-stable-4.15-e2e-gcp-ovn-upgrade
ci/prow/unit	2564b17	link	true	/test unit
ci/prow/e2e-aws-hypershift-ovn-kubevirt	2564b17	link	false	/test e2e-aws-hypershift-ovn-kubevirt
ci/prow/e2e-aws-ovn-upgrade	2564b17	link	true	/test e2e-aws-ovn-upgrade
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6	2564b17	link	false	/test e2e-vsphere-ovn-dualstack-primaryv6
ci/prow/security	2564b17	link	false	/test security
ci/prow/4.17-upgrade-from-stable-4.16-images	2564b17	link	true	/test 4.17-upgrade-from-stable-4.16-images
ci/prow/4.18-upgrade-from-stable-4.17-images	2564b17	link	true	/test 4.18-upgrade-from-stable-4.17-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.