Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipsec mcp pools test WIP #2447

Open
wants to merge 2 commits into
base: release-4.15
Choose a base branch
from
Open

ipsec mcp pools test WIP #2447

wants to merge 2 commits into from

Conversation

yuvalk
Copy link
Contributor

@yuvalk yuvalk commented Jul 22, 2024 •
edited
Loading

this is mainly so we can build releases that includes both PR#2439 and PR#2446

  • Check every MachineConfigPool for IPsec plugin existence
  • Update network operator status for IPsec

@pperiyasamy @yuvalk
Check every MachineConfigPool for IPsec plugin existence
4202476 
While testing IPsec upgrade on 24 node cluster in CI, it's noticed
there are more than two (master, worker) machine config pools present.
For example infra and workload pools were present which belong worker
role. Hence this commit queries all machine config pools based on master
and worker roles and check ipsec plugin existence on every pool.

Signed-off-by: Periyasamy Palanisamy <[email protected]>
@pperiyasamy @yuvalk
Update network operator status for IPsec
eab15f9 
This commit updates network operator progressing condition for
rolling out IPsec daemonset for cluster. It reflects appropriate
status for network cluster operator which would make
openshift-install to exit gracefully after installing all of IPsec
components for the cluster.

Signed-off-by: Periyasamy Palanisamy <[email protected]>
@openshift-ci openshift-ci bot requested review from dougbtv and jcaamano July 22, 2024 15:50
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 22, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yuvalk
Once this PR has been reviewed and has the lgtm label, please assign dougbtv for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 22, 2024

@yuvalk: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.15-upgrade-from-stable-4.14-e2e-azure-ovn-upgrade eab15f9 link false /test 4.15-upgrade-from-stable-4.14-e2e-azure-ovn-upgrade
ci/prow/e2e-network-mtu-migration-ovn-ipv6 eab15f9 link false /test e2e-network-mtu-migration-ovn-ipv6
ci/prow/e2e-vsphere-ovn eab15f9 link false /test e2e-vsphere-ovn
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6 eab15f9 link false /test e2e-vsphere-ovn-dualstack-primaryv6
ci/prow/e2e-azure-ovn eab15f9 link false /test e2e-azure-ovn
ci/prow/4.15-upgrade-from-stable-4.14-e2e-gcp-ovn-upgrade eab15f9 link false /test 4.15-upgrade-from-stable-4.14-e2e-gcp-ovn-upgrade
ci/prow/security eab15f9 link false /test security
ci/prow/e2e-gcp-ovn eab15f9 link true /test e2e-gcp-ovn
ci/prow/e2e-metal-ipi-ovn-ipv6 eab15f9 link true /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-gcp-ovn-upgrade eab15f9 link true /test e2e-gcp-ovn-upgrade
ci/prow/4.15-upgrade-from-stable-4.14-e2e-aws-ovn-upgrade eab15f9 link false /test 4.15-upgrade-from-stable-4.14-e2e-aws-ovn-upgrade
ci/prow/e2e-metal-ipi-ovn-ipv6-ipsec eab15f9 link false /test e2e-metal-ipi-ovn-ipv6-ipsec
ci/prow/e2e-aws-hypershift-ovn-kubevirt eab15f9 link false /test e2e-aws-hypershift-ovn-kubevirt
ci/prow/e2e-network-mtu-migration-ovn-ipv4 eab15f9 link false /test e2e-network-mtu-migration-ovn-ipv4
ci/prow/e2e-aws-ovn-network-migration eab15f9 link true /test e2e-aws-ovn-network-migration
ci/prow/e2e-vsphere-ovn-dualstack eab15f9 link false /test e2e-vsphere-ovn-dualstack

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 27, 2024
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougbtv dougbtv Awaiting requested review from dougbtv

@jcaamano jcaamano Awaiting requested review from jcaamano

Assignees
No one assigned
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuvalk @openshift-merge-robot @pperiyasamy