Move to use newer IPsec DaemonSets when MCP is in paused state #2449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pperiyasamy
force-pushed
the
debug-mcp-pause-ipsec-blocking-upgrade
branch
from
7c6b3ce
to
29843fa
Compare
pperiyasamy
changed the title
|
/assign @yuvalk @jcaamano @anuragthehatter |
openshift-ci
bot
added
the
do-not-merge/hold
This commit makes network operator to use MachineConfigPool, it currently checks only status, but going forward it may check pause value which is a mcp Spec parameter. Signed-off-by: Periyasamy Palanisamy <[email protected]> (cherry picked from commit ae8938daca4ba38b69d516482a887f5c03191382)
When MCP is in paused state, network operator continues to render older IPsec daemonsets which blocks network cluster operator not getting upgraded to newer version. Hence this commit renders newer IPsec daemonsets for intermediate period. When MCPs are moved to unpaused state and IPsec machine configs are installed on it, then it goes ahead with rendering only host flavored IPsec daemonset. Signed-off-by: Periyasamy Palanisamy <[email protected]> (cherry picked from commit 64be52482981c75ed387b0e497dddb047778f13e)
pperiyasamy
force-pushed
the
debug-mcp-pause-ipsec-blocking-upgrade
branch
from
29843fa
to
9d88c89
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: pperiyasamy The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test ? |
|
@pperiyasamy: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test e2e-ovn-ipsec-step-registry |
|
@pperiyasamy: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
QE test looks good to me on this PR /label qe-approved |
openshift-ci
bot
added
the
qe-approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When MCP is in paused state, network operator continues to render older IPsec daemonsets which blocks network cluster operator not getting upgraded to 4.15. Hence this commit renders both newer 4.15 IPsec daemonsets for intermediate period. When MCPs are moved to unpaused state and IPsec machine configs are installed on it, then it goes ahead with rendering only host flavored IPsec daemonset.