drop networkType migration support #2456
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danwinship
force-pushed
the
drop-migration
branch
from
86dc7b6
to
213938f
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danwinship The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-robot
added
the
needs-rebase
danwinship
force-pushed
the
drop-migration
branch
from
213938f
to
0a68170
Compare
openshift-merge-robot
removed
the
needs-rebase
danwinship
force-pushed
the
drop-migration
branch
from
0a68170
to
316067e
Compare
danwinship
force-pushed
the
drop-migration
branch
from
316067e
to
137d3bf
Compare
|
@danwinship: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More followup from openshift-sdn removal (#2384).
This gets rid of all of the code (and templating) related to migration (both live and offline).
In theory, we could try to leave the migration "framework" behind, while only getting rid of the openshift-sdn-specific bits, but this didn't really seem like it would work; the generic and the specific are all mixed together. (And at any rate, we don't expect to ever support networkType migration ever again anyway.)
There was discussion before about whether we should leave this code behind since we'll still need to fix bugs in it in older releases, but since there's no way to actually test this code any more in 4.17 and later, it really makes more sense to drop it. (Fixes for migration bugs will now have to start in
release-4.16rather thanmaster.)This could merge in 4.17, but it doesn't really need to, and even though it's 99% just deletion, it needs to be reviewed somewhat carefully to make sure I didn't accidentally remove something we need to keep. (In particular, we still need to support MTU migration, though CI should catch that if I screwed it up.)
(This is split into multiple smaller commits to make it a little easier to review, but it's really all one piece. In particular, the first commit, "Reject networkType migration" is not something we need to merge for 4.17; 4.17 will already reject a "migrate to openshift-sdn" configuration because we don't support openshift-sdn. The commit here just changes it so it would instead reject it because we don't support migration.)