[Release 4.14] OCPBUGS-44098: backport SDN live migration #2469
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: pliurh The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
pliurh
force-pushed
the
release-4.14
branch
from
d671778
to
1bd449f
Compare
pliurh
force-pushed
the
release-4.14
branch
2 times, most recently
from
be54ef7
to
fd6b67e
Compare
pliurh
changed the title
|
@pliurh: This pull request references NP-1094 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.14.z" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
openshift-ci-robot
added
the
jira/valid-reference
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
Operconfig shouldn't own .Spec.Migration as it is not modifying it anywhere. Setting the value to nil will ensure that the value of that field will stay unchanged (including the fieldManager). Co-authored-by: Peng Liu <[email protected]> Signed-off-by: Patryk Diak <[email protected]>
pliurh
force-pushed
the
release-4.14
branch
2 times, most recently
from
3a7f3d7
to
923242b
Compare
Signed-off-by: Peng Liu <[email protected]> Update network CRDs
Signed-off-by: Peng Liu <[email protected]>
In CNO, the network.operator CR can be updated by both operconfig and clusterconfig controllers. There is a chance that these two controllers may encounter a racing condition, resulting in conflict error. Normally, this type of error can be automatically recovered by retrying the operation. Therefore, we don't set CNO to degrade when encountering this error. Signed-off-by: Peng Liu <[email protected]>
Signed-off-by: Peng Liu <[email protected]>
Signed-off-by: Peng Liu <[email protected]>
For the set of managed clusters excluding hypershift, the namespace "dedicated-admin" shall exist. Use this info to only enable live migration within that set. Signed-off-by: Peng Liu <[email protected]> Signed-off-by: Martin Kennelly <[email protected]>
In 4.16, we want to support SDN live migration for unmanaged clusters. Signed-off-by: Peng Liu <[email protected]>
Adds the following validations: - Do not allow migrating from OpenShiftSDN in multitenant mode. - Check whether any of the clusterNetwork/serviceNetwork subnets conflict the internal OVNKubernetes subnets(internal, transitstwitch and masquerade). - Do not allow migrating from OpenShiftSDN if there are any pods with pod.network.openshift.io/assign-macvlan annotation present in the cluster. Signed-off-by: Patryk Diak <[email protected]>
…gration During live migration, we run ovn-k and sdn in parallel. When new nodes are added to the cluster, ovn-k and sdn may assign differnt subnets to the nodes. This patch let ovn-k subject to sdn for the node subnet allocation when both CNIs are deployed. Signed-off-by: Peng Liu <[email protected]>
The NetworkTypeMigrationInProgress is set in operconfig controller and not in the clusterconfig controller. Ensure that the live migration is valid before initializing the condition. Signed-off-by: Patryk Diak <[email protected]>
Add metric to publish the reason why live migration may not begin. Add metric to publish the current live migration status condition type. Signed-off-by: Martin Kennelly <[email protected]>
The configmap mtu is required by SDN live migration. It should be created by the mtu-prober job at the installation time since 4.11. But if the cluster was upgrade from a very early releases, it may be absent. Signed-off-by: Peng Liu <[email protected]>
Signed-off-by: Martin Kennelly <[email protected]>
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
pliurh
changed the title
|
@pliurh: This pull request references Jira Issue OCPBUGS-44098, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/invalid-bug
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@pliurh: This pull request references Jira Issue OCPBUGS-44098, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@pliurh: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
No description provided.