Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-39300: rebase openshift/api for openshift-sdn removal [4.17] #2477

Open
wants to merge 2 commits into
base: release-4.17
Choose a base branch
from
Open

OCPBUGS-39300: rebase openshift/api for openshift-sdn removal [4.17] #2477

wants to merge 2 commits into from

Conversation

danwinship
Copy link
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 21, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 21, 2024 •
edited by openshift-ci bot
Loading

@danwinship: This pull request references SDN-4900 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.18." or "openshift-4.18.", but it targets "openshift-4.17" instead.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 21, 2024
@danwinship danwinship changed the base branch from master to release-4.17 August 21, 2024 13:30
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 21, 2024 •
edited by openshift-ci bot
Loading

@danwinship: This pull request references SDN-4900 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 21, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 21, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 21, 2024
@zhaozhanqi
Copy link

@danwinship Could you resolve the conflicts?

@danwinship danwinship changed the title SDN-4900: rebase openshift/api for openshift-sdn removal [4.17] OCPBUGS-39300: rebase openshift/api for openshift-sdn removal [4.17] Aug 30, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Aug 30, 2024
@openshift-ci-robot
Copy link
Contributor

@danwinship: This pull request references Jira Issue OCPBUGS-39300, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.0) matches configured target version for branch (4.17.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-39301 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-39301 targets the "4.18.0" version, which is one of the valid target versions: 4.18.0
  • bug has dependents

Requesting review from QA contact:
/cc @zhaozhanqi

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from zhaozhanqi August 30, 2024 15:28
@openshift-ci-robot openshift-ci-robot mentioned this pull request Aug 30, 2024
Merged
@danwinship danwinship marked this pull request as ready for review August 30, 2024 19:29
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 30, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 30, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 3, 2024

@danwinship: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security f86242d link false /test security
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6 f86242d link false /test e2e-vsphere-ovn-dualstack-primaryv6
ci/prow/e2e-openstack-ovn f86242d link false /test e2e-openstack-ovn
ci/prow/4.17-upgrade-from-stable-4.16-e2e-azure-ovn-upgrade f86242d link false /test 4.17-upgrade-from-stable-4.16-e2e-azure-ovn-upgrade
ci/prow/e2e-azure-ovn f86242d link false /test e2e-azure-ovn
ci/prow/e2e-aws-hypershift-ovn-kubevirt f86242d link false /test e2e-aws-hypershift-ovn-kubevirt
ci/prow/e2e-vsphere-ovn-dualstack f86242d link false /test e2e-vsphere-ovn-dualstack

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@zhaozhanqi
Copy link

pre-merge tested and lgtm

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Sep 4, 2024
@kyrtapz
Copy link
Contributor

kyrtapz commented Sep 5, 2024

/lgtm
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Sep 5, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 5, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, kyrtapz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhaozhanqi zhaozhanqi Awaiting requested review from zhaozhanqi

@abhat abhat Awaiting requested review from abhat

@JacobTanenbaum JacobTanenbaum Awaiting requested review from JacobTanenbaum

Assignees

@mffiedler mffiedler

@rbbratta rbbratta

@eurijon eurijon

@weliang1 weliang1

@anuragthehatter anuragthehatter

@huiran0826 huiran0826

@rlobillo rlobillo

@asood-rh asood-rh

@jechen0648 jechen0648

@qiowang721 qiowang721

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.