Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.18] OCPBUGS-47651: Re-disable metrics server #2622

Open
wants to merge 1 commit into
base: release-4.18
Choose a base branch
from

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #2516

/assign kyrtapz

The metrics server was incorectly enabled in acd67b4
Revert this behavior by specifying the metrics port in the options.

Signed-off-by: Patryk Diak <[email protected]>
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Detected clone of Jira Issue OCPBUGS-42189 with correct target version. Will retitle the PR to link to the clone.
/retitle [release-4.18] OCPBUGS-47651: Re-disable metrics server

In response to this:

This is an automated cherry-pick of #2516

/assign kyrtapz

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.18] OCPBUGS-42189: Re-disable metrics server [release-4.18] OCPBUGS-47651: Re-disable metrics server Jan 21, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 21, 2025
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-47651, which is invalid:

  • expected Jira Issue OCPBUGS-47651 to depend on a bug targeting a version in 4.19.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #2516

/assign kyrtapz

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from dougbtv and tssurya January 21, 2025 11:24
@kyrtapz
Copy link
Contributor

kyrtapz commented Jan 21, 2025

@pperiyasamy ptal

@kyrtapz
Copy link
Contributor

kyrtapz commented Jan 21, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 21, 2025
@openshift-ci-robot
Copy link
Contributor

@kyrtapz: This pull request references Jira Issue OCPBUGS-47651, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-42189 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-42189 targets the "4.19.0" version, which is one of the valid target versions: 4.19.0
  • bug has dependents

Requesting review from QA contact:
/cc @qiowang721

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from qiowang721 January 21, 2025 11:26
@pperiyasamy
Copy link
Member

/lgtm

Thanks @kyrtapz !

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2025
Copy link
Contributor

openshift-ci bot commented Jan 21, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, pperiyasamy
Once this PR has been reviewed and has the lgtm label, please ask for approval from kyrtapz. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Jan 21, 2025

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6 03037e8 link false /test e2e-vsphere-ovn-dualstack-primaryv6
ci/prow/e2e-gcp-ovn-techpreview 03037e8 link true /test e2e-gcp-ovn-techpreview
ci/prow/e2e-metal-ipi-ovn-ipv6-ipsec 03037e8 link false /test e2e-metal-ipi-ovn-ipv6-ipsec
ci/prow/security 03037e8 link false /test security
ci/prow/e2e-aws-ovn-shared-to-local-gateway-mode-migration 03037e8 link false /test e2e-aws-ovn-shared-to-local-gateway-mode-migration
ci/prow/e2e-aws-hypershift-ovn-kubevirt 03037e8 link false /test e2e-aws-hypershift-ovn-kubevirt

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@qiowang721
Copy link

/label qe-approved
pre-merge testing passed.
version:

build openshift/cluster-network-operator#2622

steps:

1. create 4.18 compact OCP cluster
% oc get node
NAME                                        STATUS   ROLES                         AGE   VERSION
ip-10-0-17-167.us-east-2.compute.internal   Ready    control-plane,master,worker   80m   v1.31.4
ip-10-0-44-12.us-east-2.compute.internal    Ready    control-plane,master,worker   80m   v1.31.4
ip-10-0-64-33.us-east-2.compute.internal    Ready    control-plane,master,worker   80m   v1.31.4

2. create hostnetwork pod, listening on port 8080
% oc get pod -n ns1 -owide
NAME        READY   STATUS    RESTARTS   AGE   IP            NODE                                        NOMINATED NODE   READINESS GATES
hello-pod   1/1     Running   0          5s    10.0.17.167   ip-10-0-17-167.us-east-2.compute.internal              

3. check on the node which hostnetowrk pod lands on, the pod is listening on port 8080
% oc debug node/ip-10-0-17-167.us-east-2.compute.internal 
Starting pod/ip-10-0-17-167us-east-2computeinternal-debug-swjbq ...
To use host binaries, run `chroot /host`
Pod IP: 10.0.17.167
If you don't see a command prompt, try pressing enter.
sh-5.1# netstat -tulpen | grep 8080
tcp6       0      0 :::8080                 :::*                    LISTEN      1000740000 881647     54436/hello_openshi

4. check the network-operator pod is not in CrashLoopBackOff state, and there is no error message about metrics server
% oc get pod -n openshift-network-operator
NAME                                READY   STATUS    RESTARTS      AGE
iptables-alerter-4c6wc              1/1     Running   0             81m
iptables-alerter-9jxh4              1/1     Running   0             81m
iptables-alerter-qp8ps              1/1     Running   0             81m
network-operator-7bc857cd77-k8d8d   1/1     Running   2 (72m ago)   83m  <--- no CrashLoopBackOff
% oc describe pod/network-operator-7bc857cd77-k8d8d -n openshift-network-operator | grep "metrics server"
% oc describe pod/network-operator-7bc857cd77-k8d8d -n openshift-network-operator | grep "address already in use"
%

5. check cluster-network-operator is not DEGRADED
% oc get co | grep network
network                                    4.18.0-0.ci.test-2025-01-21-122114-ci-ln-qlnfv4b-latest   True        False         False      83m 

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jan 22, 2025
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-47651, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-42189 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-42189 targets the "4.19.0" version, which is one of the valid target versions: 4.19.0
  • bug has dependents

Requesting review from QA contact:
/cc @qiowang721

In response to this:

This is an automated cherry-pick of #2516

/assign kyrtapz

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants