Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNM] Test with SHA512WithRSAPSS sig algorithm for node's crypto future policy #2630

Open
wants to merge 2 commits into
base: release-4.16
Choose a base branch
from
Open

[DNM] Test with SHA512WithRSAPSS sig algorithm for node's crypto future policy #2630

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1289bc8
update key size and cert signing algorithm to work with crypto future…
pperiyasamy Jan 28, 2025
af1e5a9
Bump library-go to use updated ca key size and sig alorithm
pperiyasamy Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bindata/network/ovn-kubernetes/common/ipsec-host.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ spec:
mkdir -p /etc/openvswitch/keys

# Generate an SSL private key and use the key to create a certitificate signing request
umask 077 && openssl genrsa -out /etc/openvswitch/keys/ipsec-privkey.pem 2048
umask 077 && openssl genrsa -out /etc/openvswitch/keys/ipsec-privkey.pem 3072
openssl req -new -text \
-extensions v3_req \
-addext "subjectAltName = DNS:${cn}" \
Expand Down
2 changes: 2 additions & 0 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,3 +155,5 @@ require (
k8s.io/kms v0.29.0 // indirect
k8s.io/kube-aggregator v0.28.2 // indirect
)

replace github.com/openshift/library-go => github.com/pperiyasamy/library-go v0.0.0-20250129104748-50cad7f570e8
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,8 +285,6 @@ github.com/openshift/build-machinery-go v0.0.0-20220913142420-e25cf57ea46d h1:RR
github.com/openshift/build-machinery-go v0.0.0-20220913142420-e25cf57ea46d/go.mod h1:b1BuldmJlbA/xYtdZvKi+7j5YGB44qJUJDZ9zwiNCfE=
github.com/openshift/client-go v0.0.0-20240415214935-be70f772f157 h1:xbd4qHpyFnnOYDHHnMQa+100MR+K/DFiC1J3BFdL+tQ=
github.com/openshift/client-go v0.0.0-20240415214935-be70f772f157/go.mod h1:Q3mt/X5xrxnR5R6BE7duF2ToLioRQJYnTYaaDS4QZTs=
github.com/openshift/library-go v0.0.0-20231128230659-785a9313da6c h1:L/nRp+uq0MKKvK14y18Ua84dYF860b1dCE973wSQ1do=
github.com/openshift/library-go v0.0.0-20231128230659-785a9313da6c/go.mod h1:8UzmrBMCn7+GzouL8DVYkL9COBQTB1Ggd13/mHJQCUg=
github.com/openshift/machine-config-operator v0.0.1-0.20231002195040-a2469941c0dc h1:m8c26gPEv0p621926Kl26kYQvnkOrW7pOirvYzORn24=
github.com/openshift/machine-config-operator v0.0.1-0.20231002195040-a2469941c0dc/go.mod h1:ftCpVtU6Q31exB0DTBn9s2eu90RJESOSisNAruWkvcE=
github.com/pin/tftp v2.1.0+incompatible/go.mod h1:xVpZOMCXTy+A5QMjEVN0Glwa1sUvaJhFXbr/aAxuxGY=
Expand All @@ -297,6 +295,8 @@ github.com/pkg/profile v1.3.0 h1:OQIvuDgm00gWVWGTf4m4mCt6W1/0YqU7Ntg0mySWgaI=
github.com/pkg/profile v1.3.0/go.mod h1:hJw3o1OdXxsrSjjVksARp5W95eeEaEfptyVZyv6JUPA=
github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZbAQM=
github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=
github.com/pperiyasamy/library-go v0.0.0-20250129104748-50cad7f570e8 h1:0mJmT2lMtfPMg4CBsMBz3Wtc0+I0zoDb5Xlrw1wkeas=
github.com/pperiyasamy/library-go v0.0.0-20250129104748-50cad7f570e8/go.mod h1:8UzmrBMCn7+GzouL8DVYkL9COBQTB1Ggd13/mHJQCUg=
github.com/prometheus/client_golang v1.16.0 h1:yk/hx9hDbrGHovbci4BY+pRMfSuuat626eFsHb7tmT8=
github.com/prometheus/client_golang v1.16.0/go.mod h1:Zsulrv/L9oM40tJ7T815tM89lFEugiJ9HzIqaAx4LKc=
github.com/prometheus/client_model v0.0.0-20190812154241-14fe0d1b01d4/go.mod h1:xMI15A0UPsDsEKsMN9yxemIoYk6Tm2C1GtYGdfGttqA=
Expand Down
2 changes: 1 addition & 1 deletion pkg/controller/signer/signer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ func newCertificateTemplate(certReq *x509.CertificateRequest) *x509.Certificate
template := &x509.Certificate{
Subject: certReq.Subject,

SignatureAlgorithm: x509.SHA512WithRSA,
SignatureAlgorithm: x509.SHA512WithRSAPSS,

NotBefore: time.Now().Add(-1 * time.Second),
NotAfter: time.Now().Add(5 * oneYear),
Expand Down
10 changes: 5 additions & 5 deletions vendor/github.com/openshift/library-go/pkg/crypto/crypto.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion vendor/modules.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,7 +425,7 @@ github.com/openshift/client-go/operatorcontrolplane/informers/externalversions/i
github.com/openshift/client-go/operatorcontrolplane/informers/externalversions/operatorcontrolplane
github.com/openshift/client-go/operatorcontrolplane/informers/externalversions/operatorcontrolplane/v1alpha1
github.com/openshift/client-go/operatorcontrolplane/listers/operatorcontrolplane/v1alpha1
# github.com/openshift/library-go v0.0.0-20231128230659-785a9313da6c
# github.com/openshift/library-go v0.0.0-20231128230659-785a9313da6c => github.com/pperiyasamy/library-go v0.0.0-20250129104748-50cad7f570e8
## explicit; go 1.20
github.com/openshift/library-go/pkg/authorization/hardcodedauthorizer
github.com/openshift/library-go/pkg/certs
Expand Down Expand Up @@ -1666,3 +1666,4 @@ sigs.k8s.io/structured-merge-diff/v4/value
# sigs.k8s.io/yaml v1.3.0
## explicit; go 1.12
sigs.k8s.io/yaml
# github.com/openshift/library-go => github.com/pperiyasamy/library-go v0.0.0-20250129104748-50cad7f570e8