Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-49662: Prevent resetting masquerade subnet #2641

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

OCPBUGS-49662: Prevent resetting masquerade subnet #2641

wants to merge 2 commits into from

Conversation

arghosh93
Copy link
Contributor

Prevent resetting masquerade subnet to default value(169.254.169.0/29)
set at upstream ovn-kubernetes when ovnkube-node daemonset is removed
from the cluster.
This PR have an additional commit to update masquerade subnet to
ovnkube-control-plane deployment. This is required as masquerade
subnet is currently configurable at day 2.

@arghosh93
Update masquerade subnet to ovnkube-control-plane deployment
326ead3 
ovnkube running in ovnkube-control-plane need to know about
masquerade subnet as it is currently configurable at day 2.

If ovnkube is not aware of custom masquerade subnet, then
subnet overlap check at ovnkube side during startup would
consider default masquerade subnet and overlap check would
be inaccurate.

Signed-off-by: Arnab Ghosh <[email protected]>
@arghosh93
Prevent resetting masquerade subnet
df98ce8 
Prevent resetting masquerade subnet to default value(169.254.169.0/29)
set at upstream ovn-kubernetes when ovnkube-node daemonset is removed
from the cluster.
If masquerade subnet is configured through network.operator custom
resource then it takes precedence over default masquerade subnet.

Signed-off-by: Arnab Ghosh <[email protected]>
@arghosh93 arghosh93 changed the title [OCPBUGS-49662] Prevent resetting masquerade subnet OCPBUGS-49662: Prevent resetting masquerade subnet Feb 5, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 5, 2025
@openshift-ci-robot
Copy link
Contributor

@arghosh93: This pull request references Jira Issue OCPBUGS-49662, which is invalid:

  • expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Prevent resetting masquerade subnet to default value(169.254.169.0/29)
set at upstream ovn-kubernetes when ovnkube-node daemonset is removed
from the cluster.
This PR have an additional commit to update masquerade subnet to
ovnkube-control-plane deployment. This is required as masquerade
subnet is currently configurable at day 2.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from trozet and tssurya February 5, 2025 13:19
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 5, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: arghosh93
Once this PR has been reviewed and has the lgtm label, please assign abhat for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@arghosh93
Copy link
Contributor Author

/jira-refresh

@arghosh93
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Feb 5, 2025
@openshift-ci-robot
Copy link
Contributor

@arghosh93: This pull request references Jira Issue OCPBUGS-49662, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @asood-rh

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Feb 5, 2025
@openshift-ci openshift-ci bot requested a review from asood-rh February 5, 2025 13:21
@arghosh93
Copy link
Contributor Author

/retest-required

@arghosh93
Copy link
Contributor Author

/retest

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 7, 2025

@arghosh93: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.18-upgrade-from-stable-4.17-e2e-azure-ovn-upgrade df98ce8 link false /test 4.18-upgrade-from-stable-4.17-e2e-azure-ovn-upgrade
ci/prow/4.18-upgrade-from-stable-4.17-e2e-aws-ovn-upgrade df98ce8 link false /test 4.18-upgrade-from-stable-4.17-e2e-aws-ovn-upgrade
ci/prow/security df98ce8 link false /test security
ci/prow/4.19-upgrade-from-stable-4.18-e2e-azure-ovn-upgrade df98ce8 link false /test 4.19-upgrade-from-stable-4.18-e2e-azure-ovn-upgrade
ci/prow/e2e-network-mtu-migration-ovn-ipv6 df98ce8 link false /test e2e-network-mtu-migration-ovn-ipv6
ci/prow/okd-scos-e2e-aws-ovn df98ce8 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-openstack-ovn df98ce8 link false /test e2e-openstack-ovn
ci/prow/e2e-aws-hypershift-ovn-kubevirt df98ce8 link false /test e2e-aws-hypershift-ovn-kubevirt
ci/prow/e2e-ovn-step-registry df98ce8 link false /test e2e-ovn-step-registry
ci/prow/e2e-gcp-ovn df98ce8 link true /test e2e-gcp-ovn
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6 df98ce8 link false /test e2e-vsphere-ovn-dualstack-primaryv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trozet trozet Awaiting requested review from trozet

@tssurya tssurya Awaiting requested review from tssurya

@asood-rh asood-rh Awaiting requested review from asood-rh

Assignees
No one assigned
Labels
jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arghosh93 @openshift-ci-robot