[DNM]: Enable fast ranges #2648
Conversation
|
/hold Depends on dockerfile change in whereabouts |
openshift-ci
bot
added
the
do-not-merge/hold
Fast ranges needs the nodeslice controller package from whereabouts to run downstream Also adds RBAC permissions to the multus-ancilarry-tools so that it can interact wiht the wherabouts.cni.cncf.io apigroup which contains the nodeslicepools Huge thanks to @dougbtv for working through this with me Signed-off-by: Benjamin Pickard <[email protected]>
bpickard22
force-pushed
the
fast-range
branch
from
d2a5906 to
16797da
Compare
|
@bpickard22: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/approve |
openshift-ci
bot
added
the
approved
| fieldRef: | ||
| apiVersion: v1 | ||
| fieldPath: spec.nodeName | ||
| - name: WHEREABOLaunch nightly aws,no-spotUTS_NAMESPACE |
There was a problem hiding this comment.
OOPS! Dude, this has a funky copy/pasta error
There was a problem hiding this comment.
good catch
will take care of it
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bpickard22, dougbtv The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cc @dougbtv
Add whereabouts controller and necessary RBAC to enable fast ranges in openshift
Currently pointing to personal image, but when dockerfile change merges in o/wherabouts i will correct the image ref and remove the hold