-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Release 4.16] OCPBUGS-50712: Not update status.migration of the network.config CR to empty #2651
base: release-4.16
Are you sure you want to change the base?
Conversation
@pliurh: This pull request references Jira Issue OCPBUGS-50712, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: pliurh The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/jira refresh |
@pliurh: This pull request references Jira Issue OCPBUGS-50712, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@pliurh: This pull request references Jira Issue OCPBUGS-50712, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@pliurh: This pull request references Jira Issue OCPBUGS-50712, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Only update status.migration.network of the network.config CR when the spec.migration.network of network.operator CR is set. Signed-off-by: Peng Liu <[email protected]>
@pliurh: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/cc @martinkennelly |
If spec.migration.features of the network.operator CR, CNO will update the status.migration of the network.config CR to an empty value '{}'. It prevents CNO from proceeding with live migration. This shall be fixed in CNO.
Only update status.migration.network of the network.config CR when the spec.migration.network of network.operator CR is set.