NO-JIRA: Use k8s.sets for the fields of ClusterCapabilities #1159
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@hongkailiu: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: hongkailiu The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
https://github.com/openshift/cluster-version-operator/pull/1133/files and the current PR: |
hongkailiu
force-pushed
the
no-issues-simple-3
branch
from
748803a to
13f4cb7
Compare
hongkailiu
force-pushed
the
no-issues-simple-3
branch
from
13f4cb7 to
5e697c2
Compare
hongkailiu
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
@hongkailiu: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| // SortedList returns the slice with contents in sorted order for a given set of configv1.ClusterVersionCapability. | ||
| // It returns nil if the give set is nil. | ||
| func SortedList(s sets.Set[configv1.ClusterVersionCapability]) []configv1.ClusterVersionCapability { | ||
| if s == nil { | ||
| return nil | ||
| } | ||
| l := s.UnsortedList() | ||
| sort.Slice(l, func(i, j int) bool { | ||
| return l[i] < l[j] | ||
| }) | ||
| return l | ||
| } |
There was a problem hiding this comment.
Why cant we use https://pkg.go.dev/k8s.io/apimachinery/pkg/util/sets#List ?
Will rebase after #1157