STOR-2998: Remove legacy gcp-pd-csi-driver-operator

[mpatlasov]

https://redhat.atlassian.net/browse/STOR-2998

All prerequisites merged:

• csi-operator' Makefile and Dockerfile.gcp-pd build gcp-pd operator from /pkg and /cmd, not /legacy: PR#576
• test manifests in top-level dir: PR#589
• CI steps point to manifests in top-level dir: PR#82761
• cachito doesn't reference to legacy/ anymore: PR#12110 , PR#12111

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@mpatlasov: This pull request references STOR-2998 which is a valid jira issue.

Details

In response to this:

https://redhat.atlassian.net/browse/STOR-2998

All prerequisites merged:

• csi-operator' Makefile and Dockerfile.gcp-pd build gcp-pd operator from /pkg and /cmd, not /legacy: PR#576
• test manifests in top-level dir: PR#589
• CI steps point to manifests in top-level dir: PR#82761
• cachito doesn't references to legacy/ anymore: PR#12110 , PR#12111

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: eac068aa-a86e-41ca-ac41-f9684b53c3a5

📥 Commits

Reviewing files that changed from the base of the PR and between d464fc8 and 1550e60.

📒 Files selected for processing (1)

• Makefile

💤 Files with no reviewable changes (1)

• Makefile

---

📝 Walkthrough

Walkthrough

The pull request deletes the legacy GCP PD CSI driver operator. It removes the operator implementation, manifests, tests, Go module, build files, documentation, and end-to-end tests. It also removes controller, node, RBAC, monitoring, storage class, snapshot class, service account, and supporting configuration files. The root Makefile no longer invokes legacy unit tests.

Possibly related PRs

• openshift/csi-operator#562: Added the legacy operator files removed by this pull request.

Suggested reviewers: gnufied, tsmetana

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely identifies the removal of the legacy GCP PD CSI driver operator.
Description check	✅ Passed	The description explains the prerequisite changes and directly relates them to removing the legacy operator.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The PR adds no test files or Ginkgo declarations; its three deleted tests use standard Go Test functions, so no dynamic Ginkgo titles are introduced or changed.
Test Structure And Quality	✅ Passed	The PR removes legacy standard testing.T tests; no changed or surviving test uses Ginkgo DSL or Ginkgo imports, so this Ginkgo-specific check is not applicable.
Microshift Test Compatibility	✅ Passed	The aggregate PR diff adds no files, Go lines, or Ginkgo declarations; it only deletes legacy operator and e2e tests plus Makefile lines.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The complete PR diff contains only deletions plus a Makefile edit; it adds no Ginkgo tests, e2e tests, or multi-node assumptions, so SNO compatibility is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	The aggregate diff has only deletions plus one Makefile edit; no added scheduling lines. The legacy operator path is absent, so this PR introduces no topology constraints.
Ote Binary Stdout Contract	✅ Passed	The full PR has 0 added lines; retained non-vendor source has no OTE lifecycle or stdout APIs, and the removed legacy operator is not an OTE binary.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The PR adds no test files or Ginkgo declarations; it only deletes legacy content and removes Makefile targets, so this check is not applicable.
No-Weak-Crypto	✅ Passed	The PR adds no lines; it deletes legacy files and edits the Makefile. Surviving hash code uses SHA-256 for AWS tag fingerprints, with no weak crypto introduced.
Container-Privileges	✅ Passed	The PR has zero added lines; all removed privilege markers are deleted legacy manifests, and the only surviving change is Makefile target removal.
No-Sensitive-Data-In-Logs	✅ Passed	The PR only deletes legacy files and removes Makefile targets; diff inspection found no added logging calls or sensitive-data output.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mpatlasov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [mpatlasov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mpatlasov]

/test verify

[mpatlasov]

/test security

[dobsonj]

/lgtm

[openshift-merge-bot]

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-upgrade
/test e2e-azure
/test e2e-azure-csi
/test e2e-azure-file-csi
/test e2e-azure-file-nfs-csi
/test e2e-azure-ovn-upgrade
/test e2e-gcp
/test e2e-gcp-csi
/test e2e-gcp-ovn-upgrade

[mpatlasov]

/retest-required

[mpatlasov]

/test e2e-azure

[mpatlasov]

/test e2e-azure-ovn-upgrade

[openshift-ci]

@mpatlasov: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/hypershift-e2e-aks	1550e60	link	false	/test hypershift-e2e-aks

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[mpatlasov]

/verified by CI

[openshift-ci-robot]

@mpatlasov: This PR has been marked as verified by CI.

Details

In response to this:

/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.