OCPBUGS-48688: Implement Workload Identity in Azure for Data Plane Components Part 4

[bryan-cox]

What this PR does / why we need it:
This PR is part 4 of implementing workload identity for data plane components in managed Azure. Specifically this PR only includes changes to the CPO.

The PR for part 3 is - #4587.

Which issue(s) this PR fixes:
Fixes HOSTEDCP-1542

Checklist

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

[openshift-ci-robot]

@bryan-cox: This pull request references HOSTEDCP-1542 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.19." or "openshift-4.19.", but it targets "openshift-4.18" instead.

In response to this:

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [bryan-cox]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@bryan-cox: This pull request references HOSTEDCP-1542 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.19." or "openshift-4.19.", but it targets "openshift-4.18" instead.

In response to this:

What this PR does / why we need it:
This PR is part 2 of implementing workload identity for data plane components in managed Azure. Specifically this PR only includes changes to the CPO.

The PR for part 1 is - #4587.

Which issue(s) this PR fixes:
Fixes HOSTEDCP-1542

Checklist

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@bryan-cox: This pull request references HOSTEDCP-1542 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.19." or "openshift-4.19.", but it targets "openshift-4.18" instead.

In response to this:

What this PR does / why we need it:
This PR is part 4 of implementing workload identity for data plane components in managed Azure. Specifically this PR only includes changes to the CPO.

The PR for part 3 is - #4587.

Which issue(s) this PR fixes:
Fixes HOSTEDCP-1542

Checklist

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[bryan-cox]

/test e2e-aws

[bryan-cox]

/retest-required

[bryan-cox]

Previous AWS failure seems like a flake.

The AKS failure may be something new that was working before

  - lastTransitionTime: "2025-01-18T11:58:11Z"
    message: Cluster operator image-registry is not available
    observedGeneration: 2
    reason: ClusterOperatorNotAvailable
    status: "False"
    type: ClusterVersionSucceeding

[bryan-cox]

I'm seeing errors like this in the CIRO pod logs

I0118 15:22:15.332868       1 azureclient.go:110] Using client certification Azure authentication for ARO HCP
I0118 15:22:15.684433       1 dependencies.go:70] missing the deployment dependency: Secret image-registry-tls: secret "image-registry-tls" not found
I0118 15:22:15.690220       1 azureclient.go:110] Using client certification Azure authentication for ARO HCP
I0118 15:22:15.865520       1 dependencies.go:70] missing the deployment dependency: Secret image-registry-tls: secret "image-registry-tls" not found
I0118 15:22:20.946244       1 azureclient.go:110] Using client certification Azure authentication for ARO HCP
I0118 15:22:21.267001       1 dependencies.go:70] missing the deployment dependency: Secret image-registry-tls: secret "image-registry-tls" not found
I0118 15:22:22.935372       1 azureclient.go:110] Using client certification Azure authentication for ARO HCP
I0118 15:22:23.156231       1 dependencies.go:70] missing the deployment dependency: Secret image-registry-tls: secret "image-registry-tls" not found
I0118 15:22:23.169523       1 azureclient.go:110] Using client certification Azure authentication for ARO HCP
I0118 15:22:23.376115       1 dependencies.go:70] missing the deployment dependency: Secret image-registry-tls: secret "image-registry-tls" not found

[bryan-cox]

/test e2e-aks

I was able to get a HC completed locally so testing again just to make sure there wasn't a transient issue. Locally the HC came up much later than expected but that could have been the airport wifi/VPN (took about ~20m for HC to complete).

[bryan-cox]

/test e2e-aks

[Patryk-Stefanski]

/lgtm

[openshift-ci]

@bryan-cox: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[bryan-cox]

/cherry-pick release-4.18

[openshift-cherrypick-robot]

@bryan-cox: #5361 failed to apply on top of branch "release-4.18":

Applying: Set GC Azure cloud creds secret for CSI & IR
Applying: Update SA RBAC for image registry & azure csi
Using index info to reconstruct a base tree...
M	control-plane-operator/controllers/hostedcontrolplane/configoperator/reconcile.go
M	control-plane-operator/hostedclusterconfigoperator/controllers/resources/rbac/reconcile.go
M	control-plane-operator/hostedclusterconfigoperator/controllers/resources/resources.go
Falling back to patching base and 3-way merge...
Auto-merging control-plane-operator/hostedclusterconfigoperator/controllers/resources/resources.go
CONFLICT (content): Merge conflict in control-plane-operator/hostedclusterconfigoperator/controllers/resources/resources.go
Auto-merging control-plane-operator/hostedclusterconfigoperator/controllers/resources/rbac/reconcile.go
Auto-merging control-plane-operator/controllers/hostedcontrolplane/configoperator/reconcile.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0002 Update SA RBAC for image registry & azure csi

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci-robot]

@bryan-cox: Jira Issue OCPBUGS-48688 is in an unrecognized state (ON_QA) and will not be moved to the MODIFIED state.

In response to this:

What this PR does / why we need it:
This PR is part 4 of implementing workload identity for data plane components in managed Azure. Specifically this PR only includes changes to the CPO.

The PR for part 3 is - #4587.

Which issue(s) this PR fixes:
Fixes HOSTEDCP-1542

Checklist

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[bryan-cox]

/jira backport release-4.18

[openshift-ci-robot]

@bryan-cox: The following backport issues have been created:

• OCPBUGS-48689 for branch release-4.18

Queuing cherrypicks to the requested branches to be created after this PR merges:
/cherrypick release-4.18

In response to this:

/jira backport release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-cherrypick-robot]

@openshift-ci-robot: #5361 failed to apply on top of branch "release-4.18":

Applying: Set GC Azure cloud creds secret for CSI & IR
Applying: Update SA RBAC for image registry & azure csi
Using index info to reconstruct a base tree...
M	control-plane-operator/controllers/hostedcontrolplane/configoperator/reconcile.go
M	control-plane-operator/hostedclusterconfigoperator/controllers/resources/rbac/reconcile.go
M	control-plane-operator/hostedclusterconfigoperator/controllers/resources/resources.go
Falling back to patching base and 3-way merge...
Auto-merging control-plane-operator/hostedclusterconfigoperator/controllers/resources/resources.go
CONFLICT (content): Merge conflict in control-plane-operator/hostedclusterconfigoperator/controllers/resources/resources.go
Auto-merging control-plane-operator/hostedclusterconfigoperator/controllers/resources/rbac/reconcile.go
Auto-merging control-plane-operator/controllers/hostedcontrolplane/configoperator/reconcile.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0002 Update SA RBAC for image registry & azure csi

In response to this:

@bryan-cox: The following backport issues have been created:

• OCPBUGS-48689 for branch release-4.18

Queuing cherrypicks to the requested branches to be created after this PR merges:
/cherrypick release-4.18

In response to this:

/jira backport release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: hypershift
This PR has been included in build ose-hypershift-container-v4.19.0-202501211738.p0.gdc3f49c.assembly.stream.el9.
All builds following this will include this PR.