Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-48510: Allow ARM64 arch deployment on None platform type #5403

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

OCPBUGS-48510: Allow ARM64 arch deployment on None platform type #5403

wants to merge 1 commit into from

Conversation

eranco74
Copy link
Contributor

@eranco74 eranco74 commented Jan 16, 2025 •
edited
Loading

What this PR does / why we need it:
This PR allows the NodePool API to set ARM64 arch for deployments with None platform type.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #OCPBUGS-48510

@openshift-ci openshift-ci bot added area/api Indicates the PR includes changes for the API area/cli Indicates the PR includes changes for CLI and removed do-not-merge/needs-area labels Jan 16, 2025
@eranco74 eranco74 changed the title Allow ARM64 arch deployment on None platform type OCPBUGS-46342: Allow ARM64 arch deployment on None platform type Jan 16, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Jan 16, 2025
@openshift-ci-robot
Copy link

@eranco74: This pull request references Jira Issue OCPBUGS-46342, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

What this PR does / why we need it:
This PR allows the NodePool API to set ARM64 arch for deployments with None platform type.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #OCPBUGS-46342

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jan 16, 2025
@eranco74 eranco74 changed the title OCPBUGS-46342: Allow ARM64 arch deployment on None platform type OCPBUGS-48510: Allow ARM64 arch deployment on None platform type Jan 16, 2025
@openshift-ci-robot
Copy link

@eranco74: This pull request references Jira Issue OCPBUGS-48510, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

What this PR does / why we need it:
This PR allows the NodePool API to set ARM64 arch for deployments with None platform type.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #OCPBUGS-46342

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@eranco74
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link

@eranco74: This pull request references Jira Issue OCPBUGS-48510, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@eranco74
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 16, 2025
@openshift-ci-robot
Copy link

@eranco74: This pull request references Jira Issue OCPBUGS-48510, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @LiangquanLi930

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from LiangquanLi930 January 16, 2025 15:16
@tsorya
Copy link
Contributor

tsorya commented Jan 16, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2025
@bryan-cox
Copy link
Member

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, eranco74

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2025
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 36db419 and 2 for PR HEAD c2a6e08 in total

@enxebre
Copy link
Member

enxebre commented Jan 16, 2025

The issue description talks about agent but this is for None, what's the intersection?

@eranco74
Copy link
Contributor Author

The issue description talks about agent but this is for None, what's the intersection?

The jira was cloned from similar issue about the agent platform, I thought the description was generic (non aws/azure), the intersection is baremetal hosts.

@eranco74
Copy link
Contributor Author

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 36db419 and 2 for PR HEAD c2a6e08 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 007512e and 1 for PR HEAD c2a6e08 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD cb8286a and 0 for PR HEAD c2a6e08 in total

@openshift-ci-robot
Copy link

/hold

Revision c2a6e08 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 17, 2025
@bryan-cox
Copy link
Member

/retest

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 17, 2025

@eranco74: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aks c2a6e08 link true /test e2e-aks
ci/prow/e2e-kubevirt-aws-ovn-reduced c2a6e08 link true /test e2e-kubevirt-aws-ovn-reduced
ci/prow/e2e-aws c2a6e08 link true /test e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@bryan-cox
Copy link
Member

Failures seem legitimate

Error: CustomResourceDefinition.apiextensions.k8s.io "nodepools.hypershift.openshift.io" is invalid: spec.validation.openAPIV3Schema.properties[spec].x-kubernetes-validations[1].rule: Invalid value: apiextensions.ValidationRule{Rule:"self.arch != 'arm64' || has(self.platform.aws) || has(self.platform.azure) || has(self.platform.agent) || has(self.platform.type.none)", Message:"Setting Arch to arm64 is only supported for AWS, Azure, Agent and None", MessageExpression:"", Reason:(*apiextensions.FieldValueErrorReason)(nil), FieldPath:"", OptionalOldSelf:(*bool)(nil)}: compilation failed: ERROR: <input>:1:110: type 'string' does not support field selection

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasueki hasueki Awaiting requested review from hasueki

@isco-rodriguez isco-rodriguez Awaiting requested review from isco-rodriguez

@LiangquanLi930 LiangquanLi930 Awaiting requested review from LiangquanLi930

Assignees

@tsorya tsorya

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api Indicates the PR includes changes for the API area/cli Indicates the PR includes changes for CLI do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@eranco74 @openshift-ci-robot @tsorya @bryan-cox @enxebre