Skip to content

[release-4.20] NO-JIRA: enable CBOR tests #2502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 3, 2025
Merged

[release-4.20] NO-JIRA: enable CBOR tests #2502

merged 1 commit into from
Nov 3, 2025

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Oct 28, 2025

This is an automated cherry-pick of #2500

/assign bertinatto

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 28, 2025
Merged
@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Oct 28, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 28, 2025

@openshift-cherrypick-robot: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci openshift-ci bot requested review from bertinatto and tkashem October 28, 2025 17:36
@benluddy
Copy link

benluddy commented Oct 28, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 28, 2025
@openshift-ci
Copy link

openshift-ci bot commented Oct 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benluddy, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 28, 2025
@bertinatto
Copy link
Member

bertinatto commented Oct 28, 2025

/remove-label backports/unvalidated-commits

@bertinatto
Copy link
Member

bertinatto commented Oct 28, 2025

/retest

@openshift-ci openshift-ci bot removed the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Oct 28, 2025
@bertinatto
Copy link
Member

bertinatto commented Oct 29, 2025

/retest

1 similar comment
@bertinatto
Copy link
Member

bertinatto commented Oct 29, 2025

/retest

@bertinatto
Copy link
Member

bertinatto commented Oct 29, 2025

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Oct 29, 2025
@bertinatto
Copy link
Member

bertinatto commented Oct 30, 2025

/retest

@benluddy
Copy link

benluddy commented Oct 30, 2025

Test passed, but the job timed out and the job history is bleak: https://prow.ci.openshift.org/job-history/gs/test-platform-results/pr-logs/directory/pull-ci-openshift-kubernetes-release-4.20-e2e-aws-ovn-serial.

@bertinatto
Copy link
Member

bertinatto commented Oct 31, 2025

/retest

@benluddy
Copy link

benluddy commented Oct 31, 2025

/verified by "[sig-api-machinery] CBOR [Feature:CBOR] clients remain compatible with the 1.17 sample-apiserver [Serial] [Suite:openshift/conformance/serial] [Suite:k8s]"

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Oct 31, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 31, 2025

@benluddy: This PR has been marked as verified by "[sig-api-machinery] CBOR [Feature:CBOR] clients remain compatible with the 1.17 sample-apiserver [Serial] [Suite:openshift/conformance/serial] [Suite:k8s]".

In response to this:

/verified by "[sig-api-machinery] CBOR [Feature:CBOR] clients remain compatible with the 1.17 sample-apiserver [Serial] [Suite:openshift/conformance/serial] [Suite:k8s]"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bertinatto bertinatto added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Oct 31, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 31, 2025

/retest-required

Remaining retests: 0 against base HEAD debdebd and 2 for PR HEAD 07bedc3 in total

@bertinatto
Copy link
Member

bertinatto commented Nov 3, 2025

/retest

@openshift-ci
Copy link

openshift-ci bot commented Nov 3, 2025

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit cf396bf into openshift:release-4.20 Nov 3, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bertinatto bertinatto Awaiting requested review from bertinatto

@tkashem tkashem Awaiting requested review from tkashem

Assignees

@benluddy benluddy

@bertinatto bertinatto

@kasturinarra kasturinarra

@zhouying7780 zhouying7780

@xingxingxia xingxingxia

@lyman9966 lyman9966

@duanwei33 duanwei33

@wangke19 wangke19

@gangwgr gangwgr

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.