NO-ISSUE: Extend CRD deletion timeouts

[petr-muller]

Similar to Justin's earlier proposal about Pod-related timeouts (#2497), this proposes prolonging timeouts applied to CRD deletion. Most calls to deletion helpers are done for testcase cleanup, and we often see failures in various testcases correlating with periods of high control plane load.

This is not an entirely uncommon flake: https://search.dptools.openshift.org/?search=deleting+CustomResourceDefinition%3A+context+deadline+exceeded&maxAge=48h&context=1&type=bug%2Bissue%2Bjunit&name=&excludeName=&maxMatches=5&maxBytes=20971520&groupBy=job

Similarly to #2497, prolonging timeouts could be done downstream or argued upstream, and it is also possible that there may be other ways to reduce control plane load so that these failures stop occurring. It is also possible that the timeouts are unrelated to control plane load and the timeouts are a symptom of a real problem. I do not have solid evidence.

My approach (that I'd propose even for #2497) would be to run a timeboxed experiment with the prolonged timeouts, validate that we'd see a failure reduction we hope for, and then try moving the changes upstream.

/hold

[openshift-ci-robot]

@petr-muller: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

• 26ed5cd|UPSTREAM: : Extend CRD deletion timeouts: does not specify an upstream backport in the commit message

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

[openshift-ci-robot]

@petr-muller: This pull request explicitly references no jira issue.

In response to this:

Similar to Justin's earlier proposal about Pod-related timeouts (#2497), this proposes prolonging timeouts applied to CRD deletion. Most calls to deletion helpers are done for testcase cleanup, and we often see failures in various testcases correlating with periods of high control plane load.

This is not an entirely uncommon flake: https://search.dptools.openshift.org/?search=deleting+CustomResourceDefinition%3A+context+deadline+exceeded&maxAge=48h&context=1&type=bug%2Bissue%2Bjunit&name=&excludeName=&maxMatches=5&maxBytes=20971520&groupBy=job

Similarly to #2497, prolonging timeouts could be done downstream or argued upstream, and it is also possible that there may be other ways to reduce control plane load so that these failures stop occurring. It is also possible that the timeouts are unrelated to control plane load and the timeouts are a symptom of a real problem. I do not have solid evidence.

My approach (that I'd propose even for #2497) would be to run a timeboxed experiment with the prolonged timeouts, validate that we'd see a failure reduction we hope for, and then try moving the changes upstream.

/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: petr-muller
Once this PR has been reviewed and has the lgtm label, please assign jerpeter1 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• DOWNSTREAM_OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@petr-muller: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-runc	26ed5cd	link	true	/test e2e-aws-ovn-runc
ci/prow/e2e-aws-ovn-techpreview	26ed5cd	link	false	/test e2e-aws-ovn-techpreview
ci/prow/e2e-aws-ovn-serial-2of2	26ed5cd	link	true	/test e2e-aws-ovn-serial-2of2

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.