(fix) broken generate-manifests script for macOS #1056
Conversation
Problem: The script used `realpath --relative-to` which works on Linux (GNU coreutils) but fails on macOS (BSD realpath). This caused `realpath: illegal option -- -` errors when running on macOS. Solution: Replaced GNU-specific realpath --relative-to with Python's os.path.relpath() Note: This introduces Python3 requirements for both CI environments and local development machines Also fixed SED tool selection for script: Use gsed for macOS, sed for linux.
|
Instead of doing this, can we enforce that the environment matches https://operator-framework.github.io/operator-controller/contribute/developer/#special-setup-for-macos? IMHO, python3 is a bigger requirement than bash, gnu-tar, gsed, and coreutils.
|
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anik120, perdasilva The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest |
1 similar comment
|
/retest |
|
@anik120: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
I still favor adopting the same dev tooling restrictions here as in olmv1 (gsed, bash) and ditching the disproportionately heavy python3 dependency. |
openshift-ci
bot
added
the
do-not-merge/hold
The script used
realpath --relative-towhich works on Linux (GNU coreutils) but fails on macOS (BSD realpath). This causedrealpath: illegal option -- -errors when running on macOS.This PR replaces GNU-specific
realpath --relative-towith Python'sos.path.relpath()Note: This introduces Python3 requirements for both CI environments and dev machines.
Also fixed sed tool selection for script: Use
gsed(GNU sed) for macOS,sedfor linux.