Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport MetricsCollectionProfiles patches to 4.18 #29561

Open
wants to merge 10 commits into
base: release-4.18
Choose a base branch
from
Open

Backport MetricsCollectionProfiles patches to 4.18 #29561

wants to merge 10 commits into from

Conversation

rexagod
Copy link
Member

@rexagod rexagod commented Feb 24, 2025

Backport MetricsCollectionProfiles patches to 4.18 to make Sippy happy as it is on 4.19 for the same feature-gate.

rexagod and others added 10 commits February 24, 2025 23:34
@rexagod
address malformed configmap post-test
a2f37c3
@rexagod
fixup! address malformed configmap post-test
96e4079
@rexagod
fixup! fixup! address malformed configmap post-test
b74e2f8 
Signed-off-by: Pranshu Srivastava <[email protected]>
@eggfoobar @rexagod
fix: move initialization of OC to test instead of package level
afdc79d 
Signed-off-by: ehila <[email protected]>
@rexagod
Revert "Merge pull request openshift#29330 from xueqzhan/revert-29309…
47815f8 
…-malformed-config"

This reverts commit 3020953, reversing
changes made to 90bc491.
@rexagod
serialize MetricsCollectionProfiles tests
9670798 
Signed-off-by: Pranshu Srivastava <[email protected]>
@rexagod
set MetricsCollectionProfiles tests timeout to 10m
a80e104 
Signed-off-by: Pranshu Srivastava <[email protected]>
@rexagod
don't check for cm absence as it should be present in gcp/aws
b725269 
Signed-off-by: Pranshu Srivastava <[email protected]>
@rexagod
address rebase conflicts post-openshift#29428
c8c233b
@rexagod
Partially apply d7ff8ae
0e184ec 
Partially apply a commit from openshift#29428 to pull in only the collection
profiles change. This helps keep this PR's scope limited to it, and
makes it easier to review and bisect later on.

Signed-off-by: Pranshu Srivastava <[email protected]>
@openshift-ci openshift-ci bot requested review from beekhof and jan--f February 24, 2025 18:38
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 24, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rexagod
Once this PR has been reviewed and has the lgtm label, please assign bertinatto for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rexagod
Copy link
Member Author

rexagod commented Feb 24, 2025

  • Run payload tests to make sure this works as expected once preliminary tests pass.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 24, 2025

@rexagod: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node-upgrade 0e184ec link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-aws-ovn-serial 0e184ec link true /test e2e-aws-ovn-serial
ci/prow/okd-scos-e2e-aws-ovn 0e184ec link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-gcp-ovn-rt-upgrade 0e184ec link false /test e2e-gcp-ovn-rt-upgrade
ci/prow/verify 0e184ec link true /test verify
ci/prow/e2e-aws-ovn-single-node 0e184ec link false /test e2e-aws-ovn-single-node
ci/prow/e2e-agnostic-ovn-cmd 0e184ec link false /test e2e-agnostic-ovn-cmd

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beekhof beekhof Awaiting requested review from beekhof

@jan--f jan--f Awaiting requested review from jan--f

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rexagod @eggfoobar