Skip to content

Revert "Revert "TRT-2049: check for any watch requests"" #29723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

neisw
Copy link
Contributor

@neisw neisw commented Apr 25, 2025

Reverts #29719

Adds a check for ExternalTopology and skips
Makes the new test flake instead of fail

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 25, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 25, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 25, 2025

@neisw: This pull request references TRT-2049 which is a valid jira issue.

In response to this:

Reverts #29719

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Apr 25, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2025
@neisw neisw marked this pull request as ready for review April 25, 2025 20:53
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 25, 2025
@openshift-ci openshift-ci bot requested review from p0lyn0mial and sjenning April 25, 2025 20:54
@neisw
Copy link
Contributor Author

neisw commented Apr 26, 2025

/payload-job periodic-ci-openshift-hypershift-release-4.19-periodics-e2e-aws-ovn-conformance

Copy link
Contributor

openshift-ci bot commented Apr 26, 2025

@neisw: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-hypershift-release-4.19-periodics-e2e-aws-ovn-conformance

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/930717c0-22a1-11f0-9b75-c3d2b02bbfe3-0

@neisw
Copy link
Contributor Author

neisw commented Apr 29, 2025

/payload 4.19 nightly blocking

Copy link
Contributor

openshift-ci bot commented Apr 29, 2025

@neisw: trigger 11 job(s) of type blocking for the nightly release of OCP 4.19

  • periodic-ci-openshift-release-master-ci-4.19-e2e-aws-upgrade-ovn-single-node
  • periodic-ci-openshift-release-master-nightly-4.19-e2e-aws-ovn-upgrade-fips
  • periodic-ci-openshift-release-master-ci-4.19-e2e-azure-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.19-upgrade-from-stable-4.18-e2e-gcp-ovn-rt-upgrade
  • periodic-ci-openshift-hypershift-release-4.19-periodics-e2e-aws-ovn-conformance
  • periodic-ci-openshift-release-master-nightly-4.19-e2e-aws-ovn-serial
  • periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview
  • periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview-serial
  • periodic-ci-openshift-release-master-nightly-4.19-fips-payload-scan
  • periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-bm
  • periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-ipv6

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/15270050-2534-11f0-9ca4-9cb07d3daac5-0

Copy link

openshift-trt bot commented May 2, 2025

Risk analysis has seen new tests most likely introduced by this PR.
Please ensure that new tests meet guidelines for naming and stability.

New Test Risks for sha: 670d70f

Job Name New Test Risk
pull-ci-openshift-origin-main-e2e-aws-ovn-serial Medium - "Find all of the input images from ocp/4.20 and tag them into the stable stream" is a new test, and was only seen in one job.
pull-ci-openshift-origin-main-e2e-aws-ovn-serial Medium - "Find all of the input images from ocp/4.20 and tag them into the stable-initial stream" is a new test, and was only seen in one job.

New tests seen in this PR at sha: 670d70f

  • "Find all of the input images from ocp/4.20 and tag them into the stable stream" [Total: 1, Pass: 1, Fail: 0, Flake: 0]
  • "Find all of the input images from ocp/4.20 and tag them into the stable-initial stream" [Total: 1, Pass: 1, Fail: 0, Flake: 0]

@neisw
Copy link
Contributor Author

neisw commented May 6, 2025

/payload-job periodic-ci-openshift-release-master-ci-4.19-e2e-azure-ovn-upgrade

Copy link
Contributor

openshift-ci bot commented May 6, 2025

@neisw: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.19-e2e-azure-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/bef41c30-2a98-11f0-9ad7-d6ba5677db3f-0

@neisw
Copy link
Contributor Author

neisw commented May 6, 2025

/payload-job periodic-ci-openshift-release-master-nightly-4.19-fips-payload-scan

Copy link
Contributor

openshift-ci bot commented May 6, 2025

@neisw: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.19-fips-payload-scan

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d3455fa0-2a98-11f0-9190-9ea997dcdf1d-0

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 12, 2025

@neisw: This pull request references TRT-2049 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target either version "4.20." or "openshift-4.20.", but it targets "4.19.0" instead.

In response to this:

Reverts #29719

Adds a check for ExternalTopology and skips
Makes the new test flake instead of fail

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dgoodwin
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 12, 2025
Copy link
Contributor

openshift-ci bot commented May 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgoodwin, neisw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@neisw
Copy link
Contributor Author

neisw commented May 12, 2025

/payload 4.20 nightly blocking

Copy link
Contributor

openshift-ci bot commented May 12, 2025

@neisw: trigger 11 job(s) of type blocking for the nightly release of OCP 4.20

  • periodic-ci-openshift-release-master-ci-4.20-e2e-aws-upgrade-ovn-single-node
  • periodic-ci-openshift-release-master-nightly-4.20-e2e-aws-ovn-upgrade-fips
  • periodic-ci-openshift-release-master-ci-4.20-e2e-azure-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.20-upgrade-from-stable-4.19-e2e-gcp-ovn-rt-upgrade
  • periodic-ci-openshift-hypershift-release-4.20-periodics-e2e-aws-ovn-conformance
  • periodic-ci-openshift-release-master-nightly-4.20-e2e-aws-ovn-serial
  • periodic-ci-openshift-release-master-ci-4.20-e2e-aws-ovn-techpreview
  • periodic-ci-openshift-release-master-ci-4.20-e2e-aws-ovn-techpreview-serial
  • periodic-ci-openshift-release-master-nightly-4.20-fips-payload-scan
  • periodic-ci-openshift-release-master-nightly-4.20-e2e-metal-ipi-ovn-bm
  • periodic-ci-openshift-release-master-nightly-4.20-e2e-metal-ipi-ovn-ipv6

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/dd27ff70-2f5f-11f0-9f97-6775b0a0c068-0

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 21ad7e1 and 2 for PR HEAD 670d70f in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 2e43993 and 1 for PR HEAD 670d70f in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 6e15b2c and 0 for PR HEAD 670d70f in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 6e15b2c and 2 for PR HEAD 670d70f in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 8fad4d6 and 1 for PR HEAD 670d70f in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 5b6e4cc and 0 for PR HEAD 670d70f in total

@openshift-ci-robot
Copy link

/hold

Revision 670d70f was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 14, 2025
@neisw
Copy link
Contributor Author

neisw commented May 14, 2025

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 14, 2025
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 07c5e03 and 2 for PR HEAD 670d70f in total

@neisw
Copy link
Contributor Author

neisw commented May 14, 2025

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 3bfea73 and 2 for PR HEAD 670d70f in total

Copy link
Contributor

openshift-ci bot commented May 15, 2025

@neisw: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-ovn-etcd-scaling 670d70f link false /test e2e-gcp-ovn-etcd-scaling
ci/prow/e2e-openstack-serial 670d70f link false /test e2e-openstack-serial
ci/prow/e2e-azure-ovn-etcd-scaling 670d70f link false /test e2e-azure-ovn-etcd-scaling
ci/prow/e2e-metal-ipi-ovn-dualstack-bgp-local-gw-techpreview 670d70f link false /test e2e-metal-ipi-ovn-dualstack-bgp-local-gw-techpreview
ci/prow/e2e-metal-ipi-ovn-kube-apiserver-rollout 670d70f link false /test e2e-metal-ipi-ovn-kube-apiserver-rollout
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6 670d70f link false /test e2e-vsphere-ovn-dualstack-primaryv6
ci/prow/e2e-gcp-fips-serial 670d70f link false /test e2e-gcp-fips-serial
ci/prow/e2e-vsphere-ovn-etcd-scaling 670d70f link false /test e2e-vsphere-ovn-etcd-scaling
ci/prow/e2e-aws-disruptive 670d70f link false /test e2e-aws-disruptive
ci/prow/4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback 670d70f link false /test 4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback
ci/prow/okd-e2e-gcp 670d70f link false /test okd-e2e-gcp
ci/prow/okd-scos-e2e-aws-ovn 670d70f link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-gcp-disruptive 670d70f link false /test e2e-gcp-disruptive
ci/prow/e2e-metal-ipi-ovn-dualstack 670d70f link false /test e2e-metal-ipi-ovn-dualstack
ci/prow/e2e-azure-ovn-upgrade 670d70f link false /test e2e-azure-ovn-upgrade
ci/prow/e2e-metal-ipi-virtualmedia 670d70f link false /test e2e-metal-ipi-virtualmedia
ci/prow/e2e-metal-ipi-serial 670d70f link false /test e2e-metal-ipi-serial
ci/prow/e2e-aws-ovn-etcd-scaling 670d70f link false /test e2e-aws-ovn-etcd-scaling
ci/prow/e2e-aws-ovn-single-node 670d70f link false /test e2e-aws-ovn-single-node
ci/prow/e2e-metal-ipi-serial-ovn-ipv6 670d70f link false /test e2e-metal-ipi-serial-ovn-ipv6
ci/prow/e2e-aws-ovn-serial 670d70f link true /test e2e-aws-ovn-serial
ci/prow/e2e-aws-ovn-serial-publicnet 670d70f link true /test e2e-aws-ovn-serial-publicnet

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit e53a2eb into openshift:main May 15, 2025
37 of 58 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-tests
This PR has been included in build openshift-enterprise-tests-container-v4.20.0-202505151645.p0.ge53a2eb.assembly.stream.el9.
All builds following this will include this PR.

@neisw
Copy link
Contributor Author

neisw commented May 15, 2025

/cherrypick release-4.19

@openshift-cherrypick-robot

@neisw: new pull request created: #29799

In response to this:

/cherrypick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants