Skip to content

MCO-1656: Component Readiness for vSphere Bootimage Update #29741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

RishabhSaini
Copy link
Contributor

@RishabhSaini RishabhSaini commented Apr 29, 2025

Status:
Manually verified that the new tests for vSphere are passing.

Currently it needs the following PRs to execute correctly:

  1. MCO-1657: FeatureGate for Bootimage updates for the vSphere platform api#2301
    Needed for the ManagedBootImagesvSphere FeatureGate
  2. MCO-1307: Add support for VSphere for BootImage Update machine-config-operator#4677
    ValidationAdmissionPolicy managed-bootimages-platform-check to allow VSphere as the BootImageUpdatePlatform.
  3. MCO-1815: vSphere bootimage update reconciliation should handle bootimage name diverging machine-config-operator#5187

To do:

  • Add another E2E Test
    Steps:
    1. Scales down a MachineSet replicas -= 1
    2. Waits for a successful bootimage update
    3. Scales up the MachineSet replicas += 1
    4. Verifies the new Machine spawned should have been booted from the updated bootimage (possibly by looking at the MCD log aleph version)

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 29, 2025

@RishabhSaini: This pull request references MCO-1656 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 29, 2025
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2025
@openshift-ci openshift-ci bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 30, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 30, 2025

@RishabhSaini: This pull request references MCO-1656 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

Status:
Manually verified that the new tests for vSphere are passing.

Currently it needs:

  1. MCO-1657: FeatureGate for Bootimage updates for the vSphere platform api#2301 for the FeatureGate
  2. ValidationAdmissionPolicy managed-bootimages-platform-check to allow VSphere as the BootImageUpdatePlatform

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 30, 2025

@RishabhSaini: This pull request references MCO-1656 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

Status:
Manually verified that the new tests for vSphere are passing.

Currently it needs:

  1. MCO-1657: FeatureGate for Bootimage updates for the vSphere platform api#2301 for the FeatureGate
  2. ValidationAdmissionPolicy managed-bootimages-platform-check to allow VSphere as the BootImageUpdatePlatform. MCO-1307: Add support for VSphere for BootImage Update machine-config-operator#4677

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 30, 2025

@RishabhSaini: This pull request references MCO-1656 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

Status:
Manually verified that the new tests for vSphere are passing.

Currently it needs:

  1. MCO-1657: FeatureGate for Bootimage updates for the vSphere platform api#2301
    Needed for the ManagedBootImagesvSphere FeatureGate
  2. MCO-1307: Add support for VSphere for BootImage Update machine-config-operator#4677
    ValidationAdmissionPolicy managed-bootimages-platform-check to allow VSphere as the BootImageUpdatePlatform.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 30, 2025

@RishabhSaini: This pull request references MCO-1656 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

Status:
Manually verified that the new tests for vSphere are passing.

Currently it needs the following PRs to execute correctly:

  1. MCO-1657: FeatureGate for Bootimage updates for the vSphere platform api#2301
    Needed for the ManagedBootImagesvSphere FeatureGate
  2. MCO-1307: Add support for VSphere for BootImage Update machine-config-operator#4677
    ValidationAdmissionPolicy managed-bootimages-platform-check to allow VSphere as the BootImageUpdatePlatform.

To do:

  • Add another E2E Test
    Steps:
  1. Scales down a MachineSet replicas -= 1
  2. Waits for a successful bootimage update
  3. Scales up the MachineSet replicas += 1
  4. Verifies the new Machine spawned should have been booted from the updated bootimage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 30, 2025

@RishabhSaini: This pull request references MCO-1656 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

Status:
Manually verified that the new tests for vSphere are passing.

Currently it needs the following PRs to execute correctly:

  1. MCO-1657: FeatureGate for Bootimage updates for the vSphere platform api#2301
    Needed for the ManagedBootImagesvSphere FeatureGate
  2. MCO-1307: Add support for VSphere for BootImage Update machine-config-operator#4677
    ValidationAdmissionPolicy managed-bootimages-platform-check to allow VSphere as the BootImageUpdatePlatform.

To do:

  • Add another E2E Test
    Steps:
  1. Scales down a MachineSet replicas -= 1
  2. Waits for a successful bootimage update
  3. Scales up the MachineSet replicas += 1
  4. Verifies the new Machine spawned should have been booted from the updated bootimage (possibly by looking at the MCD log aleph version)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

openshift-trt bot commented May 15, 2025

Job Failure Risk Analysis for sha: a5da303

Job Name Failure Risk
pull-ci-openshift-origin-main-e2e-aws-disruptive Medium
[sig-node] static pods should start after being created
Potential external regression detected for High Risk Test analysis
---
[bz-Etcd] clusteroperator/etcd should not change condition/Available
Potential external regression detected for High Risk Test analysis
pull-ci-openshift-origin-main-e2e-azure-ovn-etcd-scaling Low
[sig-architecture] platform pods in ns/openshift-etcd should not exit an excessive amount of times
This test has passed 0.00% of 1 runs on release 4.20 [Architecture:amd64 FeatureSet:default Installer:ipi JobTier:rare Network:ovn NetworkStack:ipv4 Owner:eng Platform:azure SecurityMode:default Topology:ha Upgrade:none] in the last week.
---
[bz-etcd][invariant] alert/etcdMembersDown should not be at or above info
This test has passed 0.00% of 1 runs on release 4.20 [Architecture:amd64 FeatureSet:default Installer:ipi JobTier:rare Network:ovn NetworkStack:ipv4 Owner:eng Platform:azure SecurityMode:default Topology:ha Upgrade:none] in the last week.
---
[bz-kube-storage-version-migrator] clusteroperator/kube-storage-version-migrator should not change condition/Available
This test has passed 0.00% of 1 runs on release 4.20 [Architecture:amd64 FeatureSet:default Installer:ipi JobTier:rare Network:ovn NetworkStack:ipv4 Owner:eng Platform:azure SecurityMode:default Topology:ha Upgrade:none] in the last week.
---
[bz-Cloud Compute] clusteroperator/control-plane-machine-set should not change condition/Degraded
This test has passed 0.00% of 1 runs on release 4.20 [Architecture:amd64 FeatureSet:default Installer:ipi JobTier:rare Network:ovn NetworkStack:ipv4 Owner:eng Platform:azure SecurityMode:default Topology:ha Upgrade:none] in the last week.
pull-ci-openshift-origin-main-e2e-gcp-ovn-etcd-scaling Low
[bz-Cloud Compute] clusteroperator/control-plane-machine-set should not change condition/Degraded
This test has passed 0.00% of 1 runs on release 4.20 [Architecture:amd64 FeatureSet:default Installer:ipi JobTier:rare Network:ovn NetworkStack:ipv4 Owner:eng Platform:gcp SecurityMode:default Topology:ha Upgrade:none] in the last week.
pull-ci-openshift-origin-main-e2e-vsphere-ovn-etcd-scaling High
[sig-api-machinery] disruption/cache-openshift-api apiserver/openshift-apiserver connection/new should be available throughout the test
This test has passed 99.58% of 4761 runs on release 4.20 [Overall] in the last week.
---
[sig-instrumentation] disruption/metrics-api connection/new should be available throughout the test
This test has passed 99.57% of 3933 runs on release 4.20 [Overall] in the last week.

Copy link
Contributor

openshift-ci bot commented Jul 23, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: RishabhSaini
Once this PR has been reviewed and has the lgtm label, please assign xueqzhan for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 23, 2025

@RishabhSaini: This pull request references MCO-1656 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

In response to this:

Status:
Manually verified that the new tests for vSphere are passing.

Currently it needs the following PRs to execute correctly:

  1. MCO-1657: FeatureGate for Bootimage updates for the vSphere platform api#2301
    Needed for the ManagedBootImagesvSphere FeatureGate
  2. MCO-1307: Add support for VSphere for BootImage Update machine-config-operator#4677
    ValidationAdmissionPolicy managed-bootimages-platform-check to allow VSphere as the BootImageUpdatePlatform.
  3. MCO-1815: vSphere bootimage update reconciliation should handle bootimage name diverging machine-config-operator#5187

To do:

  • Add another E2E Test
    Steps:
  1. Scales down a MachineSet replicas -= 1
  2. Waits for a successful bootimage update
  3. Scales up the MachineSet replicas += 1
  4. Verifies the new Machine spawned should have been booted from the updated bootimage (possibly by looking at the MCD log aleph version)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@RishabhSaini RishabhSaini force-pushed the vsphere branch 2 times, most recently from 678a799 to 4b9091c Compare July 23, 2025 17:16
Copy link

openshift-trt bot commented Jul 23, 2025

Job Failure Risk Analysis for sha: 4b9091c

Job Name Failure Risk
pull-ci-openshift-origin-main-e2e-aws-ovn-microshift IncompleteTests
Tests for this run (23) are below the historical average (1754): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-aws-ovn-microshift-serial IncompleteTests
Tests for this run (23) are below the historical average (828): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-azure-ovn-etcd-scaling Low
[bz-kube-storage-version-migrator] clusteroperator/kube-storage-version-migrator should not change condition/Available
This test has passed 0.00% of 1 runs on release 4.20 [Architecture:amd64 FeatureSet:default Installer:ipi JobTier:rare Network:ovn NetworkStack:ipv4 Owner:eng Platform:azure SecurityMode:default Topology:ha Upgrade:none] in the last week.

Open Bugs
etcd-scaling jobs failing ~60% of the time
[CI] e2e-openstack-ovn-etcd-scaling job permanent fails at many openshift-test tests
---
[bz-Cloud Compute] clusteroperator/control-plane-machine-set should not change condition/Degraded
This test has passed 0.00% of 1 runs on release 4.20 [Architecture:amd64 FeatureSet:default Installer:ipi JobTier:rare Network:ovn NetworkStack:ipv4 Owner:eng Platform:azure SecurityMode:default Topology:ha Upgrade:none] in the last week.

Open Bugs
etcd-scaling jobs failing ~60% of the time

@RishabhSaini RishabhSaini force-pushed the vsphere branch 2 times, most recently from a1c5221 to 4147550 Compare July 25, 2025 16:28
Copy link
Contributor

openshift-ci bot commented Jul 25, 2025

@RishabhSaini: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-e2e-gcp a5da303 link false /test okd-e2e-gcp
ci/prow/e2e-metal-ipi-ovn-dualstack-bgp-local-gw-techpreview a5da303 link false /test e2e-metal-ipi-ovn-dualstack-bgp-local-gw-techpreview
ci/prow/e2e-gcp-fips-serial a5da303 link false /test e2e-gcp-fips-serial
ci/prow/4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback a5da303 link false /test 4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback
ci/prow/e2e-aws-ovn-serial a5da303 link true /test e2e-aws-ovn-serial
ci/prow/e2e-aws-ovn-serial-publicnet a5da303 link true /test e2e-aws-ovn-serial-publicnet
ci/prow/e2e-vsphere-ovn-upi 761339a link true /test e2e-vsphere-ovn-upi
ci/prow/e2e-metal-ipi-ovn-dualstack-local-gateway 761339a link false /test e2e-metal-ipi-ovn-dualstack-local-gateway
ci/prow/e2e-metal-ipi-ovn-ipv6 761339a link true /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-metal-ipi-ovn-kube-apiserver-rollout 761339a link false /test e2e-metal-ipi-ovn-kube-apiserver-rollout
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6 761339a link false /test e2e-vsphere-ovn-dualstack-primaryv6
ci/prow/e2e-azure-ovn-upgrade 761339a link false /test e2e-azure-ovn-upgrade
ci/prow/e2e-gcp-ovn-techpreview-serial-2of2 761339a link false /test e2e-gcp-ovn-techpreview-serial-2of2
ci/prow/e2e-aws-ovn-single-node-upgrade 761339a link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-metal-ipi-serial-2of2 761339a link false /test e2e-metal-ipi-serial-2of2
ci/prow/e2e-metal-ipi-ovn 761339a link false /test e2e-metal-ipi-ovn
ci/prow/e2e-aws-disruptive 761339a link false /test e2e-aws-disruptive
ci/prow/e2e-metal-ipi-serial-ovn-ipv6-2of2 761339a link false /test e2e-metal-ipi-serial-ovn-ipv6-2of2
ci/prow/okd-scos-e2e-aws-ovn 761339a link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-azure-ovn-etcd-scaling 761339a link false /test e2e-azure-ovn-etcd-scaling
ci/prow/e2e-gcp-fips-serial-2of2 761339a link false /test e2e-gcp-fips-serial-2of2
ci/prow/e2e-gcp-fips-serial-1of2 761339a link false /test e2e-gcp-fips-serial-1of2
ci/prow/e2e-openstack-ovn 761339a link false /test e2e-openstack-ovn
ci/prow/e2e-aws-ovn-kube-apiserver-rollout 761339a link false /test e2e-aws-ovn-kube-apiserver-rollout
ci/prow/e2e-gcp-disruptive 761339a link false /test e2e-gcp-disruptive
ci/prow/e2e-vsphere-ovn 761339a link true /test e2e-vsphere-ovn
ci/prow/e2e-gcp-ovn-etcd-scaling 761339a link false /test e2e-gcp-ovn-etcd-scaling
ci/prow/e2e-metal-ipi-ovn-dualstack 761339a link false /test e2e-metal-ipi-ovn-dualstack
ci/prow/e2e-vsphere-ovn-etcd-scaling 761339a link false /test e2e-vsphere-ovn-etcd-scaling
ci/prow/e2e-metal-ipi-virtualmedia 761339a link false /test e2e-metal-ipi-virtualmedia
ci/prow/okd-scos-images 761339a link true /test okd-scos-images
ci/prow/e2e-aws-ovn-etcd-scaling 761339a link false /test e2e-aws-ovn-etcd-scaling

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link

openshift-trt bot commented Jul 25, 2025

Job Failure Risk Analysis for sha: 761339a

Job Name Failure Risk
pull-ci-openshift-origin-main-e2e-aws-disruptive IncompleteTests
Tests for this run (106) are below the historical average (143): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-azure-ovn-etcd-scaling Low
[bz-kube-storage-version-migrator] clusteroperator/kube-storage-version-migrator should not change condition/Available
This test has passed 0.00% of 1 runs on release 4.20 [Architecture:amd64 FeatureSet:default Installer:ipi JobTier:rare Network:ovn NetworkStack:ipv4 Owner:eng Platform:azure SecurityMode:default Topology:ha Upgrade:none] in the last week.

Open Bugs
etcd-scaling jobs failing ~60% of the time
[CI] e2e-openstack-ovn-etcd-scaling job permanent fails at many openshift-test tests
---
[bz-Cloud Compute] clusteroperator/control-plane-machine-set should not change condition/Degraded
This test has passed 0.00% of 1 runs on release 4.20 [Architecture:amd64 FeatureSet:default Installer:ipi JobTier:rare Network:ovn NetworkStack:ipv4 Owner:eng Platform:azure SecurityMode:default Topology:ha Upgrade:none] in the last week.

Open Bugs
etcd-scaling jobs failing ~60% of the time
pull-ci-openshift-origin-main-e2e-gcp-disruptive IncompleteTests
Tests for this run (107) are below the historical average (167): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-gcp-ovn-etcd-scaling Low
[bz-Cloud Compute] clusteroperator/control-plane-machine-set should not change condition/Degraded
This test has passed 0.00% of 1 runs on release 4.20 [Architecture:amd64 FeatureSet:default Installer:ipi JobTier:rare Network:ovn NetworkStack:ipv4 Owner:eng Platform:gcp SecurityMode:default Topology:ha Upgrade:none] in the last week.

Open Bugs
etcd-scaling jobs failing ~60% of the time
pull-ci-openshift-origin-main-e2e-gcp-ovn-techpreview-serial-2of2 High
[sig-architecture] platform pods in ns/openshift-cluster-csi-drivers should not exit an excessive amount of times
This test has passed 99.60% of 4485 runs on release 4.20 [Overall] in the last week.
pull-ci-openshift-origin-main-e2e-vsphere-ovn-upi IncompleteTests
Tests for this run (12) are below the historical average (3402): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants