Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PERFSCALE-3728] Introduce OKD-scos 4.19 deployments #62535

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[PERFSCALE-3728] Introduce OKD-scos 4.19 deployments #62535

wants to merge 4 commits into from
+659 −0

Conversation

josecastillolema
Copy link
Contributor

No description provided.

@openshift-ci openshift-ci bot requested review from shahsahil264 and svetsa-rh March 7, 2025 10:12
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: josecastillolema

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2025
@josecastillolema
Copy link
Contributor Author

/pj-rehearse ?

@openshift-ci-robot
Copy link
Contributor

@josecastillolema: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@josecastillolema
Copy link
Contributor Author

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@josecastillolema: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@josecastillolema
Copy link
Contributor Author

/test ?

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 7, 2025

@josecastillolema: The following commands are available to trigger required jobs:

/test app-ci-config-dry

/test boskos-config

/test boskos-config-generation

/test build01-dry

/test build02-dry

/test build03-dry

/test build04-dry

/test build05-dry

/test build06-dry

/test build07-dry

/test build09-dry

/test build11-dry

/test check-gh-automation

/test check-gh-automation-tide

/test ci-operator-config

/test ci-operator-config-metadata

/test ci-operator-registry

/test ci-secret-bootstrap-config-validation

/test ci-testgrid-allow-list

/test clusterimageset-validate

/test config

/test core-valid

/test generated-config

/test generated-dashboards

/test hosted-mgmt-dry

/test image-mirroring-config-validation

/test jira-lifecycle-config

/test openshift-image-mirror-mappings

/test ordered-prow-config

/test owners

/test pr-reminder-config

/test prow-config

/test prow-config-filenames

/test prow-config-semantics

/test pylint

/test release-config

/test release-controller-config

/test rover-groups-config-validation

/test secret-generator-config-valid

/test services-valid

/test stackrox-stackrox-stackrox-stackrox-check

/test step-registry-metadata

/test step-registry-shellcheck

/test sync-rover-groups

/test vsphere02-dry

/test yamllint

The following commands are available to trigger optional jobs:

/test check-cluster-profiles-config

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-release-check-gh-automation

pull-ci-openshift-release-master-ci-operator-config

pull-ci-openshift-release-master-ci-operator-config-metadata

pull-ci-openshift-release-master-ci-operator-registry

pull-ci-openshift-release-master-config

pull-ci-openshift-release-master-core-valid

pull-ci-openshift-release-master-generated-config

pull-ci-openshift-release-master-ordered-prow-config

pull-ci-openshift-release-master-owners

pull-ci-openshift-release-master-prow-config-filenames

pull-ci-openshift-release-master-prow-config-semantics

pull-ci-openshift-release-master-release-controller-config

pull-ci-openshift-release-openshift-image-mirror-mappings

pull-ci-openshift-release-yamllint

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 9, 2025
@josecastillolema
[PERFSCALE-3728] Introduce OKD-scos 4.19 deployments
ffa79c2 
Signed-off-by: Jose Castillo Lema <[email protected]>
@josecastillolema
Remove deprecated jobs
95a5787 
Signed-off-by: Jose Castillo Lema <[email protected]>
@josecastillolema
Rebase
06bd38a 
Signed-off-by: Jose Castillo Lema <[email protected]>
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 14, 2025
@josecastillolema
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-eng-ocp-qe-perfscale-ci-main-aws-4.19-okd-x86-node-density-cni-3nodes

@openshift-ci-robot
Copy link
Contributor

@josecastillolema: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@josecastillolema
Copy link
Contributor Author 

sh-5.1$ oc version -oyaml
clientVersion:
  buildDate: "2025-03-07T17:48:19Z"
  compiler: gc
  gitCommit: 6de369b12
  gitTreeState: dirty
  gitVersion: v4.2.0-alpha.0-2618-g6de369b
  goVersion: go1.23.6 (Red Hat 1.23.6-2.el9_6) X:strictfipsruntime
  major: ""
  minor: ""
  platform: linux/amd64
kustomizeVersion: v5.5.0
openshiftVersion: 4.19.0-0.okd-scos-2025-03-13-150733
serverVersion:
  buildDate: "2025-03-06T19:14:25Z"
  compiler: gc
  gitCommit: 2f2cf3874c491fae316a4537b274f31ec899dc05
  gitTreeState: dirty
  gitVersion: v1.32.2-dirty
  goVersion: go1.23.6 (Red Hat 1.23.6-2.el9_6) X:strictfipsruntime
  major: "1"
  minor: "32"
  platform: linux/amd64

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 14, 2025

@josecastillolema: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift-eng/ocp-qe-perfscale-ci/main/aws-4.19-okd-x86-conc-builds-3nodes b5503ec link unknown /pj-rehearse pull-ci-openshift-eng-ocp-qe-perfscale-ci-main-aws-4.19-okd-x86-conc-builds-3nodes
ci/rehearse/openshift-eng/ocp-qe-perfscale-ci/main/aws-4.19-okd-x86-node-density-cni-3nodes 06bd38a link unknown /pj-rehearse pull-ci-openshift-eng-ocp-qe-perfscale-ci-main-aws-4.19-okd-x86-node-density-cni-3nodes

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@josecastillolema
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@josecastillolema: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 14, 2025
@josecastillolema
Copy link
Contributor Author

/assign @vishnuchalla

@josecastillolema
Copy link
Contributor Author

/assign @paigerube14

@josecastillolema
Copy link
Contributor Author

/assign @jtaleric

jtaleric
jtaleric reviewed Mar 14, 2025
View reviewed changes
...nshift-eng/ocp-qe-perfscale-ci/openshift-eng-ocp-qe-perfscale-ci-main__aws-4.19-okd-x86.yaml Outdated
- always_run: false
as: compact-cp-3nodes
steps:
allow_skip_on_success: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets flip this to collect.

Copy link
Contributor Author

@josecastillolema josecastillolema Mar 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How this is done?
Is there a env variable or some step?
Can you please point me to any examples?
As part of the rehearse I can see the following steps:

  • gather-audit-logs
  • gather-aws-console
  • gather-extra/
  • gather-must-gather/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was ran because that job failed.

jtaleric
jtaleric reviewed Mar 14, 2025
View reviewed changes
...nshift-eng/ocp-qe-perfscale-ci/openshift-eng-ocp-qe-perfscale-ci-main__aws-4.19-okd-x86.yaml Outdated
- always_run: false
as: router-perf-24nodes
steps:
allow_skip_on_success: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here - just in case we hit issues we might want these must-gathers.

jtaleric
jtaleric reviewed Mar 14, 2025
View reviewed changes
...nshift-eng/ocp-qe-perfscale-ci/openshift-eng-ocp-qe-perfscale-ci-main__aws-4.19-okd-x86.yaml
- ref: openshift-qe-workers-scale
- chain: openshift-qe-node-density-cni
workflow: openshift-qe-installer-aws
timeout: 2h0m0s
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious why some jobs you have 5h and others you have 2h?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed the same parameters as openshift-eng-ocp-qe-perfscale-ci-main__aws-4.19-nightly-x86.yaml

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack. so i fear BM deploys takes a bit longer than AWS.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are going to stick to AWS for OKD.

@josecastillolema
allow_skip_on_success=false
3e98bc9 
Signed-off-by: Jose Castillo Lema <[email protected]>
@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 17, 2025
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@josecastillolema: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-eng-ocp-qe-perfscale-ci-main-aws-4.19-okd-x86-compact-cp-3nodes openshift-eng/ocp-qe-perfscale-ci presubmit Presubmit changed
pull-ci-openshift-eng-ocp-qe-perfscale-ci-main-aws-4.19-okd-x86-control-plane-3nodes openshift-eng/ocp-qe-perfscale-ci presubmit Presubmit changed
pull-ci-openshift-eng-ocp-qe-perfscale-ci-main-aws-4.19-okd-x86-node-density-cni-3nodes openshift-eng/ocp-qe-perfscale-ci presubmit Presubmit changed
pull-ci-openshift-eng-ocp-qe-perfscale-ci-main-aws-4.19-okd-x86-node-density-heavy-3nodes openshift-eng/ocp-qe-perfscale-ci presubmit Presubmit changed
pull-ci-openshift-eng-ocp-qe-perfscale-ci-main-aws-4.19-okd-x86-payload-node-density-cni-6nodes openshift-eng/ocp-qe-perfscale-ci presubmit Presubmit changed
pull-ci-openshift-eng-ocp-qe-perfscale-ci-main-aws-4.19-okd-x86-payload-node-density-heavy-6nodes openshift-eng/ocp-qe-perfscale-ci presubmit Presubmit changed
pull-ci-openshift-eng-ocp-qe-perfscale-ci-main-aws-4.19-okd-x86-router-perf-24nodes openshift-eng/ocp-qe-perfscale-ci presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahsahil264 shahsahil264

@svetsa-rh svetsa-rh

@jtaleric jtaleric

@paigerube14 paigerube14

Assignees

@jtaleric jtaleric

@vishnuchalla vishnuchalla

@paigerube14 paigerube14

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@josecastillolema @openshift-ci-robot @jtaleric @paigerube14 @vishnuchalla @openshift-merge-robot