-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Add new longduration Disconnected CI job for MCO #82473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -409,6 +409,22 @@ tests: | |
| test: | ||
| - chain: mco-e2e-test | ||
| workflow: openshift-e2e-aws-proxy | ||
| - always_run: false | ||
| as: e2e-aws-mco-disconnected-longduration | ||
| cron: 17 6 * * 6 | ||
| shard_count: 3 | ||
| steps: | ||
| cluster_profile: aws-mco-qe | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🩺 Stability & Availability | 🟠 Major | 🏗️ Heavy lift 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
printf 'Target files:\n'
fd -a 'openshift-machine-config-operator-release-4.(22|23)__periodics\.yaml$' . || true
printf '\nGit status/diff stat:\n'
git status --short
git diff --stat || true
printf '\nRelevant lines:\n'
for f in $(fd 'openshift-machine-config-operator-release-4.(22|23)__periodics\.yaml$' .); do
echo "--- $f"
wc -l "$f"
sed -n '405,425p' "$f" | cat -n
done
printf '\nSearch for aws-mco-qe and cluster_profile in machine-config-operator periodic configs:\n'
rg -n 'aws-mco-qe|cluster_profile|ssh-privatekey|ssh-private|privatekey|mirror|bastion|disconnected' ci-operator/config/openshift/machine-config-operator || true
printf '\nSearch for vault references in repo:\n'
rg -n 'vault|vault/|quay.io/app-sre/vault|ssh-private' . || trueRepository: openshift/release Length of output: 50374 🏁 Script executed: #!/bin/bash
set -euo pipefail
TARGETS=(
"ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-4.22__periodics.yaml"
"ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-4.23__periodics.yaml"
)
printf 'Target file existence/trimmed relevant sections:\n'
for f in "${TARGETS[@]}"; do
if [ -f "$f" ]; then
echo "--- $f"
rg -n '^cluster_profile:|cluster_profile:|aws-mco-qe|install:|release|tests:' "$f" -C 3
else
echo "MISSING $f"
fi
done
printf '\nCluster profile usage for aws-mco-qe in machine-config-operator configs:\n'
rg -n '^ (aws-mco-qe|mco-qe):|cluster_profile: aws-mco-qe|mco-qe:' ci-operator/config/openshift/machine-config-operator || true
printf '\nCI secret bootstrap entries whose folder name contains mco or mco-qe or aws-mco (bounded):\n'
python3 - <<'PY'
from pathlib import Path
p=Path("core-services/ci-secret-bootstrap/_config.yaml")
text=p.read_text()
lines=text.splitlines()
for i,line in enumerate(lines):
if "aws-mco-qe" in line or ("mco-qe" in line and ":" in line):
print(f"{p}:{i+1}:{line}")
for j in range(max(1,i-6), min(len(lines), i+15)+1):
print(f"{p}:{j+1}:{lines[j]}")
print("---")
PY
printf '\nTarget files in git status (names only):\n'
git status --short | grep -E 'openshift-machine-config-operator-release-4.(22|23)__periodics\.yaml$' || true
printf '\nTarget changed context with git diff (stat and names only):\n'
git diff --stat -- ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-4.22__periodics.yaml ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-4.23__periodics.yaml || true
git diff -- ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-4.22__periodics.yaml ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-4.23__periodics.yaml | sed -n '1,120p' || trueRepository: openshift/release Length of output: 14715 🌐 Web query:
💡 Result: The "invalid format" error for an Citations:
🏁 Script executed: #!/bin/bash
set -euo pipefail
printf 'ci-secret-bootstrap aws-mco-qe section:\n'
sed -n '1145,1210p' core-services/ci-secret-bootstrap/_config.yaml | cat -n
printf '\nAll aws-mco-qe references:\n'
rg -n 'aws-mco-qe|cluster-secrets-aws-mco-qe' . || true
printf '\nTarget section context both files:\n'
for f in ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-4.22__periodics.yaml ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-4.23__periodics.yaml; do
echo "--- $f"
sed -n '390,420p' "$f" | cat -n
done
printf '\nWorkflow/reference for disconnected AWS steps containing aws-mco-qe or MCO profile references:\n'
rg -n 'aws-mco-qe|MCO_CONF|mirror|bastion|ssh-privatekey|cluster-secrets-aws-mco-qe' ci-operator/step ci-operator/config/openshift/machine-config-operator || trueRepository: openshift/release Length of output: 16274 Resolve the
Fix the vault key by storing the literal OpenSSH private-key content with required newlines, no passphrase, and run the configured Or select a compatible profile/workflow if this cluster is not available. 📍 Affects 2 files
🤖 Prompt for AI Agents |
||
| env: | ||
| BASE_DOMAIN: ocp-mco-qe.devcluster.openshift.com | ||
| COMPUTE_NODE_REPLICAS: "2" | ||
| FEATURE_SET: TechPreviewNoUpgrade | ||
| TEST_ARGS: --disable-monitor=audit-log-analyzer | ||
| TEST_SKIPS: \[Skipped:Disconnected\] | ||
| TEST_SUITE: openshift/machine-config-operator/longduration | ||
| test: | ||
| - chain: mco-e2e-test | ||
| workflow: ocp-mco-e2e-aws-disconnected | ||
| - always_run: false | ||
| as: e2e-aws-ovn-day1-ocl | ||
| capabilities: | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
Repository: openshift/release
Length of output: 592
🏁 Script executed:
Repository: openshift/release
Length of output: 468
🏁 Script executed:
Repository: openshift/release
Length of output: 4270
Resolve the shard-count mismatch across both configurations.
The objective states two shards, but both entries generate three shards. Set
shard_count: 2in each periodics file if two shards are intended, or update the objective if three shards are intentional. Runmake updateafter changing these CI entries.📍 Affects 2 files
ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-4.22__periodics.yaml#L415-L415(this comment)ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-4.23__periodics.yaml#L415-L415🤖 Prompt for AI Agents
Source: Coding guidelines