Add mpiit-data-router-reporter to OPP interop job post steps - #83081
Conversation
|
@amiskin94: GitHub didn't allow me to request PR reviews from the following users: amiskin94. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
WalkthroughThe policy collection configuration adds data-router reporting variables and post-steps for AWS and vSphere tests. Two shell scripts replace unavailable post-process warning output with no-op commands. ChangesPolicy collection test updates
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@amiskin94, Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/step-registry/quay-tests/quay-interop-test/quay-tests-quay-interop-test-commands.sh`:
- Line 2: Update the script’s global shell options to remove xtrace, changing
the default setup to enable only errexit, nounset, and pipefail; keep tracing
limited to an explicit, short diagnostic scope if needed.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 2de318fb-baec-40f6-95aa-1bc26043d323
📒 Files selected for processing (12)
ci-operator/config/stolostron/policy-collection/stolostron-policy-collection-main__ocp4.22-upgrade.yamlci-operator/config/stolostron/policy-collection/stolostron-policy-collection-main__ocp4.22.yamlci-operator/config/stolostron/policy-collection/stolostron-policy-collection-main__ocp5.0-upgrade.yamlci-operator/config/stolostron/policy-collection/stolostron-policy-collection-main__ocp5.0.yamlci-operator/step-registry/acm/tests/alc/acm-tests-alc-commands.shci-operator/step-registry/acm/tests/alc/acm-tests-alc-ref.yamlci-operator/step-registry/acm/tests/grc/acm-tests-grc-commands.shci-operator/step-registry/acm/tests/grc/acm-tests-grc-ref.yamlci-operator/step-registry/acm/tests/observability/acm-tests-observability-commands.shci-operator/step-registry/acm/tests/observability/acm-tests-observability-ref.yamlci-operator/step-registry/quay-tests/quay-interop-test/quay-tests-quay-interop-test-commands.shci-operator/step-registry/quay-tests/quay-interop-test/quay-tests-quay-interop-test-ref.yaml
| set -o pipefail | ||
|
|
||
| #Set Kubeconfig: | ||
| set -euxo pipefail; shopt -s inherit_errexit |
There was a problem hiding this comment.
🔒 Security & Privacy | 🟠 Major | ⚡ Quick win
Remove global xtrace.
Line 2 enables -x for the entire script. Use set -euo pipefail as the default. Enable tracing only in a short non-sensitive diagnostic scope when required.
Proposed fix
-set -euxo pipefail; shopt -s inherit_errexit
+set -euo pipefail
+shopt -s inherit_errexit📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| set -euxo pipefail; shopt -s inherit_errexit | |
| set -euo pipefail | |
| shopt -s inherit_errexit |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/step-registry/quay-tests/quay-interop-test/quay-tests-quay-interop-test-commands.sh`
at line 2, Update the script’s global shell options to remove xtrace, changing
the default setup to enable only errexit, nounset, and pipefail; keep tracing
limited to an explicit, short diagnostic scope if needed.
Source: Coding guidelines
Adds the data-router-reporter step to all 6 OPP interop jobs (AWS + vSphere day-1, AWS upgrade for both 4.22 and 5.0) so test results are uploaded to Report Portal per INTEROP-9202 AC. For vSphere jobs using the acm-ipi-vsphere workflow, the post section is duplicated explicitly since adding post: replaces the workflow's entire post chain. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
c029440 to
0eddb9a
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
/pj-rehearse |
|
@amiskin94: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Use `: "message"` instead of `echo "message" >&2` to follow team convention of relying on xtrace for script output. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
/pj-rehearse |
|
@amiskin94: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Upgrade jobs don't set DR__RP__CR_COMP_NAME and run generic tests (preflight, upgrade, smoke) rather than per-product CR-mapped tests. The step hard-fails without a component name. Remove until a dedicated upgrade CR component is defined. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
@amiskin94: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
- Add DR__RP__CR_COMP_NAME and MAP_TESTS to ocp5.0 AWS and vSphere configs - Revert acm-tests-alc and acm-tests-grc warnings to echo >&2 since these scripts lack xtrace (-x), making : "message" silent Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amiskin94, amp-rh, gparvin, jbpratt The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
/pj-rehearse ack |
|
@amiskin94: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
…ft#83081) * Add mpiit-data-router-reporter to OPP job post steps Adds the data-router-reporter step to all 6 OPP interop jobs (AWS + vSphere day-1, AWS upgrade for both 4.22 and 5.0) so test results are uploaded to Report Portal per INTEROP-9202 AC. For vSphere jobs using the acm-ipi-vsphere workflow, the post section is duplicated explicitly since adding post: replaces the workflow's entire post chain. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Replace echo with xtrace for ExitTrap guard warnings Use `: "message"` instead of `echo "message" >&2` to follow team convention of relying on xtrace for script output. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Remove mpiit-data-router-reporter from upgrade jobs Upgrade jobs don't set DR__RP__CR_COMP_NAME and run generic tests (preflight, upgrade, smoke) rather than per-product CR-mapped tests. The step hard-fails without a component name. Remove until a dedicated upgrade CR component is defined. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Address review feedback: add missing env vars and fix warning visibility - Add DR__RP__CR_COMP_NAME and MAP_TESTS to ocp5.0 AWS and vSphere configs - Revert acm-tests-alc and acm-tests-grc warnings to echo >&2 since these scripts lack xtrace (-x), making : "message" silent Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
4 participants
Summary
mpiit-data-router-reporterpost step to all 6 OPP interop jobs (AWS + vSphere day-1, AWS upgrade for 4.22 and 5.0) so test results are uploaded to Report Portalacm-ipi-vsphereworkflow, the post section is defined explicitly since addingpost:replaces the workflow's entire post chainTest plan
make update/make jobsclean)mpiit-data-router-reporterruns after test steps and beforefirewatch-report-issuesin a triggered OPP job/cc @amiskin94
🤖 Generated with Claude Code
Summary by CodeRabbit
mpiit-data-router-reporter.DR__RP__CR_COMP_NAMEandMAP_TESTSvariables for AWS and vSphere tests.acm-ipi-vsphere, including diagnostics, deprovisioning, result reporting, and Firewatch reporting.