Add TLS strict-adherence and PQC-readiness scanner jobs for ocp-release-operator-sdk and ansible-operator-plugins #83172
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,8 @@ | ||
| base_images: | ||
| tls-scanner-tool: | ||
| name: tls-scanner | ||
| namespace: tls-scanner | ||
| tag: tls-scanner-tool | ||
| build_root: | ||
| from_repository: true | ||
| images: | ||
|
|
@@ -146,6 +151,128 @@ tests: | |
| requests: | ||
| cpu: 100m | ||
| workflow: ipi-gcp | ||
| - always_run: false | ||
| as: tls13-adherence | ||
| optional: true | ||
| steps: | ||
| cluster_profile: openshift-org-gcp | ||
| env: | ||
| PQC_CHECK: "false" | ||
|
Member
There was a problem hiding this comment. I was comparing the changes with https://github.com/openshift/release/pull/82718/changes PR, but I cannot see
Contributor
Author
There was a problem hiding this comment. yes. By default its false. |
||
| SCAN_NAMESPACE: memcached-molecule-operator-system | ||
| SCANNER_CPU: "1" | ||
| SCANNER_MEMORY: 1Gi | ||
| TLS_13_ENABLE_TLS_ADHERENCE: "true" | ||
| TLS_13_TLS_ADHERENCE_POLICY: StrictAllComponents | ||
| test: | ||
| - as: deploy-operator | ||
| cli: latest | ||
| commands: | | ||
| mkdir -p /tmp/bin | ||
| ln -sf "$(command -v oc)" /tmp/bin/kubectl | ||
| export PATH="/tmp/bin:${PATH}" | ||
| cd testdata/memcached-molecule-operator | ||
|
Comment on lines
+170
to
+173
Member
There was a problem hiding this comment. Instead of modifying this here, can we not make the actual script configurable to deploy the operator, then proceed if required? |
||
| make deploy IMG="${IMAGE_FORMAT}" | ||
| oc wait --for=condition=Available --timeout=5m -n memcached-molecule-operator-system deployment/memcached-molecule-operator-controller-manager | ||
|
Comment on lines
+174
to
+175
Member
There was a problem hiding this comment. We generally do some modifications before checking whether the pods are running or not Don't we need that here? |
||
| dependencies: | ||
| - env: IMAGE_FORMAT | ||
| name: ansible-operator-e2e | ||
| from: src | ||
| resources: | ||
| requests: | ||
| cpu: 100m | ||
| - ref: tls-13 | ||
| - ref: tls-scanner-run | ||
| workflow: ipi-gcp | ||
| - as: tls13-adherence-periodic | ||
|
Member
There was a problem hiding this comment. Do we really need a periodic job? Given the traffic on this repo, is the pre-merge test not enough? |
||
| cron: 0 6 * * 1 | ||
| steps: | ||
| cluster_profile: openshift-org-gcp | ||
| env: | ||
| PQC_CHECK: "false" | ||
| SCAN_NAMESPACE: memcached-molecule-operator-system | ||
| SCANNER_CPU: "1" | ||
| SCANNER_MEMORY: 1Gi | ||
| TLS_13_ENABLE_TLS_ADHERENCE: "true" | ||
| TLS_13_TLS_ADHERENCE_POLICY: StrictAllComponents | ||
| test: | ||
| - as: deploy-operator | ||
| cli: latest | ||
| commands: | | ||
| mkdir -p /tmp/bin | ||
| ln -sf "$(command -v oc)" /tmp/bin/kubectl | ||
| export PATH="/tmp/bin:${PATH}" | ||
| cd testdata/memcached-molecule-operator | ||
| make deploy IMG="${IMAGE_FORMAT}" | ||
| oc wait --for=condition=Available --timeout=5m -n memcached-molecule-operator-system deployment/memcached-molecule-operator-controller-manager | ||
| dependencies: | ||
| - env: IMAGE_FORMAT | ||
| name: ansible-operator-e2e | ||
| from: src | ||
| resources: | ||
| requests: | ||
| cpu: 100m | ||
| - ref: tls-13 | ||
| - ref: tls-scanner-run | ||
| workflow: ipi-gcp | ||
| - always_run: false | ||
| as: tls-pqc-readiness | ||
| optional: true | ||
| steps: | ||
| cluster_profile: openshift-org-gcp | ||
| env: | ||
| PQC_CHECK: "true" | ||
|
Member
There was a problem hiding this comment. Don't we need a similar job for SSCSI? |
||
| SCAN_NAMESPACE: memcached-molecule-operator-system | ||
| SCANNER_CPU: "1" | ||
| SCANNER_MEMORY: 1Gi | ||
| test: | ||
| - as: deploy-operator | ||
| cli: latest | ||
| commands: | | ||
| mkdir -p /tmp/bin | ||
| ln -sf "$(command -v oc)" /tmp/bin/kubectl | ||
| export PATH="/tmp/bin:${PATH}" | ||
| cd testdata/memcached-molecule-operator | ||
| make deploy IMG="${IMAGE_FORMAT}" | ||
| oc wait --for=condition=Available --timeout=5m -n memcached-molecule-operator-system deployment/memcached-molecule-operator-controller-manager | ||
| dependencies: | ||
| - env: IMAGE_FORMAT | ||
| name: ansible-operator-e2e | ||
| from: src | ||
| resources: | ||
| requests: | ||
| cpu: 100m | ||
| - ref: tls-13 | ||
| - ref: tls-scanner-run | ||
| workflow: ipi-gcp | ||
| - as: tls-pqc-readiness-periodic | ||
|
Member
There was a problem hiding this comment. Same comment as above to periodic job |
||
| cron: 0 6 * * 1 | ||
| steps: | ||
| cluster_profile: openshift-org-gcp | ||
| env: | ||
| PQC_CHECK: "true" | ||
| SCAN_NAMESPACE: memcached-molecule-operator-system | ||
| SCANNER_CPU: "1" | ||
| SCANNER_MEMORY: 1Gi | ||
| test: | ||
| - as: deploy-operator | ||
| cli: latest | ||
| commands: | | ||
| mkdir -p /tmp/bin | ||
| ln -sf "$(command -v oc)" /tmp/bin/kubectl | ||
| export PATH="/tmp/bin:${PATH}" | ||
| cd testdata/memcached-molecule-operator | ||
| make deploy IMG="${IMAGE_FORMAT}" | ||
| oc wait --for=condition=Available --timeout=5m -n memcached-molecule-operator-system deployment/memcached-molecule-operator-controller-manager | ||
| dependencies: | ||
| - env: IMAGE_FORMAT | ||
| name: ansible-operator-e2e | ||
| from: src | ||
| resources: | ||
| requests: | ||
| cpu: 100m | ||
| - ref: tls-13 | ||
| - ref: tls-scanner-run | ||
| workflow: ipi-gcp | ||
| - as: verify-deps | ||
| steps: | ||
| env: | ||
|
|
||
|
Member
There was a problem hiding this comment. Similar comments for this repo as well, not adding them again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of another periodic job, I think making this required would be more reasonable.