Skip to content

openshift-mcp-server: pin auto-ff job to app.ci - #83296

Closed
2uasimojo wants to merge 1 commit into
openshift:mainfrom
2uasimojo:mcp-server-ff-pin-cluster
Closed

openshift-mcp-server: pin auto-ff job to app.ci#83296
2uasimojo wants to merge 1 commit into
openshift:mainfrom
2uasimojo:mcp-server-ff-pin-cluster

Conversation

@2uasimojo

@2uasimojo 2uasimojo commented Aug 11, 2026

Copy link
Copy Markdown
Member

...so it can find the credential secret

Summary by CodeRabbit

The openshift-mcp-server fast-forward-latest-release periodic job now targets the app.ci cluster. This allows the job to locate its credential secret.

The fast-forward script now uses the fixed openshift-mcp-server repository URL and directory.

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: dd2f1025-5c46-4cba-b657-113920a68b2a

📥 Commits

Reviewing files that changed from the base of the PR and between 9b4d9e5 and e3e9847.

⛔ Files ignored due to path filters (1)
  • ci-operator/jobs/openshift/openshift-mcp-server/openshift-openshift-mcp-server-main-periodics.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (2)
  • ci-operator/config/openshift/openshift-mcp-server/openshift-openshift-mcp-server-main.yaml
  • ci-operator/step-registry/openshift/mcp-server/fastforward/openshift-mcp-server-fastforward-commands.sh
🚧 Files skipped from review as they are similar to previous changes (1)
  • ci-operator/config/openshift/openshift-mcp-server/openshift-openshift-mcp-server-main.yaml

Walkthrough

The fast-forward-latest-release periodic job now selects the app.ci cluster. Its script clones the fixed OpenShift MCP Server repository into the openshift-mcp-server directory.

Changes

OpenShift MCP Server fast-forward workflow

Layer / File(s) Summary
Configure and execute the fast-forward job
ci-operator/config/openshift/openshift-mcp-server/openshift-openshift-mcp-server-main.yaml, ci-operator/step-registry/openshift/mcp-server/fastforward/openshift-mcp-server-fastforward-commands.sh
The periodic job specifies the app.ci cluster. The script uses the fixed repository URL and checkout directory.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested labels: rehearsals-ack

Suggested reviewers: manusa, cajieh

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely identifies the main change: pinning the openshift-mcp-server auto-FF job to app.ci.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR changes CI metadata and a shell clone path only; the diff adds no Ginkgo test-title calls or dynamic test names.
Test Structure And Quality ✅ Passed The PR changes only CI YAML and a shell command script; the complete diff adds no Ginkgo tests or cluster assertions to evaluate.
Microshift Test Compatibility ✅ Passed The pull request changes CI YAML and a shell script only; it adds no Ginkgo e2e tests, so MicroShift API compatibility checks do not apply.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The complete diff changes only CI configuration, generated periodic-job metadata, and a fast-forward script; it adds no Ginkgo e2e tests or multi-node assumptions.
Topology-Aware Scheduling Compatibility ✅ Passed The diff only pins a Prow periodic job to app.ci and fixes a repository clone path; it adds no topology, affinity, replica, PDB, selector, or toleration constraints.
Ote Binary Stdout Contract ✅ Passed The parent-to-HEAD diff changes only YAML and a shell script; it adds no Go or OTE process-level code and introduces no covered stdout write.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The diff changes YAML and a shell fast-forward job only; it adds no Ginkgo e2e tests, IPv4 assumptions, or test external-connectivity requirements.
No-Weak-Crypto ✅ Passed The diff only changes CI cluster selection and repository cloning; it introduces no MD5, SHA1, DES, RC4, Blowfish, ECB, custom crypto, or secret comparison.
Container-Privileges ✅ Passed The diff adds only app.ci cluster selection, its generated label, and fixed Git paths. No changed manifest contains privileged, host namespace, SYS_ADMIN, root, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs ✅ Passed The diff adds only the public GitHub URL and app.ci configuration, removes repository metadata logs, and leaves the credential helper unchanged without logging the OAuth token.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from cajieh and manusa August 11, 2026 22:33
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 11, 2026
@2uasimojo

Copy link
Copy Markdown
Member Author

/pj-rehearse periodic-ci-openshift-openshift-mcp-server-main-fast-forward-latest-release

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@2uasimojo: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@2uasimojo

Copy link
Copy Markdown
Member Author

Well this is cute. Fixing...

...so it can find the credential secret
@2uasimojo
2uasimojo force-pushed the mcp-server-ff-pin-cluster branch from d69a461 to e3e9847 Compare August 12, 2026 15:36
@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@2uasimojo

Copy link
Copy Markdown
Member Author

/pj-rehearse periodic-ci-openshift-openshift-mcp-server-main-fast-forward-latest-release

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@2uasimojo: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@2uasimojo: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-openshift-mcp-server-main-fast-forward-latest-release N/A periodic Periodic changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci

openshift-ci Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

@2uasimojo: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 12, 2026
@deepsm007

Copy link
Copy Markdown
Contributor

/approve cancel

@2uasimojo

Copy link
Copy Markdown
Member Author

/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 12, 2026

@Cali0707 Cali0707 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@Cali0707

Copy link
Copy Markdown
Contributor

Whoops, just saw the hold comment 😓

@openshift-ci

openshift-ci Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 2uasimojo, Cali0707, grokspawn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

2uasimojo added a commit to 2uasimojo/release that referenced this pull request Aug 13, 2026
Replaces openshift#83135/openshift#83296, putting the job in infra-periodics per protocol.

Assisted-By: cursor/grok-4.5
@2uasimojo

Copy link
Copy Markdown
Member Author

/close

Superseded by #83413

@openshift-ci openshift-ci Bot closed this Aug 13, 2026
@openshift-ci

openshift-ci Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

@2uasimojo: Closed this PR.

Details

In response to this:

/close

Superseded by #83413

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@2uasimojo
2uasimojo deleted the mcp-server-ff-pin-cluster branch August 13, 2026 21:45
2uasimojo added a commit to 2uasimojo/release that referenced this pull request Aug 14, 2026
Replaces openshift#83135/openshift#83296, putting the job in infra-periodics per protocol.

Assisted-By: cursor/grok-4.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants