Skip to content

setup assisted-installer version v2.55 - #83393

Open
danmanor wants to merge 1 commit into
openshift:mainfrom
danmanor:assisted-installer/setup-version-v2.55-10d002b9-e5dc-4b38-ae2a-bf88540bdb7b
Open

setup assisted-installer version v2.55#83393
danmanor wants to merge 1 commit into
openshift:mainfrom
danmanor:assisted-installer/setup-version-v2.55-10d002b9-e5dc-4b38-ae2a-bf88540bdb7b

Conversation

@danmanor

@danmanor danmanor commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

This PR updates OpenShift CI configuration for Assisted Installer v2.55 in both the agent and standard Assisted Installer repositories.

  • Sets always_run: false for the subsystem-test and e2e-metal-assisted tests where applicable.
  • Replaces skip_if_only_changed with pipeline_skip_if_only_changed.
  • Allows these tests to skip when only unrelated files change, while preserving execution for relevant pipeline changes.

@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 5293e2e0-2045-4a8b-bff0-a2df1b0f4b25

📥 Commits

Reviewing files that changed from the base of the PR and between 1af59c4 and a3f5494.

⛔ Files ignored due to path filters (2)
  • ci-operator/jobs/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.55-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/assisted-installer/openshift-assisted-installer-v2.55-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (2)
  • ci-operator/config/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.55.yaml
  • ci-operator/config/openshift/assisted-installer/openshift-assisted-installer-v2.55.yaml

Walkthrough

The pull request updates assisted installer test configurations. It disables unconditional execution and replaces skip_if_only_changed with pipeline_skip_if_only_changed for the affected tests.

Changes

Test execution filters

Layer / File(s) Summary
Update test execution settings
ci-operator/config/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.55.yaml, ci-operator/config/openshift/assisted-installer/openshift-assisted-installer-v2.55.yaml
The subsystem-test and e2e-metal-assisted definitions set always_run: false and use pipeline_skip_if_only_changed. Their workflows and capabilities remain unchanged.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Mergeability Score: ⚪ Minimal · up to a3f54

This PR updates versioned CI configuration and generated job definitions; the remaining risk is limited to confirming regeneration consistency, with no concrete failure or merge-blocking issue shown, so it is merge-ready after normal checks.

Possibly related PRs

Suggested labels: approved

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the assisted-installer version setup addressed by the configuration changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR modifies CI/CD configuration YAML files, not Ginkgo test code. The custom check targets Ginkgo test titles (It(), Describe(), etc.) and is not applicable here.
Test Structure And Quality ✅ Passed The diff changes only CI YAML configuration and generated Prow job YAML. It adds no Ginkgo test code, It blocks, cluster operations, waits, or assertions for this check to assess.
Microshift Test Compatibility ✅ Passed The commit changes four YAML CI configuration/job files only; it adds no Ginkgo test source or It/Describe/Context/When declarations, so this check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The PR changes only four YAML CI configuration files; the diff adds no Ginkgo tests or multi-node assumptions.
Topology-Aware Scheduling Compatibility ✅ Passed The diff only changes CI test filtering fields and generated Prow annotations; it adds no deployment, operator, controller, or topology scheduling constraints.
Ote Binary Stdout Contract ✅ Passed The diff changes only four CI YAML files, adding scheduling fields and annotations; it introduces no OTE binary, main, suite setup, or stdout-writing code.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The commit changes only four CI YAML files for test scheduling; it adds no Ginkgo tests, networking code, URLs, IP addresses, or external connectivity.
No-Weak-Crypto ✅ Passed The parent-to-HEAD diff changes only CI test scheduling and generated annotations; no MD5, SHA1, DES, RC4, Blowfish, ECB, crypto code, or secret comparisons were introduced.
Container-Privileges ✅ Passed Pull request modifies CI/CD test configuration files only, changing test execution behavior (always_run and skip_if_only_changed settings). No container privilege settings (privileged, hostPID, hos...
No-Sensitive-Data-In-Logs ✅ Passed The HEAD^..HEAD diff changes only YAML scheduling fields and generated annotations; the added-line scan found no logging statements or sensitive data.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from avishayt and eranco74 August 13, 2026 15:28
@openshift-ci

openshift-ci Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danmanor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 13, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@danmanor: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-assisted-installer-v2.55-e2e-metal-assisted openshift/assisted-installer presubmit Ci-operator config changed
pull-ci-openshift-assisted-installer-agent-v2.55-e2e-metal-assisted openshift/assisted-installer-agent presubmit Ci-operator config changed
pull-ci-openshift-assisted-installer-agent-v2.55-subsystem-test openshift/assisted-installer-agent presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci

openshift-ci Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

@danmanor: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants