Enable TLS scanner for COO

[simonpasquier]

This commit adds another step after running the COO e2e tests to run the TLS scanner to ensure that it meets the TLS security requirements.

Summary by CodeRabbit

• Adds a TLS scanner step to the OpenShift CI configuration for the observability operator.
• Runs the scanner after the COO end-to-end tests.
• Configures the required tls-scanner-tool image and scanner environment variables.
• Verifies TLS security requirements in the observability operator CI workflow.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/config/rhobs/observability-operator/OWNERS [simonpasquier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 575c9f70-8d1f-4d05-9812-7457b82564ee

📥 Commits

Reviewing files that changed from the base of the PR and between 1af59c4 and ef1336e.

📒 Files selected for processing (1)

• ci-operator/config/rhobs/observability-operator/rhobs-observability-operator-main.yaml

---

Walkthrough

The observability operator end-to-end test now includes the tls-scanner-tool image, TLS scanner environment settings, PQC checks, resource limits, and a tls-scanner-run step.

Changes

TLS scanner integration

Layer / File(s)	Summary
Scanner image and test settings ci-operator/config/rhobs/observability-operator/rhobs-observability-operator-main.yaml	The configuration references the tls-scanner image and defines scanner namespace, PQC, CPU, and memory settings.
Scanner workflow execution ci-operator/config/rhobs/observability-operator/rhobs-observability-operator-main.yaml	The end-to-end test workflow adds the tls-scanner-run step.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Mergeability Score: ⚪ Minimal · up to ef133

The PR adds a localized TLS-scanner step to the COO CI workflow. No actionable merge-blocking risk remains; it is merge-ready after normal checks.

Possibly related PRs

• openshift/release#83165: Adds TLS scanner tooling and CI verification for another service configuration.
• openshift/release#83252: Adds the TLS scanner image, environment settings, and post-test scanner step for another end-to-end test.

---

Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error)

Check name	Status	Explanation	Resolution
Container-Privileges	❌ Error	The new tls-scanner-run ref activates the existing default path, which generates a Pod with hostNetwork: true, hostPID: true, and privileged: true.	Run the scanner in restricted pod mode, or provide a non-privileged scanner implementation that does not require hostNetwork, hostPID, or privileged access.

✅ Passed checks (14 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the main change: enabling the TLS scanner for the COO end-to-end tests.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The parent diff adds only YAML image, static scanner environment values, and a tls-scanner-run reference; it adds no Ginkgo test title or dynamic title value.
Test Structure And Quality	✅ Passed	The commit changes only one CI YAML file; it adds no Ginkgo It blocks, assertions, fixtures, or setup code. The referenced TLS scanner is a shell step with a declared 4h timeout.
Microshift Test Compatibility	✅ Passed	The PR changes only one CI YAML file: it adds a TLS scanner image, environment variables, and a step reference. It adds no Ginkgo e2e tests or OpenShift API usage.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The PR diff only adds CI YAML settings and an existing tls-scanner-run ref; it adds no Ginkgo It/Describe/Context/When test, so this SNO check is inapplicable.
Topology-Aware Scheduling Compatibility	✅ Passed	The diff adds a TLS scanner image, environment values, and an existing step reference; it adds no topology, affinity, selector, replica, PDB, or toleration constraints.
Ote Binary Stdout Contract	✅ Passed	The diff changes only one YAML file; no OTE Go source or suite setup changed. The scanner runs as an external pod binary and writes results under /results.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The diff only updates CI YAML; it adds no Ginkgo test or IPv4/public endpoint. The scanner uses an internal image stream and cluster pod scanning.
No-Weak-Crypto	✅ Passed	The diff only adds TLS scanner configuration and a PQC check; it introduces no MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB, custom crypto, or secret comparisons.
No-Sensitive-Data-In-Logs	✅ Passed	The diff adds only scanner configuration and non-sensitive resource/namespace values; it adds no passwords, tokens, PII, or logging statements.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@simonpasquier: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-rhobs-observability-operator-main-ci-index-observability-bundle	rhobs/observability-operator	presubmit	Ci-operator config changed
pull-ci-rhobs-observability-operator-main-images	rhobs/observability-operator	presubmit	Ci-operator config changed
pull-ci-rhobs-observability-operator-main-observability-operator-e2e	rhobs/observability-operator	presubmit	Ci-operator config changed
periodic-ci-rhobs-observability-operator-main-amd64-ocp-4.14-azure-coo-stage	N/A	periodic	Ci-operator config changed
periodic-ci-rhobs-observability-operator-main-amd64-ocp-4.21-gcp-interop-coo-production	N/A	periodic	Ci-operator config changed
periodic-ci-rhobs-observability-operator-main-upstream-ocp-4.19-aws-coo-compat	N/A	periodic	Ci-operator config changed
periodic-ci-rhobs-observability-operator-main-amd64-ocp-4.17-gcp-coo-stage-dast	N/A	periodic	Ci-operator config changed
periodic-ci-rhobs-observability-operator-main-amd64-ocp-4.20-azure-coo-stage	N/A	periodic	Ci-operator config changed
periodic-ci-rhobs-observability-operator-main-amd64-ocp-4.18-gcp-coo-stage	N/A	periodic	Ci-operator config changed
periodic-ci-rhobs-observability-operator-main-amd64-ocp-4.21-azure-coo-stage	N/A	periodic	Ci-operator config changed
periodic-ci-rhobs-observability-operator-main-arm64-ocp-4.16-gcp-coo-stage	N/A	periodic	Ci-operator config changed
periodic-ci-rhobs-observability-operator-main-amd64-ocp-4.19-gcp-coo-stage	N/A	periodic	Ci-operator config changed
periodic-ci-rhobs-observability-operator-main-amd64-ocp-4.22-gcp-coo-stage	N/A	periodic	Ci-operator config changed
periodic-ci-rhobs-observability-operator-main-amd64-ocp-4.12-azure-coo-stage	N/A	periodic	Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[simonpasquier]

/pj-rehearse pull-ci-rhobs-observability-operator-main-observability-operator-e2e

[openshift-merge-bot]

@simonpasquier: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[simonpasquier]

/pj-rehearse

[openshift-merge-bot]

@simonpasquier: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci]

@simonpasquier: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.