baremetalds: tolerate IDMS MCP wait in degraded TNF - #83403
Conversation
A fenced master cannot converge its MCP. Allow degraded jobs to continue after a short best-effort wait while retaining strict waits elsewhere. Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
WalkthroughThe bare-metal end-to-end test command now passes ChangesBare-metal readiness handling
Estimated code review effort: 1 (Trivial) | ~5 minutes Mergeability Score: 🟡 Moderate · up to The degraded path could treat authentication, API, or missing-resource failures as a successful MCP wait and continue incorrectly. This is a localized but concrete merge-readiness risk requiring failure classification or explicit owner acceptance. Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-e2e-metal-ovn-two-node-fencing-degraded |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jluhrsen The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
[REHEARSALNOTIFIER]
A total of 2911 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@jluhrsen: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-ci
Bot
added
the
do-not-merge/hold
|
@jluhrsen: requesting more than one rehearsal in one comment is not supported. If you would like to rehearse multiple specific jobs, please separate the job names by a space in a single command. |
|
/hold cancel |
openshift-ci
Bot
removed
the
do-not-merge/hold
|
@anuragthehatter can you PTAL here. I think your PR here accidentally broke the v6 degraded (one of two nodes shutdown) jobs. Thinking this will get them working again without affecting your work. |
|
/pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-e2e-metal-ovn-two-node-fencing-degraded |
|
@jluhrsen: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-e2e-metal-ovn-two-node-fencing-ipv6-degraded |
|
@jluhrsen: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-e2e-metal-ovn-two-node-fencing-dualstack-degraded |
|
@jluhrsen: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@jluhrsen: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
1 participant
A fenced master cannot converge its MCP. Allow degraded jobs to continue after a short best-effort wait while retaining strict waits elsewhere.
Summary by CodeRabbit
Baremetalds degraded TNF jobs now continue when a fenced master cannot converge its MCP. The IDMS setup passes
SKIP_READINESS_CHECKSto the SSH command. When readiness checks are skipped, the job performs a best-effort 2-minute MCP wait. Other jobs retain the mandatory 10-minute MCP wait.