Skip to content

[WIP][Debug] Add wait step to tempo-upstream-tests for OCP 5.0 - #83419

Closed
IshwarKanse wants to merge 2 commits into
openshift:mainfrom
IshwarKanse:debug-tempo-upstream-tests-5.0-20260814
Closed

[WIP][Debug] Add wait step to tempo-upstream-tests for OCP 5.0#83419
IshwarKanse wants to merge 2 commits into
openshift:mainfrom
IshwarKanse:debug-tempo-upstream-tests-5.0-20260814

Conversation

@IshwarKanse

@IshwarKanse IshwarKanse commented Aug 14, 2026

Copy link
Copy Markdown
Member

Summary

  • Adds a wait step to enable debugging of test failures in OCP 5.0
  • Job: tempo-upstream-tests
  • Timeout: 8 hours
  • Removed install-operators and distributed-tracing-tests-tempo-upstream steps per request — only operator bundle install + wait remain

The wait step pauses the workflow after the operator is installed, allowing QE to:

  • SSH into the test environment
  • Inspect system state and logs
  • Debug configuration issues
  • Investigate test failures

⚠️ DO NOT MERGE — close this PR after debugging is complete.

Summary by CodeRabbit

The upstream OCP 5.0 CI workflow for grafana-tempo-operator now installs the operator bundle and then waits for 8 hours. This gives QE time to inspect the environment, logs, and system state during debugging.

The workflow removes the install-operators and distributed-tracing-tests-tempo-upstream steps, along with their unused environment variables. The PR is intended for debugging only and must not be merged.

This adds a wait step to enable debugging of test failures in OCP 5.0.
Removes install-operators and distributed-tracing-tests-tempo-upstream
steps, keeping only the operator install and wait steps.

The wait step pauses the workflow before tests run, allowing QE to:
- SSH into the test environment
- Inspect system state and logs
- Debug configuration issues
- Investigate test failures

OCP Version: 5.0
Job: tempo-upstream-tests
Timeout: 8 hours
@openshift-ci

openshift-ci Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IshwarKanse

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 14, 2026
@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 9e22537a-2cbb-45ac-b150-83baa757bc01

📥 Commits

Reviewing files that changed from the base of the PR and between 413f59b and f090bbe.

📒 Files selected for processing (1)
  • ci-operator/config/openshift/grafana-tempo-operator/openshift-grafana-tempo-operator-main__upstream-ocp-5.0-amd64.yaml
💤 Files with no reviewable changes (1)
  • ci-operator/config/openshift/grafana-tempo-operator/openshift-grafana-tempo-operator-main__upstream-ocp-5.0-amd64.yaml

Walkthrough

The upstream Grafana Tempo workflow now sets an eight-hour timeout and replaces the operator installation and distributed-tracing test steps with a single wait step.

Changes

Tempo upstream workflow

Layer / File(s) Summary
Workflow timeout and execution steps
ci-operator/config/openshift/grafana-tempo-operator/openshift-grafana-tempo-operator-main__upstream-ocp-5.0-amd64.yaml
The workflow removes OPERATORS and SKIP_TESTS, sets TIMEOUT to eight hours, and replaces the installation and test steps with wait.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to f090b

This is a localized debug workflow change, and no supplied evidence identifies a current correctness, availability, permission, or deployment issue; no actionable merge-blocking risk remains beyond the PR’s explicit WIP/do-not-merge intent.

Suggested reviewers: andreasgerstmayr, pavolloffay

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: adding a wait step to the Tempo upstream tests for OCP 5.0 debugging.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The diff changes only CI YAML environment settings; it adds no Ginkgo test titles or dynamic values to test names.
Test Structure And Quality ✅ Passed The commit changes only one CI YAML file and adds no Ginkgo test code, so the listed test-structure requirements are not applicable.
Microshift Test Compatibility ✅ Passed The parent-to-HEAD diff changes only one CI YAML file; it adds no Ginkgo e2e tests or new API/resource references, so this check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The PR changes only one CI YAML file: it removes env settings and test-step refs, then adds an 8-hour wait; no Ginkgo tests or multi-node assumptions were added.
Topology-Aware Scheduling Compatibility ✅ Passed The PR changes only one CI YAML file by removing environment variables; it adds no deployment, operator, controller, or scheduling constraints.
Ote Binary Stdout Contract ✅ Passed The cumulative diff changes only one YAML job, removing test references and adding wait; it adds no Go code or process-level stdout writes.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The diff changes only one CI YAML file; it adds no Ginkgo tests, IPv4 assumptions, or external connectivity commands/endpoints.
No-Weak-Crypto ✅ Passed The PR diff only adds TIMEOUT/ref: wait and removes test settings/steps; it introduces no MD5, SHA1, DES, RC4, Blowfish, ECB, crypto code, or secret comparisons.
Container-Privileges ✅ Passed The PR diff adds only TIMEOUT/ref wait and removes steps; the target has no privilege flags, and bundle installation explicitly uses security-context-config restricted.
No-Sensitive-Data-In-Logs ✅ Passed The PR adds only a generic wait step and timeout. Its script logs timestamps and a fixed temporary path, not passwords, tokens, PII, session IDs, or hostnames; the existing BASE_DOMAIN is unchanged.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@IshwarKanse IshwarKanse changed the title [Debug] Add wait step to tempo-upstream-tests for OCP 5.0 [WIP][Debug] Add wait step to tempo-upstream-tests for OCP 5.0 Aug 14, 2026
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 14, 2026
The install-operators and distributed-tracing-tests-tempo-upstream
steps were removed, so their env vars are no longer declared in any
step and cause validation errors.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@IshwarKanse: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-grafana-tempo-operator-main-upstream-ocp-5.0-amd64-tempo-upstream-tests openshift/grafana-tempo-operator presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@IshwarKanse

Copy link
Copy Markdown
Member Author

/pj-rehearse pull-ci-openshift-grafana-tempo-operator-main-upstream-ocp-5.0-amd64-tempo-upstream-tests

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@IshwarKanse: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci

openshift-ci Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

@IshwarKanse: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant