Skip to content

[WIP] [Debug] Add wait step to opentelemetry-upstream-tests for OCP 5.0 - #83502

Closed
IshwarKanse wants to merge 1 commit into
openshift:mainfrom
IshwarKanse:debug-opentelemetry-upstream-tests-5.0-20260817
Closed

[WIP] [Debug] Add wait step to opentelemetry-upstream-tests for OCP 5.0#83502
IshwarKanse wants to merge 1 commit into
openshift:mainfrom
IshwarKanse:debug-opentelemetry-upstream-tests-5.0-20260817

Conversation

@IshwarKanse

@IshwarKanse IshwarKanse commented Aug 17, 2026

Copy link
Copy Markdown
Member

Summary

  • Adds a wait step to enable debugging of test failures in OCP 5.0
  • Job: opentelemetry-upstream-tests
  • Timeout: 8 hours
  • Removed install-operators and distributed-tracing-tests-opentelemetry-upstream steps and their associated env vars (OPERATORS, SKIP_TESTS) — only operator bundle install + wait remain

The wait step pauses the workflow after the operator is installed, allowing QE to:

  • SSH into the test environment
  • Inspect system state and logs
  • Debug configuration issues
  • Investigate test failures

⚠️ DO NOT MERGE — close this PR after debugging is complete.

Summary by CodeRabbit

  • Updates the OpenTelemetry operator's upstream OCP 5.0 CI job.
  • Removes the test execution steps and related OPERATORS and SKIP_TESTS settings.
  • Adds an 8-hour wait after operator bundle installation so QE can inspect the environment and debug failures.

This adds a wait step to enable debugging of test failures in OCP 5.0.
Removes install-operators and distributed-tracing-tests-opentelemetry-upstream
steps and their associated env vars (OPERATORS, SKIP_TESTS), keeping only
the operator install and wait steps.

The wait step pauses the workflow after the operator is installed, allowing
QE to SSH into the test environment and debug.

OCP Version: 5.0
Job: opentelemetry-upstream-tests
Timeout: 8 hours

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 202f6744-de25-4a36-b518-ead2065f43cc

📥 Commits

Reviewing files that changed from the base of the PR and between 6666d23 and 78b09ab.

📒 Files selected for processing (1)
  • ci-operator/config/openshift/open-telemetry-opentelemetry-operator/openshift-open-telemetry-opentelemetry-operator-main__upstream-ocp-5.0-amd64.yaml

Included review availability: Your plan includes up to 12 reviews per rolling hour; 11 remain after this review.


Walkthrough

The OpenTelemetry operator test configuration now uses an 8-hour timeout, removes OPERATORS and SKIP_TESTS, and depends only on wait after installation.

Changes

OpenTelemetry test configuration

Layer / File(s) Summary
Test timeout and workflow dependency
ci-operator/config/openshift/open-telemetry-opentelemetry-operator/...yaml
The configuration adds an 8-hour TIMEOUT, removes operator-installation and test-skipping settings, and replaces workflow dependencies with wait.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: 🔵 Low · up to 78b09

This PR changes a localized debug workflow and is otherwise mergeable, but the generated CI artifacts must be regenerated and validated before merging.

Possibly related PRs

  • openshift/release#83419: Applies the same OCP 5.0 test-configuration changes to a different operator configuration.

Suggested labels: do-not-merge/work-in-progress

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The patch changes only CI YAML; it adds a static workflow ref and timeout, removes env settings, and introduces no Ginkgo test titles or dynamic values.
Test Structure And Quality ✅ Passed The commit changes only one ci-operator YAML file; it adds a wait step and timeout, with no Ginkgo test code or It/Eventually setup changes to review.
Microshift Test Compatibility ✅ Passed The diff changes only one YAML workflow: it adds TIMEOUT and wait, removes env vars and step references, and adds no Ginkgo tests or MicroShift API usage.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The pull request changes only one CI YAML file; it adds no Ginkgo It/Describe/Context/When tests or multi-node assumptions, so the SNO check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed The diff changes only CI YAML: it adds TIMEOUT and the generic wait step. It introduces no deployment manifest, operator/controller code, or topology-related scheduling constraint.
Ote Binary Stdout Contract ✅ Passed The pull request changes only one YAML test configuration; it adds TIMEOUT and a wait ref, with no OTE binary or process-level stdout code changed.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The diff changes only CI YAML: it adds TIMEOUT and a wait reference, and adds no Ginkgo tests, IPv4 assumptions, or external connectivity.
No-Weak-Crypto ✅ Passed The commit changes only CI workflow YAML: TIMEOUT, environment removal, and a wait reference. The changed lines contain no weak-crypto algorithms, crypto code, or secret comparisons.
Container-Privileges ✅ Passed The PR diff only adds TIMEOUT and ref: wait; the wait step uses cli with no privilege fields, and no privileged, host*, SYS_ADMIN, root, or allowPrivilegeEscalation setting was added.
No-Sensitive-Data-In-Logs ✅ Passed The diff only adds TIMEOUT and a standard wait reference while removing test settings; it introduces no commands or configuration that log passwords, tokens, PII, hostnames, or customer data.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: adding a wait step to the OpenTelemetry upstream tests for OCP 5.0.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@IshwarKanse IshwarKanse changed the title [Debug] Add wait step to opentelemetry-upstream-tests for OCP 5.0 [WIP] [Debug] Add wait step to opentelemetry-upstream-tests for OCP 5.0 Aug 17, 2026
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 17, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@IshwarKanse: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-open-telemetry-opentelemetry-operator-main-upstream-ocp-5.0-amd64-opentelemetry-upstream-tests openshift/open-telemetry-opentelemetry-operator presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci

openshift-ci Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IshwarKanse

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 17, 2026
@IshwarKanse

Copy link
Copy Markdown
Member Author

/pj-rehearse pull-ci-openshift-open-telemetry-opentelemetry-operator-main-upstream-ocp-5.0-amd64-opentelemetry-upstream-tests

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@IshwarKanse: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@IshwarKanse

Copy link
Copy Markdown
Member Author

/pj-rehearse pull-ci-openshift-open-telemetry-opentelemetry-operator-main-upstream-ocp-5.0-amd64-opentelemetry-upstream-tests

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@IshwarKanse: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci

openshift-ci Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

@IshwarKanse: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant