Enable Hermetic Build #55
Conversation
We are doing this to enable hermetic build
openshift-ci
bot
added
the
kind/cleanup
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert, Vincent056 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
approved
|
New changes are detected. LGTM label has been removed. |
To update rpm-lock file base on latest dockerfile
| // replaceImages updates the operator/SELinuxD images. | ||
| func replaceImages(m map[string]interface{}) error { | ||
| const ( | ||
| SPO_OPERATOR_IMAGE_PULLSPEC = "quay.io/redhat-user-workloads/ocp-isc-tenant/security-profiles-operator" |
There was a problem hiding this comment.
I think these will need to point to a registry.redhat.io reference for the bundle image to be something we can ship, right?
| SPO_OPERATOR_IMAGE_PULLSPEC = "quay.io/redhat-user-workloads/ocp-isc-tenant/security-profiles-operator" | ||
| SPO_SELINUXD_IMAGE_PULLSPEC = "quay.io/redhat-user-workloads/ocp-isc-tenant/containers-selinux" | ||
| SPO_SELINUXD_EL9_IMAGE_PULLSPEC = "quay.io/redhat-user-workloads/ocp-isc-tenant/openshift-selinuxd-rhel9-container" | ||
| SPO_RBAC_PROXY_IMAGE_PULLSPEC = "registry.redhat.io/openshift4/ose-kube-rbac-proxy:latest" |
There was a problem hiding this comment.
I also think these need to be image digests. Have we configured Konflux to bump the image references we need to build a bundle image with the correct references?
There was a problem hiding this comment.
Yeah, these need to point to specific builds referenced by image digests.
Otherwise build nudging won't work.
There was a problem hiding this comment.
Grab any successful build in Konflux and add them here. They should be nudged to the latest when this PR gets merged.
What type of PR is this?
/kind cleanup
/
What this PR does / why we need it:
This enables the hermetic Build on Konflux.
Which issue(s) this PR fixes:
None
Does this PR have test?
N/A.
Special notes for your reviewer:
Does this PR introduce a user-facing change?
NONE