fix: warn when trigger condition references missing alert field - #117
Merged
peaktwilight merged 1 commit intoApr 19, 2026
Merged
Conversation
A typo in a trigger condition field name (e.g. "severiy" instead of "severity") silently causes the playbook to never match. Log a warning so misconfigured conditions are visible in logs. Closes opensoar-hq#110
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{"severiy": "critical"}silently causes the playbook to never match — this makes it visible in logsNote: Issue #110 originally described the behavior as matching everything; the actual behavior is the opposite (the playbook is silently skipped). Either way, the root problem is the same — no feedback on misconfigured conditions.
Closes #110