Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry on ContentTooShortError [Train backport] #1129

Open
wants to merge 2 commits into
base: stable/train
Choose a base branch
from

Commits on Sep 8, 2023

  1. Retry on ContentTooShortError

    This patch makes the download_image() to retry automatically on
    ContentTooShortError exception, this is an issue that has been seen on
    the gate, see [0].
    
    [0] https://openstack-ci-reports.ubuntu.com/artifacts/3ae/891712/3/check/focal-wallaby-pacemaker-remote-ssl_masakari/3ae840c/job-output.txt
    
    (cherry picked from commit 91c1cc3)
    freyes committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    aeccf9f View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2023

  1. Use self.assertIsInstance()

    Replace "assert type(...) is Foo" with "self.assertIsInstance(..., Foo)"
    this produces a more meaningful test error message and fixes pep8 rule
    E721[0]
    
    [0] https://www.flake8rules.com/rules/E721.html
    
    (cherry picked from commit f9a4c92)
    freyes committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    3743a0f View commit details
    Browse the repository at this point in the history