Link to original plan moved to dialog sidebar #1295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to streamline original URL handling
OscarBakker
requested review from
IanR01 and
iandebruin98
and removed request for
a team
OscarBakker
changed the title
Openstad Headless
|
||||||||||||||||||||||||||||
| Project |
Openstad Headless
|
| Branch Review |
begroot-ui-tweaks-upstream
|
| Run status |
|
| Run duration | 21m 51s |
| Commit |
|
| Committer | oscarbakker |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
51
|
| View all changes introduced in this branch ↗︎ | |
Openstad Headless
|
||||||||||||||||||||||||||||
| Project |
Openstad Headless
|
| Branch Review |
begroot-ui-tweaks-upstream
|
| Run status |
|
| Run duration | 21m 35s |
| Commit |
|
| Committer | Oscar |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
Failures
|
0
|
|
Flaky
|
0
|
|
Pending
|
0
|
|
Skipped
|
0
|
|
Passing
|
51
|
| View all changes introduced in this branch ↗︎ | |
rudivanhierden
requested changes
Jan 27, 2026
Comment on lines
-280
to
-295
| {originalUrl ? ( | ||
| <> | ||
| <Paragraph className="strong"> | ||
| Dit een vervolg op het volgende plan: | ||
| <Link target="_blank" href={originalUrl}> | ||
| {originalUrl} | ||
| </Link> | ||
| </Paragraph> | ||
|
|
||
| </> | ||
| ) : null} |
Contributor
There was a problem hiding this comment.
Can you make this into an option with backwards compatibility?
Contributor
Author
There was a problem hiding this comment.
added options, let me know it we're on the same line
Comment on lines
-201
to
-216
| { | ||
| originalUrl ? ( | ||
| <> | ||
| <Paragraph className="strong"> | ||
| Dit een vervolg op plan: | ||
| <Link target="_blank" href={originalUrl}> | ||
| {originalUrl} | ||
| </Link> | ||
| </Paragraph> | ||
| </> | ||
| ) : null} |
Contributor
There was a problem hiding this comment.
Can you make this into an option with backwards compatibility?
| )} | ||
| <Heading level={2} appearance="utrecht-heading-4" dangerouslySetInnerHTML={{__html: resource.title}}/> | ||
| <Paragraph dangerouslySetInnerHTML={{__html: elipsizeHTML(resource.summary, 100)}}/> | ||
| <Paragraph dangerouslySetInnerHTML={{__html: elipsizeHTML(resource.description, 200)}}/> |
Contributor
There was a problem hiding this comment.
This should be an option with backwards compatibility in mind.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
De originele pr, ik weet even niet of dit voor amsterdam specifiek is gemaakt.