fix: resolve vega peer dependency conflict #1345
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Override vega-lite to ^5.23.0 to resolve peer dependency conflict with @utrecht/component-library-react which requires vega@^5.25.0. This allows npm install to work without --legacy-peer-deps.
rudivanhierden
requested review from
IanR01 and
iandebruin98
and removed request for
a team
No longer needed after fixing the vega peer dependency conflict.
Openstad Headless
|
||||||||||||||||||||||||||||
| Project |
Openstad Headless
|
| Branch Review |
fix/peer-dependencies
|
| Run status |
|
| Run duration | 21m 31s |
| Commit |
|
| Committer | Rudi van Hierden |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
51
|
| View all changes introduced in this branch ↗︎ | |
Fixes npm ci failure caused by out-of-sync lock file (npm bug #8726). Removes deprecated -ws flag from Dockerfile which is not needed.
iandebruin98
approved these changes
Feb 2, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Override vega-lite to ^5.23.0 to resolve peer dependency conflict with @utrecht/component-library-react which requires vega@^5.25.0.
This allows npm install to work without --legacy-peer-deps.