fix(begrootmodule): add missing default values for explanation and text fields#1404
Open
rawand-shakir-draad wants to merge 1 commit intomainfrom
Open
fix(begrootmodule): add missing default values for explanation and text fields#1404rawand-shakir-draad wants to merge 1 commit intomainfrom
rawand-shakir-draad wants to merge 1 commit intomainfrom
Conversation
…xt fields The explanation fields (step0-3, voteMessage, thankMessage, etc.) were empty on the frontend because they were missing from widget-settings.js defaultConfig. The admin showed hardcoded fallbacks via ?? but these never reached the DB or frontend IIFE merge. - Add 9 missing fields to begrootmodule defaultConfig in widget-settings.js - Remove duplicate showOriginalResource entry - Remove hardcoded Dutch defaults from admin explanation.tsx and text.tsx (widget-settings.js is now the single source of truth)
rawand-shakir-draad
requested review from
IanR01 and
rudivanhierden
and removed request for
a team
Openstad Headless
|
||||||||||||||||||||||||||||
| Project |
Openstad Headless
|
| Branch Review |
fix/begrootmodule-missing-defaults
|
| Run status |
|
| Run duration | 20m 11s |
| Commit |
|
| Committer | rawand-shakir-draad |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
1
|
| View all changes introduced in this branch ↗︎ | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
step0-step3,step3success,voteMessage,thankMessage,showNewsletterButton,newsLetterLink) to begrootmoduledefaultConfiginwidget-settings.jsshowOriginalResourceentry inwidget-settings.jsexplanation.tsxandtext.tsx—widget-settings.jsis now the single source of truthCloses #1405
Context
The explanation fields in the begrootmodule were empty on the frontend. The admin showed hardcoded fallback text (via
??), but these values were never stored in the DB or merged into the frontend IIFE because they were missing fromwidget-settings.jsdefaultConfig.The frontend IIFE serving route already merges
widget-settings.jsdefaults viamerge.recursive, so adding the fields there is sufficient to fix the frontend.Test plan