feat: tabbar supports React.ReactNode for description #4386
Conversation
Walkthrough该 PR 更新了多个模块中关于 Changes
Sequence Diagram(s)sequenceDiagram
participant AS as AccordionSection
participant T as transformLabelWithCodicon
participant RC as ReactComponent
AS->>AS: 接收 metadata.description
alt 描述为字符串
AS->>T: 调用 transformLabelWithCodicon 转换描述
T-->>AS: 返回转换后的描述内容
AS->>AS: 渲染转换后的描述内容
else 描述为 React 组件
AS->>RC: 直接渲染 React 组件
end
Possibly related PRs
Suggested reviewers
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 ESLint
yarn install v1.22.22 ✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
packages/main-layout/src/browser/tabbar-handler.ts (1)
159-159: 修正参数名称中的拼写错误参数名
desciption存在拼写错误，应该为description。建议修改为：
- updateViewDescription(viewId: string, desciption: string | React.ComponentType<any>) { + updateViewDescription(viewId: string, description: string | React.ComponentType<any>) {packages/main-layout/src/browser/accordion/accordion.service.ts (1)
60-60: 修正方法名称中的拼写错误
- 接口中的类型更新正确
- 方法名
updateViewDesciption存在拼写错误，应该为updateViewDescription建议修改为：
- updateViewDesciption(viewId: string, desc: string | React.ComponentType<any>) { + updateViewDescription(viewId: string, desc: string | React.ComponentType<any>) {同时需要更新所有调用此方法的地方。
Also applies to: 201-201
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
packages/core-browser/src/layout/layout.interface.ts(1 hunks)packages/main-layout/src/browser/accordion/accordion.service.ts(2 hunks)packages/main-layout/src/browser/accordion/section.view.tsx(2 hunks)packages/main-layout/src/browser/tabbar-handler.ts(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (8)
- GitHub Check: unittest (ubuntu-latest, 18.x, jsdom)
- GitHub Check: unittest (ubuntu-latest, 18.x, node)
- GitHub Check: build (ubuntu-latest, 20.x)
- GitHub Check: unittest (macos-latest, 18.x, jsdom)
- GitHub Check: build-windows
- GitHub Check: ubuntu-latest, Node.js 20.x
- GitHub Check: unittest (macos-latest, 18.x, node)
- GitHub Check: build (macos-latest, 20.x)
🔇 Additional comments (2)
packages/core-browser/src/layout/layout.interface.ts (1)
35-35: 类型定义更新正确！将
description的类型从string扩展为string | React.ComponentType<any>是一个合理的改动，这样可以支持更丰富的描述内容展示。packages/main-layout/src/browser/accordion/section.view.tsx (1)
29-29: 实现正确且完整！
- 接口定义中正确更新了
description的类型- 渲染逻辑正确处理了字符串和组件两种类型的情况：
- 字符串类型使用
transformLabelWithCodicon处理- 组件类型直接渲染组件
代码实现完整且符合预期。
Also applies to: 188-192
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4386 +/- ##
=======================================
Coverage 53.83% 53.83%
=======================================
Files 1650 1650
Lines 101511 101511
Branches 21968 21960 -8
=======================================
Hits 54646 54646
Misses 38967 38967
Partials 7898 7898
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
/next |
|
🎉 PR Next publish successful! 3.7.2-next-1739945875.0 |
Types
Background or solution
#4322
Changelog
feat: tabbar的描述支持传入React.ReactNode
Summary by CodeRabbit