Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reduce font size in chat components and update MCP tools localiz… #4401

Merged
merged 3 commits into from
Feb 24, 2025

Conversation

Aaaaash
Copy link
Member

@Aaaaash Aaaaash commented Feb 24, 2025

…ation

Types

  • 🎉 New Features
  • 🐛 Bug Fixes
  • 📚 Documentation Changes
  • 💄 Code Style Changes
  • 💄 Style Changes
  • 🪚 Refactors
  • 🚀 Performance Improvements
  • 🏗️ Build System
  • ⏱ Tests
  • 🧹 Chores
  • Other Changes

Background or solution

Changelog

Summary by CodeRabbit

  • Style
    • 调整了聊天界面及相关组件的字体大小和间距,优化了文本显示和布局外观。
  • Refactor
    • 重构了聊天功能结构,将部分交互入口重新整合,并移除了部分不再使用的命令,提升了整体使用体验。
  • New Features
    • 新增了 MCP 工具的本地化支持,为中英文用户提供一致的提示文本。

@opensumi opensumi bot added the 🐞 bug Something isn't working label Feb 24, 2025
@Aaaaash Aaaaash force-pushed the chore/improve-chat-agent-styles branch from aca5311 to 1ee208b Compare February 24, 2025 02:51
@Aaaaash
Copy link
Member Author

Aaaaash commented Feb 24, 2025

/next

Copy link
Contributor

coderabbitai bot commented Feb 24, 2025

Walkthrough

该 PR 主要包含样式更新和组件逻辑调整。样式方面,对多个 CSS 和 LESS 文件中的字体大小统一从 14px 调整为 12px,并对部分组件的内边距进行微调;逻辑方面,将 AIChatView 中与 MCP 功能相关的服务、状态变量及事件监听移除,并将 MCP 工具按钮的逻辑移至 DefaultChatViewHeader 组件;此外,还新增了本地化字符串用于 MCP 工具标题,同时注释掉了部分内联聊天和命令注册代码。

Changes

文件(s) 修改概述
packages/ai-native/src/browser/chat/chat.module.less
packages/ai-native/src/browser/components/chat-history.css
packages/ai-native/src/browser/components/components.module.less
packages/ai-native/src/browser/layout/layout.module.less
更新字体大小(统一调整为 12px)以及调整部分内边距,改善界面布局。
packages/ai-native/src/browser/chat/chat.view.tsx 移除 AIChatView 中的 MCP 相关服务、状态变量和事件监听;将 MCP 工具处理逻辑移至 DefaultChatViewHeader 并调整相关条件渲染。
packages/i18n/src/common/en-US.lang.ts
packages/i18n/src/common/zh-CN.lang.ts
本地化资源更新,新增 MCP 工具标题对应的字符串条目。
packages/startup/entry/sample-modules/ai-native/ai-native.contribution.ts 注释掉内联聊天和 slash 命令注册代码(包括 'ai-explain'、'Explain' 和 'Test'),移除相关功能。

Sequence Diagram(s)

sequenceDiagram
    participant U as 用户
    participant H as DefaultChatViewHeader
    participant D as 对话框

    U->>H: 点击“MCP Tools”按钮
    H->>H: 执行 handleShowMCPTools 方法
    H->>D: 打开 MCP 工具对话框
    D-->>U: 展示 MCP 工具界面
Loading

Suggested labels

💄 style change

Suggested reviewers

  • erha19
  • Ricbet

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

yarn install v1.22.22
[1/4] Resolving packages...
warning [email protected]: This version is no longer supported. Please see https://eslint.org/version-support for other options.
warning eslint > @humanwhocodes/[email protected]: Use @eslint/config-array instead
warning eslint > @humanwhocodes/config-array > @humanwhocodes/[email protected]: Use @eslint/object-schema instead
warning eslint > file-entry-cache > flat-cache > [email protected]: Rimraf versions prior to v4 are no longer supported
warning eslint > file-entry-cache > flat-cache > rimraf > [email protected]: Glob versions prior to v9 are no longer supported
warning eslint > file-entry-cache > flat-cache > rimraf > glob > [email protected]: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
warning eslint-import-resolver-typescript > [email protected]: Glob versions prior to v9 are no longer supported
error Couldn't find any versions for "@opensumi/ide-dev-tool" that matches "workspace:*"
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1ee208b and 2a827ab.

📒 Files selected for processing (5)
  • packages/ai-native/src/browser/chat/chat.module.less (2 hunks)
  • packages/ai-native/src/browser/chat/chat.view.tsx (3 hunks)
  • packages/ai-native/src/browser/mcp/tools/components/index.module.less (1 hunks)
  • packages/i18n/src/common/en-US.lang.ts (1 hunks)
  • packages/i18n/src/common/zh-CN.lang.ts (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (3)
  • packages/ai-native/src/browser/chat/chat.module.less
  • packages/i18n/src/common/en-US.lang.ts
  • packages/i18n/src/common/zh-CN.lang.ts
⏰ Context from checks skipped due to timeout of 90000ms (8)
  • GitHub Check: unittest (ubuntu-latest, 18.x, jsdom)
  • GitHub Check: build (ubuntu-latest, 20.x)
  • GitHub Check: unittest (ubuntu-latest, 18.x, node)
  • GitHub Check: build (macos-latest, 20.x)
  • GitHub Check: unittest (macos-latest, 18.x, jsdom)
  • GitHub Check: ubuntu-latest, Node.js 20.x
  • GitHub Check: build-windows
  • GitHub Check: unittest (macos-latest, 18.x, node)
🔇 Additional comments (3)
packages/ai-native/src/browser/chat/chat.view.tsx (2)

731-770: 代码重构改进了组件职责分离

将 MCP 工具相关的逻辑从 AIChatView 移动到 DefaultChatViewHeader 组件中是一个很好的重构。这样做:

  • 提高了组件的内聚性
  • 使代码结构更加清晰
  • 将 MCP 工具按钮的处理逻辑放在了更合适的位置

850-866: MCP 工具按钮实现完善

按钮实现遵循了最佳实践:

  • 使用 capability 进行功能开关控制
  • 使用本地化字符串
  • 添加了适当的 ARIA 属性以支持无障碍访问
packages/ai-native/src/browser/mcp/tools/components/index.module.less (1)

134-138: 样式更新符合设计规范

.run_cmd_tool 的样式更新:

  • 使用 CSS 变量保证了主题一致性
  • 添加了合适的内边距和圆角
  • 遵循了设计系统规范
✨ Finishing Touches
  • 📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@opensumi
Copy link
Contributor

opensumi bot commented Feb 24, 2025

🎉 PR Next publish successful!

3.7.2-next-1740365741.0

@Aaaaash
Copy link
Member Author

Aaaaash commented Feb 24, 2025

/next

@opensumi
Copy link
Contributor

opensumi bot commented Feb 24, 2025

🎉 PR Next publish successful!

3.7.2-next-1740366031.0

Copy link

codecov bot commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.54%. Comparing base (ebc1030) to head (2a827ab).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4401   +/-   ##
=======================================
  Coverage   53.54%   53.54%           
=======================================
  Files        1652     1652           
  Lines      101904   101904           
  Branches    22049    22041    -8     
=======================================
  Hits        54567    54567           
  Misses      39382    39382           
  Partials     7955     7955           
Flag Coverage Δ
jsdom 49.05% <ø> (ø)
node 12.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@hacke2 hacke2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aaaaash
Copy link
Member Author

Aaaaash commented Feb 24, 2025

/next

@Aaaaash Aaaaash merged commit c6c8bce into main Feb 24, 2025
12 checks passed
@Aaaaash Aaaaash deleted the chore/improve-chat-agent-styles branch February 24, 2025 08:41
@opensumi
Copy link
Contributor

opensumi bot commented Feb 24, 2025

🎉 PR Next publish successful!

3.7.2-next-1740386677.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants