fix: not displayed when widget.disposed #4494

wangxiaojuan · 2025-03-24T11:54:57Z

Types

Background or solution

Changelog

fix: 修复widget为disposed后不展示

Summary by CodeRabbit

Bug Fixes
- 优化了组件展示逻辑，在确保组件仍然有效后再进行显示，从而避免因展示已失效组件而引发的错误。

wangxiaojuan · 2025-03-24T11:55:16Z

/next

coderabbitai · 2025-03-24T11:59:03Z

Walkthrough

在 showWidgetsIfShowed 方法中，添加了对 widget.disposed 状态的检查，确保只有当 widget 未被处置时才调用其 show 方法，防止因调用已处置 widget 的 show 方法而引发错误。此修改提升了代码在生命周期管理方面的稳健性，同时没有影响到导出的实体声明。

Changes

文件	变更摘要
packages/.../comments-thread.ts	在 `showWidgetsIfShowed` 方法中增加了对 `widget.disposed` 状态的判断，只有当 widget 未处置时才调用 `show` 方法。

Sequence Diagram(s)

sequenceDiagram
    participant CT as CommentsThread
    participant W as Widget
    participant E as 编辑器

    E->>CT: 请求显示 widget
    CT->>W: 检查 widget.disposed 状态
    alt widget 未处置
        W->>W: 执行 show()
    else widget 已处置
        CT-->>E: 跳过显示
    end

Possibly related PRs

fix: comments zone widget show hide #4361: 与 CommentsZoneWidget 中 show 方法的调整相关，确保组件生命周期管理的一致性。

Suggested labels

🐞 bug

Suggested reviewers

hacke2
erha19

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

yarn install v1.22.22
[1/4] Resolving packages...
warning [email protected]: This version is no longer supported. Please see https://eslint.org/version-support for other options.
warning eslint > @humanwhocodes/[email protected]: Use @eslint/config-array instead
warning eslint > @humanwhocodes/config-array > @humanwhocodes/[email protected]: Use @eslint/object-schema instead
warning eslint > file-entry-cache > flat-cache > [email protected]: Rimraf versions prior to v4 are no longer supported
warning eslint > file-entry-cache > flat-cache > rimraf > [email protected]: Glob versions prior to v9 are no longer supported
warning eslint > file-entry-cache > flat-cache > rimraf > glob > [email protected]: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
warning eslint-import-resolver-typescript > [email protected]: Glob versions prior to v9 are no longer supported
error Couldn't find any versions for "@opensumi/ide-dev-tool" that matches "workspace:*"
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

packages/comments/src/browser/comments-thread.ts (1)
256-258: 正确地增加了 widget.disposed 检查，避免了对已销毁组件的操作！

这个修改很好地解决了原有代码可能调用已销毁 widget 的 show 方法的问题。在调用 show 方法前检查 widget 是否已被销毁，可以有效避免潜在的错误。

不过，有一个小优化点：既然已经检查了 !widget.disposed，那么后面使用 widget?.show() 中的可选链操作符 ?. 就显得多余了，因为我们已经确定 widget 存在且未被销毁。可以直接使用 widget.show()。
if (!widget.disposed) {
-  widget?.show();
+  widget.show();
}

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 32faed7 and 0db8539.

📒 Files selected for processing (1)

packages/comments/src/browser/comments-thread.ts (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (9)

GitHub Check: 🚀🚀🚀 Next Version for pull request
GitHub Check: ubuntu-latest, Node.js 20.x
GitHub Check: unittest (macos-latest, 18.x, node)
GitHub Check: unittest (macos-latest, 18.x, jsdom)
GitHub Check: unittest (ubuntu-latest, 18.x, jsdom)
GitHub Check: unittest (ubuntu-latest, 18.x, node)
GitHub Check: build (macos-latest, 20.x)
GitHub Check: build (ubuntu-latest, 20.x)
GitHub Check: build-windows

opensumi · 2025-03-24T12:01:07Z

🎉 PR Next publish successful!

3.8.3-next-1742817599.0

codecov · 2025-03-24T12:11:21Z

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 53.13%. Comparing base (32faed7) to head (0db8539).

Files with missing lines	Patch %	Lines
packages/comments/src/browser/comments-thread.ts	0.00%	0 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4494      +/-   ##
==========================================
- Coverage   53.13%   53.13%   -0.01%     
==========================================
  Files        1665     1665              
  Lines      102640   102641       +1     
  Branches    22215    22224       +9     
==========================================
  Hits        54535    54535              
  Misses      40019    40019              
- Partials     8086     8087       +1

Flag	Coverage Δ
jsdom	`48.62% <0.00%> (-0.01%)`	⬇️
node	`12.12% <0.00%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

erha19 · 2025-03-28T08:39:56Z

@wangxiaojuan 这个问题有复现路径吗？

fix: not displayed when widget.disposed

0db8539

opensumi bot added the 🐞 bug Something isn't working label Mar 24, 2025

coderabbitai bot reviewed Mar 24, 2025

View reviewed changes

erha19 approved these changes Mar 28, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: not displayed when widget.disposed #4494

fix: not displayed when widget.disposed #4494

Uh oh!

wangxiaojuan commented Mar 24, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

wangxiaojuan commented Mar 24, 2025

Uh oh!

coderabbitai bot commented Mar 24, 2025

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

opensumi bot commented Mar 24, 2025

Uh oh!

codecov bot commented Mar 24, 2025

Uh oh!

erha19 commented Mar 28, 2025

Uh oh!

Uh oh!

fix: not displayed when widget.disposed #4494

Are you sure you want to change the base?

fix: not displayed when widget.disposed #4494

Uh oh!

Conversation

wangxiaojuan commented Mar 24, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Types

Background or solution

Changelog

Summary by CodeRabbit

Uh oh!

wangxiaojuan commented Mar 24, 2025

Uh oh!

coderabbitai bot commented Mar 24, 2025

Walkthrough

Changes

Sequence Diagram(s)

Possibly related PRs

Suggested labels

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

opensumi bot commented Mar 24, 2025

Uh oh!

codecov bot commented Mar 24, 2025

Codecov Report

Uh oh!

erha19 commented Mar 28, 2025

Uh oh!

Uh oh!

wangxiaojuan commented Mar 24, 2025 •

edited by coderabbitai bot

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)