Remove dependency from Timetable to GTFS-RT TripUpdate #6432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonardehrenfried
force-pushed
the
timetable-gtfs
branch
2 times, most recently
from
9c6b461 to
900b8a6
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6432 +/- ##
==========================================
Coverage 70.31% 70.31%
Complexity 18158 18158
==========================================
Files 2058 2059 +1
Lines 76939 76941 +2
Branches 7771 7771
==========================================
+ Hits 54097 54100 +3
+ Misses 20088 20087 -1
Partials 2754 2754 ☔ View full report in Codecov by Sentry. |
leonardehrenfried
force-pushed
the
timetable-gtfs
branch
from
900b8a6 to
823fd53
Compare
leonardehrenfried
force-pushed
the
timetable-gtfs
branch
from
823fd53 to
fee9471
Compare
optionsome
reviewed
Feb 7, 2025
|
Good catch! |
optionsome
previously approved these changes
Feb 10, 2025
optionsome
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The class Timetable has a dependency on GTFS-RT's TripUpdate. This dependency prevents further refactoring and moving of the transit model to a separate module.
Since the Timetable is now also immutable (since #6017) changing the main code is not very complicated. However, there are some tests that combine testing the Timetable with testing the TimetableSnapshot, which is a bit difficult to untangle.
Issue
Relates to #6431
Unit tests
Lots changed.
Documentation
Maybe @vpaturet could help me updating the Javadoc of TimetableMapper.
Bumping the serialization version id
Only a static methods was moved so I don't think we need it.