correct showScheduleDeviation, enable flex
#1346
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amy-corson-ibigroup
approved these changes
Jan 30, 2025
| @@ -301,6 +301,8 @@ export interface ItineraryConfig { | |||
| showLegDurations?: boolean | |||
| showPlanFirstLastButtons?: boolean | |||
| showRouteFares?: boolean | |||
| /** Whether to show the x minutes late/early in the itinerary body */ | |||
There was a problem hiding this comment.
Weird that AppConfig has these comments and ItineraryConfig doesn't, but I guess having this one be the only item with a comment doesn't really matter?
There was a problem hiding this comment.
Yeah it's the first of many in this file!
miles-grant-ibigroup
assigned daniel-heppner-ibigroup and unassigned miles-grant-ibigroup
daniel-heppner-ibigroup
approved these changes
Feb 11, 2025
daniel-heppner-ibigroup
assigned miles-grant-ibigroup and unassigned daniel-heppner-ibigroup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
showScheduleDeviationwas incorrectly configured to not pull the config from theitinerarysettings object. Additionally there was no flex support. This is now corrected.